[v12,07/26] stash: rename test cases to be more descriptive

Message ID	f595ccc2c1b5dd439e8a6b86959d7a987cf9fb50.1545331726.git.ungureanupaulsebastian@gmail.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <git-owner@kernel.org> From: Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com> To: git@vger.kernel.org Cc: t.gummerer@gmail.com, Johannes.Schindelin@gmx.de Subject: [PATCH v12 07/26] stash: rename test cases to be more descriptive Date: Thu, 20 Dec 2018 21:44:23 +0200 Message-Id: <f595ccc2c1b5dd439e8a6b86959d7a987cf9fb50.1545331726.git.ungureanupaulsebastian@gmail.com> In-Reply-To: <cover.1545331726.git.ungureanupaulsebastian@gmail.com> References: <cover.1545331726.git.ungureanupaulsebastian@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: git-owner@vger.kernel.org Precedence: bulk
Series	Convert "git stash" to C builtin \| expand [v12,00/26] Convert "git stash" to C builtin [v12,01/26] sha1-name.c: add `get_oidf()` which acts like `get_oid()` [v12,02/26] strbuf.c: add `strbuf_join_argv()` [v12,03/26] strbuf.c: add `strbuf_insertf()` and `strbuf_vinsertf()` [v12,04/26] ident: add the ability to provide a "fallback identity" [v12,05/26] stash: improve option parsing test coverage [v12,06/26] t3903: modernize style [v12,07/26] stash: rename test cases to be more descriptive [v12,08/26] stash: add tests for `git stash show` config [v12,09/26] stash: mention options in `show` synopsis [v12,10/26] stash: convert apply to builtin [v12,11/26] stash: convert drop and clear to builtin [v12,12/26] stash: convert branch to builtin [v12,13/26] stash: convert pop to builtin [v12,14/26] stash: convert list to builtin [v12,15/26] stash: convert show to builtin [v12,16/26] stash: convert store to builtin [v12,17/26] stash: convert create to builtin [v12,18/26] stash: convert push to builtin [v12,19/26] stash: make push -q quiet [v12,20/26] stash: convert save to builtin [v12,21/26] stash: optimize `get_untracked_files()` and `check_changes()` [v12,22/26] stash: replace all `write-tree` child processes with API calls [v12,23/26] stash: convert `stash--helper.c` into `stash.c` [v12,24/26] stash: add back the original, scripted `git stash` [v12,25/26] stash: optionally use the scripted version again [v12,26/26] tests: add a special setup where stash.useBuiltin is off

Message ID

f595ccc2c1b5dd439e8a6b86959d7a987cf9fb50.1545331726.git.ungureanupaulsebastian@gmail.com (mailing list archive)

State

New, archived

Headers

From: Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com>
To: git@vger.kernel.org
Cc: t.gummerer@gmail.com, Johannes.Schindelin@gmx.de
Subject: [PATCH v12 07/26] stash: rename test cases to be more descriptive
Date: Thu, 20 Dec 2018 21:44:23 +0200
Message-Id: 
 <f595ccc2c1b5dd439e8a6b86959d7a987cf9fb50.1545331726.git.ungureanupaulsebastian@gmail.com>
In-Reply-To: <cover.1545331726.git.ungureanupaulsebastian@gmail.com>
References: <cover.1545331726.git.ungureanupaulsebastian@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: git-owner@vger.kernel.org
Precedence: bulk

Series

Convert "git stash" to C builtin | expand

Commit Message

Paul-Sebastian Ungureanu Dec. 20, 2018, 7:44 p.m. UTC

Rename some test cases' labels to be more descriptive and under 80
characters per line.

Signed-off-by: Paul-Sebastian Ungureanu <ungureanupaulsebastian@gmail.com>
---
 t/t3903-stash.sh | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/t/t3903-stash.sh b/t/t3903-stash.sh
index 4e83facf23..98c25a671c 100755
--- a/t/t3903-stash.sh
+++ b/t/t3903-stash.sh
@@ -604,7 +604,7 @@  test_expect_success 'stash show -p - no stashes on stack, stash-like argument' '
 	test_cmp expected actual
 '
 
-test_expect_success 'stash drop - fail early if specified stash is not a stash reference' '
+test_expect_success 'drop: fail early if specified stash is not a stash ref' '
 	git stash clear &&
 	test_when_finished "git reset --hard HEAD && git stash clear" &&
 	git reset --hard &&
@@ -618,7 +618,7 @@  test_expect_success 'stash drop - fail early if specified stash is not a stash r
 	git reset --hard HEAD
 '
 
-test_expect_success 'stash pop - fail early if specified stash is not a stash reference' '
+test_expect_success 'pop: fail early if specified stash is not a stash ref' '
 	git stash clear &&
 	test_when_finished "git reset --hard HEAD && git stash clear" &&
 	git reset --hard &&
@@ -682,7 +682,7 @@  test_expect_success 'invalid ref of the form "n", n >= N' '
 	git stash drop
 '
 
-test_expect_success 'stash branch should not drop the stash if the branch exists' '
+test_expect_success 'branch: do not drop the stash if the branch exists' '
 	git stash clear &&
 	echo foo >file &&
 	git add file &&
@@ -693,7 +693,7 @@  test_expect_success 'stash branch should not drop the stash if the branch exists
 	git rev-parse stash@{0} --
 '
 
-test_expect_success 'stash branch should not drop the stash if the apply fails' '
+test_expect_success 'branch: should not drop the stash if the apply fails' '
 	git stash clear &&
 	git reset HEAD~1 --hard &&
 	echo foo >file &&
@@ -707,7 +707,7 @@  test_expect_success 'stash branch should not drop the stash if the apply fails'
 	git rev-parse stash@{0} --
 '
 
-test_expect_success 'stash apply shows status same as git status (relative to current directory)' '
+test_expect_success 'apply: show same status as git status (relative to ./)' '
 	git stash clear &&
 	echo 1 >subdir/subfile1 &&
 	echo 2 >subdir/subfile2 &&
@@ -1048,7 +1048,7 @@  test_expect_success 'stash push -p with pathspec shows no changes only once' '
 	test_i18ncmp expect actual
 '
 
-test_expect_success 'stash push with pathspec shows no changes when there are none' '
+test_expect_success 'push <pathspec>: show no changes when there are none' '
 	>foo &&
 	git add foo &&
 	git commit -m "tmp" &&
@@ -1058,7 +1058,7 @@  test_expect_success 'stash push with pathspec shows no changes when there are no
 	test_i18ncmp expect actual
 '
 
-test_expect_success 'stash push with pathspec not in the repository errors out' '
+test_expect_success 'push: <pathspec> not in the repository errors out' '
 	>untracked &&
 	test_must_fail git stash push untracked &&
 	test_path_is_file untracked

[v12,07/26] stash: rename test cases to be more descriptive

Commit Message

Patch