From patchwork Fri Apr 9 11:27:52 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Steinhardt X-Patchwork-Id: 12193835 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40B54C433B4 for ; Fri, 9 Apr 2021 11:27:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E5ABE61177 for ; Fri, 9 Apr 2021 11:27:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233533AbhDIL2I (ORCPT ); Fri, 9 Apr 2021 07:28:08 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:43561 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233530AbhDIL2I (ORCPT ); Fri, 9 Apr 2021 07:28:08 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 42F115C004A; Fri, 9 Apr 2021 07:27:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Fri, 09 Apr 2021 07:27:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=vUkJjMbAaKnoAL2luhpkldKlHQF JyUo2e/y+BcVSD24=; b=HHWm52cZxR9EKS5yQ34C+yiNuiLbndCUCOzeqnp/glx 0NDvr6WtnWl9peOoB/UpvLjG4I/NHN/Ghmid+zCHaZiA0JG3aaHXhPBlnBXlce72 9tQ9stWRl64IIERBx4TxxCRxFNO7FqWR+pwM12Fs7JvSNDLHrWYMTl/r+LsamZCA Pr9sfroGPZHIdI+ipvMsXPgT/99xFkDQwvYPtsYKccpYNIZpjRxNCL1J+VxZytvu 6QaXo/IObycBydfKBjxSSamzTOFRXzDzHhohWocTvIAmrF753j6xO0g1b5u4Ujge OOu93imqYh2SZpW8rPQOqJqRwJyUU4lt/SezAt/53wA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=vUkJjM bAaKnoAL2luhpkldKlHQFJyUo2e/y+BcVSD24=; b=XND9Il4m07XP5u3cOPocfH 1jIhMJSbS3tcSOq7if8yPP6U/o2RG00MGljY/i3wJIOW6o4IXAgNc09yFgw+dIQE mNjA5qTcFBKGJWeLTYOXLDzB4PxtwmcO4YzqxeYljTOGo3+tdMNMQm4sZVNoQowT DWEgsHW3ywkZrgZae82b5ooKUZf2ccbFyoBG446Be5Atfx+yaHisDFmX8S/AY25Y i7dhSgmNF6Vu9yaSDc3AY+eTF/IHMt5NVvc9AVXrvhBqSiJS7HeXC+GYy3N+z9Dp lCtqbmNkwwCWRdCsPauztWhGbqeEtGsibVOoD5zPmj3Ub6TN4iKim/1CmPlCH7LQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekuddggeduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefrrghtrhhi tghkucfuthgvihhnhhgrrhguthcuoehpshesphhkshdrihhmqeenucggtffrrghtthgvrh hnpeehgefhtdefueffheekgfffudelffejtdfhvdejkedthfehvdelgfetgfdvtedthfen ucfkphepjeejrdduledurdekrdduieelnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomhepphhssehpkhhsrdhimh X-ME-Proxy: Received: from vm-mail.pks.im (x4dbf08a9.dyn.telefonica.de [77.191.8.169]) by mail.messagingengine.com (Postfix) with ESMTPA id 56188240067; Fri, 9 Apr 2021 07:27:54 -0400 (EDT) Received: from localhost (ncase [10.192.0.11]) by vm-mail.pks.im (OpenSMTPD) with ESMTPSA id 050ef418 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 9 Apr 2021 11:27:54 +0000 (UTC) Date: Fri, 9 Apr 2021 13:27:52 +0200 From: Patrick Steinhardt To: git@vger.kernel.org Cc: Jeff King , Christian Couder , Taylor Blau Subject: [PATCH v3 1/8] uploadpack.txt: document implication of `uploadpackfilter.allow` Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org When `uploadpackfilter.allow` is set to `true`, it means that filters are enabled by default except in the case where a filter is explicitly disabled via `uploadpackilter..allow`. This option will not only enable the currently supported set of filters, but also any filters which get added in the future. As such, an admin which wants to have tight control over which filters are allowed and which aren't probably shouldn't ever set `uploadpackfilter.allow=true`. Amend the documentation to make the ramifications more explicit so that admins are aware of this. Signed-off-by: Patrick Steinhardt --- Documentation/config/uploadpack.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/config/uploadpack.txt b/Documentation/config/uploadpack.txt index b0d761282c..6729a072ea 100644 --- a/Documentation/config/uploadpack.txt +++ b/Documentation/config/uploadpack.txt @@ -59,7 +59,8 @@ uploadpack.allowFilter:: uploadpackfilter.allow:: Provides a default value for unspecified object filters (see: the - below configuration variable). + below configuration variable). If set to `true`, this will also + enable all filters which get added in the future. Defaults to `true`. uploadpackfilter..allow::