From patchwork Mon Apr 12 13:37:20 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Patrick Steinhardt X-Patchwork-Id: 12198075 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B5C0C433ED for ; Mon, 12 Apr 2021 13:37:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 35B5A61350 for ; Mon, 12 Apr 2021 13:37:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241897AbhDLNhm (ORCPT ); Mon, 12 Apr 2021 09:37:42 -0400 Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:51499 "EHLO wout4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239686AbhDLNhl (ORCPT ); Mon, 12 Apr 2021 09:37:41 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id 0106316D9; Mon, 12 Apr 2021 09:37:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Mon, 12 Apr 2021 09:37:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pks.im; h=date :from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=wJt1DRqH9VzoI6RnSk3LY07ur99 w3JGZaC/dRpYS1sQ=; b=nVGrt1PWgbVvCaUvM4qGb1Z91K69hkZ9EWKJ80OtEnV 0CAzdBPdyJYtrVr3NkkarE2YdN5JEnZCHEHhsfYxqjgJy+LXd6C1yGeKwjzmM6sO 1ns4WAItv3wds+hzJxgiHDvrNvkqPfTZOverg8xzLtY8dFbBrhE53sbeKMEwASJB q4SpZgFUGvMvhgoEEmAVOxkMPW8BKM4HTiUPXd90KqVY6oadQeq+mbKgSRCT+OMh mofQmoioQJgx6QzM/zb8s0iAzfQG1XetEwrG/wRNRbPdSZZVKV+p+YofXyNvj+ne zA/MikNnyZgsUj8ZjnXxFlFUNnAuN34HpBU4aJ6WDVw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=wJt1DR qH9VzoI6RnSk3LY07ur99w3JGZaC/dRpYS1sQ=; b=Z7UYrlZpCOQSFvV8vP8xPx o3piZed3Qhz1uCNZRt9YWGScSfV8RGx9zqHqpFD/t6UAyOO/mysmf+VIM47yhMwg Fyn3iMGhifyJwCPi9Vn0fGKB4cpRjXTcHyZS2o/WxX62TQkZD6SDdcWRZSXCTg+f 6QrzuQNZLPyB/G3ZMnvFlrdQ16ltMrA+CSikxat63jU/z8p7UnjtvVJtOD1etvEN n++dzK5FI0g/JQ0K9ak6UR5CJCXqG/wyqZ/mnjKj8Ufmy/9np7d85uuFePNnmrVk V0U8zVWW8wUiZ5nphKEjzGc5sJ69L1DUNOYrGbyxf7UdTHPWN6RHzJzZ4RIgJnDw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudekjedgieejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefrrghtrhhi tghkucfuthgvihhnhhgrrhguthcuoehpshesphhkshdrihhmqeenucggtffrrghtthgvrh hnpeehgefhtdefueffheekgfffudelffejtdfhvdejkedthfehvdelgfetgfdvtedthfen ucfkphepjeekrdehhedrfeehrdeftdenucevlhhushhtvghrufhiiigvpedtnecurfgrrh grmhepmhgrihhlfhhrohhmpehpshesphhkshdrihhm X-ME-Proxy: Received: from vm-mail.pks.im (dynamic-078-055-035-030.78.55.pool.telefonica.de [78.55.35.30]) by mail.messagingengine.com (Postfix) with ESMTPA id DFCBB24005A; Mon, 12 Apr 2021 09:37:21 -0400 (EDT) Received: from localhost (ncase [10.192.0.11]) by vm-mail.pks.im (OpenSMTPD) with ESMTPSA id 59de14f7 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 12 Apr 2021 13:37:21 +0000 (UTC) Date: Mon, 12 Apr 2021 15:37:20 +0200 From: Patrick Steinhardt To: git@vger.kernel.org Cc: Jeff King , Christian Couder , Taylor Blau , Philip Oakley Subject: [PATCH v4 1/8] uploadpack.txt: document implication of `uploadpackfilter.allow` Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org When `uploadpackfilter.allow` is set to `true`, it means that filters are enabled by default except in the case where a filter is explicitly disabled via `uploadpackilter..allow`. This option will not only enable the currently supported set of filters, but also any filters which get added in the future. As such, an admin which wants to have tight control over which filters are allowed and which aren't probably shouldn't ever set `uploadpackfilter.allow=true`. Amend the documentation to make the ramifications more explicit so that admins are aware of this. Signed-off-by: Patrick Steinhardt --- Documentation/config/uploadpack.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Documentation/config/uploadpack.txt b/Documentation/config/uploadpack.txt index b0d761282c..6729a072ea 100644 --- a/Documentation/config/uploadpack.txt +++ b/Documentation/config/uploadpack.txt @@ -59,7 +59,8 @@ uploadpack.allowFilter:: uploadpackfilter.allow:: Provides a default value for unspecified object filters (see: the - below configuration variable). + below configuration variable). If set to `true`, this will also + enable all filters which get added in the future. Defaults to `true`. uploadpackfilter..allow::