From patchwork Thu Feb 6 22:55:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Arver via GitGitGadget X-Patchwork-Id: 11369361 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 03A0392A for ; Thu, 6 Feb 2020 22:56:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D6AC520730 for ; Thu, 6 Feb 2020 22:56:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="KuCzTrkV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727162AbgBFW4D (ORCPT ); Thu, 6 Feb 2020 17:56:03 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:45245 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727000AbgBFW4C (ORCPT ); Thu, 6 Feb 2020 17:56:02 -0500 Received: by mail-wr1-f66.google.com with SMTP id a6so352677wrx.12 for ; Thu, 06 Feb 2020 14:56:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:in-reply-to:references:from:date:subject:fcc :content-transfer-encoding:mime-version:to:cc; bh=wNGDZz1ZqCpXmCvb0HnNmy909SX9mnqHH2KZdKl4tJY=; b=KuCzTrkV5WhFdyjPbxtvGeUVr+iUjyDxlUfUbdqO8mcAy75065myLGlUf+gmmCFL5C +MtmWlxJ3lZua5IfD1SE4ylKIGfsfgoY8V7nhJdLEiMidiw1bvxOWmnk4GEqlePxsSUX n3M/xU9aZJAUoQ4UrRVcQNs9ip36CiVK0PyheCcGJ5sqFsUXAbRlBQKhdGT9BeU12Ufo BBdBRmiAy7eSNlJpbauWDR9j+KX61gngl5cc0y37Sd3iOVT/433so9oobtgvgh1TXZL/ OqOo7L4WMl2xQQKQ7/sByhJyd0DetViE8fdHXCFnUcivT7VxTmYK8BeeRko7qwB4f9CP hIEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:in-reply-to:references:from:date :subject:fcc:content-transfer-encoding:mime-version:to:cc; bh=wNGDZz1ZqCpXmCvb0HnNmy909SX9mnqHH2KZdKl4tJY=; b=junIj0os+jyCs6M4FEnhaOCTnKZJdfZa1mqakmYBIMHZ1Xjt0Btv05N0iTZtKtz/+P lXupUPkwcFMKSCrX7wSW1wOc7WPs0mHoQGZp0Zs8jcr9t9CqcBoJayzet5Fr7VGSADvC Wn4EEUT6Hc6E6NT2nV/jWE9QYkyZPiUS02r2T3erD0fRlvHmEwHE8qjW+oVIBGfr0ssQ Wjpfr4NNlRxJJ2xhtpadZNGcqbJdtk4XHPG5/j+sIBTJ6I3vEfSoW3tfqAmCjJjpOeXz 1OjdorcglswM19YQQsizV1pZmgt/kpXLfWv7T0ucc6IkNq68MNv7iDiN1LcKCakkDACq YDmw== X-Gm-Message-State: APjAAAWb3IYG/KekNNZc56R74xBGuFZrItJFgKNg7eHuE4tAlmVGWWf+ v6KhpqR+kMzdvy50aSVY9hVqjSig X-Google-Smtp-Source: APXvYqwGJ/KEBf+ugnxtLMhZjhCwRh+gky0dG6fvyCeWlwKRHIm96O8lT4UyPC1xXY9DrvTe0EVEEw== X-Received: by 2002:adf:dd8a:: with SMTP id x10mr300424wrl.117.1581029760342; Thu, 06 Feb 2020 14:56:00 -0800 (PST) Received: from [127.0.0.1] ([13.74.141.28]) by smtp.gmail.com with ESMTPSA id 18sm1033974wmf.1.2020.02.06.14.55.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Feb 2020 14:55:59 -0800 (PST) Message-Id: In-Reply-To: References: From: "Han-Wen Nienhuys via GitGitGadget" Date: Thu, 06 Feb 2020 22:55:54 +0000 Subject: [PATCH v4 3/5] refs: document how ref_iterator_advance_fn should handle symrefs Fcc: Sent MIME-Version: 1.0 To: git@vger.kernel.org Cc: Han-Wen Nienhuys , Han-Wen Nienhuys Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org From: Han-Wen Nienhuys Signed-off-by: Han-Wen Nienhuys --- refs/refs-internal.h | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/refs/refs-internal.h b/refs/refs-internal.h index ff2436c0fb..1d7a485220 100644 --- a/refs/refs-internal.h +++ b/refs/refs-internal.h @@ -438,6 +438,11 @@ void base_ref_iterator_free(struct ref_iterator *iter); /* Virtual function declarations for ref_iterators: */ +/* + * backend-specific implementation of ref_iterator_advance. + * For symrefs, the function should set REF_ISSYMREF, and it should also dereference + * the symref to provide the OID referent. + */ typedef int ref_iterator_advance_fn(struct ref_iterator *ref_iterator); typedef int ref_iterator_peel_fn(struct ref_iterator *ref_iterator,