diff mbox series

[01/17] cocci: remove dead rule from "the_repository.pending.cocci"

Message ID patch-01.17-c167bde3c0c-20230317T152724Z-avarab@gmail.com (mailing list archive)
State Accepted
Commit 49c2d93ecf08b47698f9437372965b6f9d3af9fc
Headers show
Series cocci: remove "the_index" wrapper macros | expand

Commit Message

Ævar Arnfjörð Bjarmason March 17, 2023, 3:35 p.m. UTC 
The "parse_commit_gently" macro went away in [1], so we don't need to
carry his for its migration.

1. ea3f7e598c8 (revision: use repository from rev_info when parsing
   commits, 2020-06-23)

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 contrib/coccinelle/the_repository.pending.cocci | 8 --------
 1 file changed, 8 deletions(-)

Comments

Eric Sunshine March 17, 2023, 4:14 p.m. UTC | #1 
On Fri, Mar 17, 2023 at 11:42 AM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
> The "parse_commit_gently" macro went away in [1], so we don't need to
> carry his for its migration.

Nit: ECANTPARSE "carry his for its"
Elijah Newren March 19, 2023, 5:53 a.m. UTC | #2 
On Fri, Mar 17, 2023 at 9:41 AM Ævar Arnfjörð Bjarmason
<avarab@gmail.com> wrote:
>
> The "parse_commit_gently" macro went away in [1], so we don't need to
> carry his for its migration.

s/his/this/ ?

> 1. ea3f7e598c8 (revision: use repository from rev_info when parsing
>    commits, 2020-06-23)

Thanks for the explanation and link.


> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  contrib/coccinelle/the_repository.pending.cocci | 8 --------
>  1 file changed, 8 deletions(-)
>
> diff --git a/contrib/coccinelle/the_repository.pending.cocci b/contrib/coccinelle/the_repository.pending.cocci
> index 747d382ff5f..23b97536da5 100644
> --- a/contrib/coccinelle/the_repository.pending.cocci
> +++ b/contrib/coccinelle/the_repository.pending.cocci
> @@ -34,14 +34,6 @@ expression G;
>  + repo_parse_commit_internal(the_repository,
>    E, F, G)
>
> -@@
> -expression E;
> -expression F;
> -@@
> -- parse_commit_gently(
> -+ repo_parse_commit_gently(the_repository,
> -  E, F)
> -
>  @@
>  expression E;
>  @@
> --
> 2.40.0.rc1.1034.g5867a1b10c5
diff mbox series

Patch

diff --git a/contrib/coccinelle/the_repository.pending.cocci b/contrib/coccinelle/the_repository.pending.cocci
index 747d382ff5f..23b97536da5 100644
--- a/contrib/coccinelle/the_repository.pending.cocci
+++ b/contrib/coccinelle/the_repository.pending.cocci
@@ -34,14 +34,6 @@  expression G;
 + repo_parse_commit_internal(the_repository,
   E, F, G)
 
-@@
-expression E;
-expression F;
-@@
-- parse_commit_gently(
-+ repo_parse_commit_gently(the_repository,
-  E, F)
-
 @@
 expression E;
 @@