diff mbox series

[v2,1/2] svn tests: remove legacy re-setup from init-clone test

Message ID patch-1.2-d08e098ea8d-20210412T113247Z-avarab@gmail.com (mailing list archive)
State Accepted
Commit 88fce1219ef816face7b89d039f39767c94a232e
Headers show
Series svn tests: trivial "set -e" in main body of test fixes | expand

Commit Message

Ævar Arnfjörð Bjarmason April 12, 2021, 11:33 a.m. UTC
Remove the immediate "rm -rf .git" from the start of this test. This
was added back in 41337e22f0 (git-svn: add tests for command-line
usage of init and clone commands, 2007-11-17) when there was a "trash"
directory shared by all the tests, but ever since abc5d372ec (Enable
parallel tests, 2008-08-08) we've had per-test trash directories.

So this setup can simply be removed. We could use
TEST_NO_CREATE_REPO=true, but I don't think it's worth the effort to
go out of our way to be different. It doesn't matter that we now have
a redundant .git at the top-level.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
 t/t9117-git-svn-init-clone.sh | 6 ------
 1 file changed, 6 deletions(-)
diff mbox series


diff --git a/t/t9117-git-svn-init-clone.sh b/t/t9117-git-svn-init-clone.sh
index 044f65e9166..62de819a44e 100755
--- a/t/t9117-git-svn-init-clone.sh
+++ b/t/t9117-git-svn-init-clone.sh
@@ -7,12 +7,6 @@  test_description='git svn init/clone tests'
 . ./lib-git-svn.sh
-# setup, run inside tmp so we don't have any conflicts with $svnrepo
-set -e
-rm -r .git
-mkdir tmp
-cd tmp
 test_expect_success 'setup svnrepo' '
 	mkdir project project/trunk project/branches project/tags &&
 	echo foo > project/trunk/foo &&