| Message ID | patch-1.8-5069b3fd0ff-20220317T180439Z-avarab@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 03df6cb833a21e924b02af58df76d93a8e0d9648 |
| Headers | show |
| Series | reflog: migrate fully to parse_options() | expand |
Hi Ævar On 17 Mar 2022, at 14:08, Ævar Arnfjörð Bjarmason wrote: > When reflog.c was lib-ified in 7d3d226e700 (reflog: libify delete > reflog function and helpers, 2022-03-02) these previously "static" > functions were made non-"static", but the argument lists were not > correspondingly indented according to our usual coding style. Let's do > that. > > Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> > --- > reflog.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) > > diff --git a/reflog.c b/reflog.c > index 333fd8708fe..82e5a935117 100644 > --- a/reflog.c > +++ b/reflog.c > @@ -240,8 +240,8 @@ static int unreachable(struct expire_reflog_policy_cb *cb, struct commit *commit > * Return true iff the specified reflog entry should be expired. > */ > int should_expire_reflog_ent(struct object_id *ooid, struct object_id *noid, > - const char *email, timestamp_t timestamp, int tz, > - const char *message, void *cb_data) > + const char *email, timestamp_t timestamp, int tz, > + const char *message, void *cb_data) > { > struct expire_reflog_policy_cb *cb = cb_data; > struct commit *old_commit, *new_commit; > @@ -273,10 +273,10 @@ int should_expire_reflog_ent(struct object_id *ooid, struct object_id *noid, > } > > int should_expire_reflog_ent_verbose(struct object_id *ooid, > - struct object_id *noid, > - const char *email, > - timestamp_t timestamp, int tz, > - const char *message, void *cb_data) > + struct object_id *noid, > + const char *email, > + timestamp_t timestamp, int tz, > + const char *message, void *cb_data) > { > struct expire_reflog_policy_cb *cb = cb_data; > int expire; > @@ -323,8 +323,8 @@ static int is_head(const char *refname) > } > > void reflog_expiry_prepare(const char *refname, > - const struct object_id *oid, > - void *cb_data) > + const struct object_id *oid, > + void *cb_data) > { > struct expire_reflog_policy_cb *cb = cb_data; > struct commit_list *elem; > @@ -377,8 +377,8 @@ void reflog_expiry_cleanup(void *cb_data) > } > > int count_reflog_ent(struct object_id *ooid, struct object_id *noid, > - const char *email, timestamp_t timestamp, int tz, > - const char *message, void *cb_data) > + const char *email, timestamp_t timestamp, int tz, > + const char *message, void *cb_data) > { > struct cmd_reflog_expire_cb *cb = cb_data; > if (!cb->expire_total || timestamp < cb->expire_total) Just wanted to say thanks for fixing these :) > -- > 2.35.1.1384.g7d2906948a1
diff --git a/reflog.c b/reflog.c index 333fd8708fe..82e5a935117 100644 --- a/reflog.c +++ b/reflog.c @@ -240,8 +240,8 @@ static int unreachable(struct expire_reflog_policy_cb *cb, struct commit *commit * Return true iff the specified reflog entry should be expired. */ int should_expire_reflog_ent(struct object_id *ooid, struct object_id *noid, - const char *email, timestamp_t timestamp, int tz, - const char *message, void *cb_data) + const char *email, timestamp_t timestamp, int tz, + const char *message, void *cb_data) { struct expire_reflog_policy_cb *cb = cb_data; struct commit *old_commit, *new_commit; @@ -273,10 +273,10 @@ int should_expire_reflog_ent(struct object_id *ooid, struct object_id *noid, } int should_expire_reflog_ent_verbose(struct object_id *ooid, - struct object_id *noid, - const char *email, - timestamp_t timestamp, int tz, - const char *message, void *cb_data) + struct object_id *noid, + const char *email, + timestamp_t timestamp, int tz, + const char *message, void *cb_data) { struct expire_reflog_policy_cb *cb = cb_data; int expire; @@ -323,8 +323,8 @@ static int is_head(const char *refname) } void reflog_expiry_prepare(const char *refname, - const struct object_id *oid, - void *cb_data) + const struct object_id *oid, + void *cb_data) { struct expire_reflog_policy_cb *cb = cb_data; struct commit_list *elem; @@ -377,8 +377,8 @@ void reflog_expiry_cleanup(void *cb_data) } int count_reflog_ent(struct object_id *ooid, struct object_id *noid, - const char *email, timestamp_t timestamp, int tz, - const char *message, void *cb_data) + const char *email, timestamp_t timestamp, int tz, + const char *message, void *cb_data) { struct cmd_reflog_expire_cb *cb = cb_data; if (!cb->expire_total || timestamp < cb->expire_total)
When reflog.c was lib-ified in 7d3d226e700 (reflog: libify delete reflog function and helpers, 2022-03-02) these previously "static" functions were made non-"static", but the argument lists were not correspondingly indented according to our usual coding style. Let's do that. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- reflog.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-)