[v2,25/30] hooks: allow callers to capture output

Message ID	patch-25.30-251085b7525-20210614T101920Z-avarab@gmail.com (mailing list archive)
State	New, archived
Headers	show Return-Path: <git-owner@kernel.org> From: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= <avarab@gmail.com> To: git@vger.kernel.org Cc: Junio C Hamano <gitster@pobox.com>, Emily Shaffer <emilyshaffer@google.com>, Jeff King <peff@peff.net>, Taylor Blau <me@ttaylorr.com>, Felipe Contreras <felipe.contreras@gmail.com>, Eric Sunshine <sunshine@sunshineco.com>, "brian m . carlson" <sandals@crustytoothpaste.net>, Josh Steadmon <steadmon@google.com>, Jonathan Tan <jonathantanmy@google.com>, Derrick Stolee <stolee@gmail.com>, =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFy?= =?utf-8?b?bWFzb24=?= <avarab@gmail.com> Subject: [PATCH v2 25/30] hooks: allow callers to capture output Date: Mon, 14 Jun 2021 12:33:14 +0200 Message-Id: <patch-25.30-251085b7525-20210614T101920Z-avarab@gmail.com> In-Reply-To: <cover-00.30-00000000000-20210614T101920Z-avarab@gmail.com> References: <cover-00.31-00000000000-20210528T110515Z-avarab@gmail.com> <cover-00.30-00000000000-20210614T101920Z-avarab@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	Minimal restart of "config-based-hooks" \| expand [v2,00/30] Minimal restart of "config-based-hooks" [v2,01/30] hook: add 'run' subcommand [v2,02/30] run-command.h: move find_hook() to hook.h [v2,03/30] hook.c: add a hook_exists() wrapper and use it in bugreport.c [v2,04/30] gc: use hook library for pre-auto-gc hook [v2,05/30] rebase: teach pre-rebase to use hook.h [v2,06/30] am: convert applypatch hooks to use config [v2,07/30] hooks: convert 'post-checkout' hook to hook library [v2,08/30] merge: use config-based hooks for post-merge hook [v2,09/30] git hook run: add an --ignore-missing flag [v2,10/30] send-email: use 'git hook run' for 'sendemail-validate' [v2,11/30] git-p4: use 'git hook' to run hooks [v2,12/30] commit: use hook.h to execute hooks [v2,13/30] read-cache: convert post-index-change hook to use config [v2,14/30] receive-pack: convert push-to-checkout hook to hook.h [v2,15/30] run-command: remove old run_hook_{le,ve}() hook API [v2,16/30] run-command: allow stdin for run_processes_parallel [v2,17/30] hook: support passing stdin to hooks [v2,18/30] am: convert 'post-rewrite' hook to hook.h [v2,19/30] run-command: add stdin callback for parallelization [v2,20/30] hook: provide stdin by string_list or callback [v2,21/30] hook: convert 'post-rewrite' hook in sequencer.c to hook.h [v2,22/30] transport: convert pre-push hook to use config [v2,23/30] reference-transaction: use hook.h to run hooks [v2,24/30] run-command: allow capturing of collated output [v2,25/30] hooks: allow callers to capture output [v2,26/30] receive-pack: convert 'update' hook to hook.h [v2,27/30] post-update: use hook.h library [v2,28/30] receive-pack: convert receive hooks to hook.h [v2,29/30] hooks: fix a TOCTOU in "did we run a hook?" heuristic [v2,30/30] hook-list.h: add a generated list of hooks, like config-list.h

Message ID

patch-25.30-251085b7525-20210614T101920Z-avarab@gmail.com (mailing list archive)

State

New, archived

Headers

From: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?=  <avarab@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>,
 Emily Shaffer <emilyshaffer@google.com>, Jeff King <peff@peff.net>,
 Taylor Blau <me@ttaylorr.com>, Felipe Contreras <felipe.contreras@gmail.com>,
 Eric Sunshine <sunshine@sunshineco.com>,
 "brian m . carlson" <sandals@crustytoothpaste.net>,
 Josh Steadmon <steadmon@google.com>, Jonathan Tan <jonathantanmy@google.com>,
 Derrick Stolee <stolee@gmail.com>, =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFy?=
	=?utf-8?b?bWFzb24=?=  <avarab@gmail.com>
Subject: [PATCH v2 25/30] hooks: allow callers to capture output
Date: Mon, 14 Jun 2021 12:33:14 +0200
Message-Id: <patch-25.30-251085b7525-20210614T101920Z-avarab@gmail.com>
In-Reply-To: <cover-00.30-00000000000-20210614T101920Z-avarab@gmail.com>
References: <cover-00.31-00000000000-20210528T110515Z-avarab@gmail.com>
 <cover-00.30-00000000000-20210614T101920Z-avarab@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

Minimal restart of "config-based-hooks" | expand

Commit Message

Ævar Arnfjörð Bjarmason June 14, 2021, 10:33 a.m. UTC

From: Emily Shaffer <emilyshaffer@google.com>

Some server-side hooks will require capturing output to send over
sideband instead of printing directly to stderr. Expose that capability.

Signed-off-by: Emily Shaffer <emilyshaffer@google.com>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 hook.c | 2 +-
 hook.h | 8 ++++++++
 2 files changed, 9 insertions(+), 1 deletion(-)

diff --git a/hook.c b/hook.c
index 0faa24ec825..17ae65eca31 100644
--- a/hook.c
+++ b/hook.c
@@ -166,7 +166,7 @@  int run_found_hooks(const char *hook_name, const char *hook_path,
 				   pick_next_hook,
 				   notify_start_failure,
 				   options->feed_pipe,
-				   NULL,
+				   options->consume_sideband,
 				   notify_hook_finished,
 				   &cb_data,
 				   "hook",
diff --git a/hook.h b/hook.h
index ff1697d1087..5f895032341 100644
--- a/hook.h
+++ b/hook.h
@@ -49,6 +49,14 @@  struct run_hooks_opt
 	 */
 	feed_pipe_fn feed_pipe;
 	void *feed_pipe_ctx;
+
+	/*
+	 * Populate this to capture output and prevent it from being printed to
+	 * stderr. This will be passed directly through to
+	 * run_command:run_parallel_processes(). See t/helper/test-run-command.c
+	 * for an example.
+	 */
+	consume_sideband_fn consume_sideband;
 };
 
 #define RUN_HOOKS_OPT_INIT { \

[v2,25/30] hooks: allow callers to capture output

Commit Message

Patch