| Message ID | patch-5.6-85b7b7aef37-20211021T155529Z-avarab@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | leaks: miscellaneous small leak fixes | expand |
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes: > When dwim_log() returns the "ref" is always ether NULL or an > xstrdup()'d string. > > Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> > --- > builtin/reflog.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/builtin/reflog.c b/builtin/reflog.c > index bd4c669918d..175c83e7cc2 100644 > --- a/builtin/reflog.c > +++ b/builtin/reflog.c > @@ -653,6 +653,7 @@ static int cmd_reflog_expire(int argc, const char **argv, const char *prefix) > should_expire_reflog_ent, > reflog_expiry_cleanup, > &cb); > + free(ref); OK. When dwim_log() returns false, it would not have touched &ref at all, so the "continue" (not shown in the context above) is not leaking, and this loop looks good. Thanks. > } > return status; > }
diff --git a/builtin/reflog.c b/builtin/reflog.c index bd4c669918d..175c83e7cc2 100644 --- a/builtin/reflog.c +++ b/builtin/reflog.c @@ -653,6 +653,7 @@ static int cmd_reflog_expire(int argc, const char **argv, const char *prefix) should_expire_reflog_ent, reflog_expiry_cleanup, &cb); + free(ref); } return status; }
When dwim_log() returns the "ref" is always ether NULL or an xstrdup()'d string. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- builtin/reflog.c | 1 + 1 file changed, 1 insertion(+)