| Message ID | patch-5.6-eacbfd6be0e-20211021T195538Z-avarab@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | d7927d428cdb6ed0d709fea2e5353d56833ae02e |
| Headers | show |
| Series | Makefile: be less eager to re-build, *.sh code cleanups | expand |
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes: > The is_zero_oid() function in git-submodule.sh has not been used since > e83e3333b57 (submodule: port submodule subcommand 'summary' from shell > to C, 2020-08-13), so we can remove it, and the sane_egrep() function, > dead is_zero_oid() was the only function which still referenced it. > > Unlike some other functions in git-sh-setup.sh, this function has not > been documented in git-sh-setup(1), so per [1] it should be OK to > remove it. I'm still unclear about the future of some of the other > functions[2], but any questions in that area should not apply here. > > 1. https://lore.kernel.org/git/xmqqr1dtgnn8.fsf@gitster.g/ > 1. https://lore.kernel.org/git/87tuiwjfvi.fsf@evledraar.gmail.com/ Don't force readers to go outside of "git log" stream they are reading. Instead, summarize the argument that you base your decision on for readers of your proposed commit log message. > > Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> > --- > git-sh-setup.sh | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/git-sh-setup.sh b/git-sh-setup.sh > index cee053cdc38..758520f5a61 100644 > --- a/git-sh-setup.sh > +++ b/git-sh-setup.sh > @@ -177,10 +177,6 @@ sane_grep () { > GREP_OPTIONS= LC_ALL=C grep @@SANE_TEXT_GREP@@ "$@" > } > > -sane_egrep () { > - GREP_OPTIONS= LC_ALL=C egrep @@SANE_TEXT_GREP@@ "$@" > -} > - > is_bare_repository () { > git rev-parse --is-bare-repository > }
diff --git a/git-sh-setup.sh b/git-sh-setup.sh index cee053cdc38..758520f5a61 100644 --- a/git-sh-setup.sh +++ b/git-sh-setup.sh @@ -177,10 +177,6 @@ sane_grep () { GREP_OPTIONS= LC_ALL=C grep @@SANE_TEXT_GREP@@ "$@" } -sane_egrep () { - GREP_OPTIONS= LC_ALL=C egrep @@SANE_TEXT_GREP@@ "$@" -} - is_bare_repository () { git rev-parse --is-bare-repository }
The is_zero_oid() function in git-submodule.sh has not been used since e83e3333b57 (submodule: port submodule subcommand 'summary' from shell to C, 2020-08-13), so we can remove it, and the sane_egrep() function, dead is_zero_oid() was the only function which still referenced it. Unlike some other functions in git-sh-setup.sh, this function has not been documented in git-sh-setup(1), so per [1] it should be OK to remove it. I'm still unclear about the future of some of the other functions[2], but any questions in that area should not apply here. 1. https://lore.kernel.org/git/xmqqr1dtgnn8.fsf@gitster.g/ 1. https://lore.kernel.org/git/87tuiwjfvi.fsf@evledraar.gmail.com/ Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- git-sh-setup.sh | 4 ---- 1 file changed, 4 deletions(-)