diff mbox series

[v2,1/5] run-command.c: remove dead assignment in while-loop

Message ID patch-v2-1.5-488b24e1c98-20230208T191924Z-avarab@gmail.com (mailing list archive)
State Accepted
Commit 5123e6e7bd3b0bf3777cb77e36d141f76d8604a4
Headers show
Series [v2,1/5] run-command.c: remove dead assignment in while-loop | expand

Commit Message

Ævar Arnfjörð Bjarmason Feb. 8, 2023, 7:21 p.m. UTC
Remove code that's been unused since it was added in
c553c72eed6 (run-command: add an asynchronous parallel child
processor, 2015-12-15).

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 run-command.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Junio C Hamano Feb. 8, 2023, 9:03 p.m. UTC | #1
Ævar Arnfjörð Bjarmason  <avarab@gmail.com> writes:

> Remove code that's been unused since it was added in
> c553c72eed6 (run-command: add an asynchronous parallel child
> processor, 2015-12-15).

Obviously correct.  Thanks, will queue.

>
> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
> ---
>  run-command.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/run-command.c b/run-command.c
> index 50cc011654e..b439c7974ca 100644
> --- a/run-command.c
> +++ b/run-command.c
> @@ -1632,9 +1632,7 @@ static void pp_buffer_stderr(struct parallel_processes *pp,
>  			     const struct run_process_parallel_opts *opts,
>  			     int output_timeout)
>  {
> -	int i;
> -
> -	while ((i = poll(pp->pfd, opts->processes, output_timeout) < 0)) {
> +	while (poll(pp->pfd, opts->processes, output_timeout) < 0) {
>  		if (errno == EINTR)
>  			continue;
>  		pp_cleanup(pp, opts);
diff mbox series

Patch

diff --git a/run-command.c b/run-command.c
index 50cc011654e..b439c7974ca 100644
--- a/run-command.c
+++ b/run-command.c
@@ -1632,9 +1632,7 @@  static void pp_buffer_stderr(struct parallel_processes *pp,
 			     const struct run_process_parallel_opts *opts,
 			     int output_timeout)
 {
-	int i;
-
-	while ((i = poll(pp->pfd, opts->processes, output_timeout) < 0)) {
+	while (poll(pp->pfd, opts->processes, output_timeout) < 0) {
 		if (errno == EINTR)
 			continue;
 		pp_cleanup(pp, opts);