| Message ID | patch-v2-1.6-916761cb50f-20230210T102114Z-avarab@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 6193aaa9f91117922264ac577301d7df0e666131 |
| Headers | show |
| Series | remove USE_THE_INDEX_COMPATIBILITY_MACROS | expand |
Ævar Arnfjörð Bjarmason <avarab@gmail.com> writes: > Replace the "USE_THE_INDEX_COMPATIBILITY_MACROS" define with the > narrower "USE_THE_INDEX_VARIABLE". This could have been done in > 07047d68294 (cocci: apply "pending" index-compatibility to some > "builtin/*.c", 2022-11-19), but I missed it at the time. It's a minor thing but can we stop saying "I did X" or "I didn't do X". It is not just your fault that this was missed. Reviewers also failed to spot it but we are not in the blame passing game. "but it was forgotten", "but it was missed", or "but nobody noticed it" would suffice. The patch is of course good. For this kind of change, if it compiles, it cannot be incorrect ;-) Thanks.
diff --git a/builtin/rm.c b/builtin/rm.c index 4a4aec0d00e..8844f906557 100644 --- a/builtin/rm.c +++ b/builtin/rm.c @@ -3,7 +3,7 @@ * * Copyright (C) Linus Torvalds 2006 */ -#define USE_THE_INDEX_COMPATIBILITY_MACROS +#define USE_THE_INDEX_VARIABLE #include "builtin.h" #include "advice.h" #include "config.h"
Replace the "USE_THE_INDEX_COMPATIBILITY_MACROS" define with the narrower "USE_THE_INDEX_VARIABLE". This could have been done in 07047d68294 (cocci: apply "pending" index-compatibility to some "builtin/*.c", 2022-11-19), but I missed it at the time. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- builtin/rm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)