[v2,16/21] refs API: make refs_ref_exists() not set errno

Message ID	patch-v2-16.21-c4e87181121-20211016T093845Z-avarab@gmail.com (mailing list archive)
State	Accepted
Commit	1e3ccb552f3d9166009ca2bc40b27bbc0c0e2b78
Headers	show Return-Path: <git-owner@kernel.org> From: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= <avarab@gmail.com> To: git@vger.kernel.org Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>, Han-Wen Nienhuys <hanwen@google.com>, =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBC?= =?utf-8?b?amFybWFzb24=?= <avarab@gmail.com> Subject: [PATCH v2 16/21] refs API: make refs_ref_exists() not set errno Date: Sat, 16 Oct 2021 11:39:22 +0200 Message-Id: <patch-v2-16.21-c4e87181121-20211016T093845Z-avarab@gmail.com> In-Reply-To: <cover-v2-00.21-00000000000-20211016T093845Z-avarab@gmail.com> References: <cover-00.20-00000000000-20211013T235900Z-avarab@gmail.com> <cover-v2-00.21-00000000000-20211016T093845Z-avarab@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	refs: stop having the API set "errno" \| expand [v2,00/21] refs: stop having the API set "errno" [v2,01/21] branch tests: test for errno propagating on failing read [v2,02/21] refs API: add a version of refs_resolve_ref_unsafe() with "errno" [v2,03/21] refs API: make refs_read_raw_ref() not set errno [v2,04/21] refs API: make parse_loose_ref_contents() not set errno [v2,05/21] refs API: make refs_rename_ref_available() static [v2,06/21] reflog tests: add --updateref tests [v2,07/21] refs/files: remove "name exist?" check in lock_ref_oid_basic() [v2,08/21] refs API: remove refs_read_ref_full() wrapper [v2,09/21] refs API: make resolve_gitlink_ref() not set errno [v2,10/21] refs API: make loose_fill_ref_dir() not set errno [v2,11/21] refs API: make files_copy_or_rename_ref() et al not set errno [v2,12/21] refs API: ignore errno in worktree.c's add_head_info() [v2,13/21] refs API: ignore errno in worktree.c's find_shared_symref() [v2,14/21] refs tests: ignore ignore errno in test-ref-store helper [v2,15/21] refs API: make refs_resolve_refdup() not set errno [v2,16/21] refs API: make refs_ref_exists() not set errno [v2,17/21] refs API: make resolve_ref_unsafe() not set errno [v2,18/21] refs API: make expand_ref() & repo_dwim_log() not set errno [v2,19/21] refs API: don't expose "errno" in run_transaction_hook() [v2,20/21] refs API: post-migration API renaming [1/2] [v2,21/21] refs API: post-migration API renaming [2/2]

Message ID

patch-v2-16.21-c4e87181121-20211016T093845Z-avarab@gmail.com (mailing list archive)

State

Accepted

Commit

1e3ccb552f3d9166009ca2bc40b27bbc0c0e2b78

Headers

From: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?=  <avarab@gmail.com>
To: git@vger.kernel.org
Cc: Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>,
 Han-Wen Nienhuys <hanwen@google.com>, =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBC?=
	=?utf-8?b?amFybWFzb24=?=  <avarab@gmail.com>
Subject: [PATCH v2 16/21] refs API: make refs_ref_exists() not set errno
Date: Sat, 16 Oct 2021 11:39:22 +0200
Message-Id: <patch-v2-16.21-c4e87181121-20211016T093845Z-avarab@gmail.com>
In-Reply-To: <cover-v2-00.21-00000000000-20211016T093845Z-avarab@gmail.com>
References: <cover-00.20-00000000000-20211013T235900Z-avarab@gmail.com>
 <cover-v2-00.21-00000000000-20211016T093845Z-avarab@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

Series

refs: stop having the API set "errno" | expand

Commit Message

Ævar Arnfjörð Bjarmason Oct. 16, 2021, 9:39 a.m. UTC

Move refs_ref_exists from the legacy refs_resolve_ref_unsafe() to the
new refs_werrres_ref_unsafe(). I have read its callers and determined
that they don't care about errno being set, in particular:

    git grep -W -w -e refs_ref_exists -e ref_exists

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 refs.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/refs.c b/refs.c
index 09452b5e413..8d5a76fbf29 100644
--- a/refs.c
+++ b/refs.c
@@ -309,7 +309,9 @@  int read_ref(const char *refname, struct object_id *oid)
 
 int refs_ref_exists(struct ref_store *refs, const char *refname)
 {
-	return !!refs_resolve_ref_unsafe(refs, refname, RESOLVE_REF_READING, NULL, NULL);
+	int ignore_errno;
+	return !!refs_werrres_ref_unsafe(refs, refname, RESOLVE_REF_READING,
+					 NULL, NULL, &ignore_errno);
 }
 
 int ref_exists(const char *refname)

[v2,16/21] refs API: make refs_ref_exists() not set errno

Commit Message

Patch