| Message ID | patch-v2-2.6-1dfee9bf08e-20230202T093706Z-avarab@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | imap-send: replace auto-probe libcurl with hard dependency | expand |
diff --git a/Documentation/config/imap.txt b/Documentation/config/imap.txt index 06166fb5c04..96b1c0927d8 100644 --- a/Documentation/config/imap.txt +++ b/Documentation/config/imap.txt @@ -26,8 +26,7 @@ imap.port:: imap.sslverify:: A boolean to enable/disable verification of the server certificate - used by the SSL/TLS connection. Default is `true`. Ignored when - imap.tunnel is set. + used by the SSL/TLS connection. imap.preformattedHTML:: A boolean to enable/disable the use of html encoding when sending
This documentation added in [1] claims that imap.{host,port,sslVerify} is ignored if imap.tunnel is set. That's correct in the first two cases, but not for imap.sslVerify. When we're using the tunnel feature we'll call ssl_socket_connect() with a 3rd "verify" argument set to the value of the "imap.sslVerify" config if we're on the !preauth path. There is also a call to ssl_socket_connect() that's specific to the non-tunnel codepath. Perhaps the documentation added in [1] was written for an earlier version of [2] (which was introduced in the same series). There is an earlier version of the patch on-list[3] where there's still a "FIXME" comment indicating that we should read the config in the future before setting "SSL_VERIFY_PEER", which is what we'll do if "imap.sslVerify" is set. 1. c82b0748e53 (Documentation: Improve documentation for git-imap-send(1), 2008-07-09) 2. 684ec6c63cd (git-imap-send: Support SSL, 2008-07-09) 3. https://lore.kernel.org/git/1096648c0806010829n71de92dcmc19ddb87da19931d@mail.gmail.com/ Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- Documentation/config/imap.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)