diff mbox series

[v3,12/26] submodule--helper: fix "errmsg_str" memory leak

Message ID	patch-v3-12.26-d368db73de7-20220721T191249Z-avarab@gmail.com (mailing list archive)
State	Superseded
Headers	show Return-Path: <git-owner@kernel.org> From: =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= <avarab@gmail.com> To: git@vger.kernel.org Cc: Junio C Hamano <gitster@pobox.com>, Glen Choo <chooglen@google.com>, Atharva Raykar <raykar.ath@gmail.com>, Prathamesh Chavan <pc44800@gmail.com>, =?utf-8?b?w4Z2YXIgQXJuZmrDtnLDsCBCamFybWFzb24=?= <avarab@gmail.com> Subject: [PATCH v3 12/26] submodule--helper: fix "errmsg_str" memory leak Date: Thu, 21 Jul 2022 21:13:08 +0200 Message-Id: <patch-v3-12.26-d368db73de7-20220721T191249Z-avarab@gmail.com> In-Reply-To: <cover-v3-00.26-00000000000-20220721T191249Z-avarab@gmail.com> References: <cover-v2-00.24-00000000000-20220719T204458Z-avarab@gmail.com> <cover-v3-00.26-00000000000-20220721T191249Z-avarab@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk
Series	submodule--helper: fix memory leaks \| expand [v3,00/26] submodule--helper: fix memory leaks [v3,01/26] submodule--helper: replace memset() with { 0 }-initialization [v3,02/26] submodule--helper: stop conflating "sb" in clone_submodule() [v3,03/26] submodule--helper: pass a "const struct module_clone_data" to clone_submodule() [v3,04/26] submodule--helper: fix a leak in "clone_submodule" [v3,05/26] submodule--helper: fix trivial get_default_remote_submodule() leak [v3,06/26] submodule--helper: fix most "struct pathspec" memory leaks [v3,07/26] submodule--helper: "struct pathspec" memory leak in module_update() [v3,08/26] submodule--helper: don't leak {run,capture}_command() cp.dir argument [v3,09/26] submodule--helper: add "const" to copy of "update_data" [v3,10/26] submodule--helper: add and use *_release() functions [v3,11/26] submodule--helper: refactor "errmsg_str" to be a "struct strbuf" [v3,12/26] submodule--helper: fix "errmsg_str" memory leak [v3,13/26] submodule--helper: fix "sm_path" and other "module_cb_list" leaks [v3,14/26] submodule--helper: fix a leak with repo_clear() [v3,15/26] submodule--helper: fix a memory leak in get_default_remote_submodule() [v3,16/26] submodule--helper: fix "reference" leak is "module_clone_data" [v3,17/26] submodule--helper: fix obscure leak in module_add() [v3,18/26] submodule--helper: fix a leak in module_add() [v3,19/26] submodule--helper: fix a memory leak in print_status() [v3,20/26] submodule--helper: free some "displaypath" in "struct update_data" [v3,21/26] submodule--helper: rename "int res" to "int ret" [v3,22/26] submodule--helper: add skeleton "goto cleanup" to update_submodule() [v3,23/26] submodule--helper: don't exit() on failure, return [v3,24/26] submodule--helper: free rest of "displaypath" in "struct update_data" [v3,25/26] submodule--helper: fix bad config API usage [v3,26/26] submodule--helper: fix a configure_added_submodule() leak

Commit Message

Ævar Arnfjörð Bjarmason July 21, 2022, 7:13 p.m. UTC

Fix a memory leak introduced in e83e3333b57 (submodule: port submodule
subcommand 'summary' from shell to C, 2020-08-13), we sometimes append
to the "errmsg", and need to free the "struct strbuf".

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 builtin/submodule--helper.c | 1 +
 1 file changed, 1 insertion(+)

diff mbox series

Patch

diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index f794d2b588b..ad11ff20022 100644
--- a/builtin/submodule--helper.c
+++ b/builtin/submodule--helper.c
@@ -1044,6 +1044,7 @@  static void generate_submodule_summary(struct summary_cb *info,
 	free(displaypath);
 	free(src_abbrev);
 	free(dst_abbrev);
+	strbuf_release(&errmsg);
 }
 
 static void prepare_submodule_summary(struct summary_cb *info,