| Message ID | patch-v3-19.23-234b4eb613c-20211116T114334Z-avarab@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Makefile: dependency fixes, make noop runtime ~1.4x faster | expand |
On Tue, Nov 16, 2021 at 01:00:19PM +0100, Ævar Arnfjörð Bjarmason wrote: > Fix an issue in my cfe853e66be (hook-list.h: add a generated list of > hooks, like config-list.h, 2021-09-26), the builtin/help.c was > inadvertently made to depend on hook-list.h, but it's used by > builtin/bugreport.c. > > Reported-by: Mike Hommey <mh@glandium.org> > Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> > --- > Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 0a3f292bf82..bae20eb1b40 100644 > --- a/Makefile > +++ b/Makefile > @@ -2162,8 +2162,9 @@ git$X: git.o GIT-LDFLAGS $(BUILTIN_OBJS) $(GITLIBS) > > help.sp help.s help.o: command-list.h > hook.sp hook.s hook.o: hook-list.h You can remove this line too. Mike
diff --git a/Makefile b/Makefile index 0a3f292bf82..bae20eb1b40 100644 --- a/Makefile +++ b/Makefile @@ -2162,8 +2162,9 @@ git$X: git.o GIT-LDFLAGS $(BUILTIN_OBJS) $(GITLIBS) help.sp help.s help.o: command-list.h hook.sp hook.s hook.o: hook-list.h +builtin/bugreport.sp builtin/bugreport.s builtin/bugreport.o: hook-list.h -builtin/help.sp builtin/help.s builtin/help.o: config-list.h hook-list.h GIT-PREFIX +builtin/help.sp builtin/help.s builtin/help.o: config-list.h GIT-PREFIX builtin/help.sp builtin/help.s builtin/help.o: EXTRA_CPPFLAGS = \ '-DGIT_HTML_PATH="$(htmldir_relative_SQ)"' \ '-DGIT_MAN_PATH="$(mandir_relative_SQ)"' \
Fix an issue in my cfe853e66be (hook-list.h: add a generated list of hooks, like config-list.h, 2021-09-26), the builtin/help.c was inadvertently made to depend on hook-list.h, but it's used by builtin/bugreport.c. Reported-by: Mike Hommey <mh@glandium.org> Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com> --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)