diff mbox series

[v7,16/19] grep API: plug memory leaks by freeing "header_list"

Message ID patch-v7-16.19-2aea4017491-20230206T230142Z-avarab@gmail.com (mailing list archive)
State Accepted
Commit fb2ebe72a37423e7c375d933d3c277b8cc81efba
Headers show
Series leak fixes: various simple leak fixes | expand

Commit Message

Ævar Arnfjörð Bjarmason Feb. 6, 2023, 11:07 p.m. UTC 
When the "header_list" struct member was added in [1], freeing this
field was neglected. Fix that now, so that commands like

	./git -P log -1 --color=always --author=A origin/master

will run leak-free.

1. 80235ba79ef ("log --author=me --grep=it" should find intersection,
   not union, 2010-01-17)

Helped-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
---
 grep.c | 1 +
 1 file changed, 1 insertion(+)
diff mbox series

Patch

diff --git a/grep.c b/grep.c
index f8708e1fd20..92ece4b7fa3 100644
--- a/grep.c
+++ b/grep.c
@@ -795,6 +795,7 @@  static void free_grep_pat(struct grep_pat *pattern)
 void free_grep_patterns(struct grep_opt *opt)
 {
 	free_grep_pat(opt->pattern_list);
+	free_grep_pat(opt->header_list);
 
 	if (opt->pattern_expression)
 		free_pattern_expr(opt->pattern_expression);