Message ID | pull.1192.git.git.1642176433017.gitgitgadget@gmail.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Series | leak tests: ignore some new leaks in a few tests | expand |
On Fri, Jan 14, 2022 at 04:07:12PM +0000, Elijah Newren via GitGitGadget wrote: > From: Elijah Newren <newren@gmail.com> > > These test scripts have not changed at all recently, but topics in seen > have caused these to trigger the linux-leaks test. It has been reported > on list, so let's fix the claim that these are leak free and when > someone investigates and fixes the problem, they can turn it back on. I think this problem was likely introduced by a faulty patch in c2dbe00466 (Merge branch 'ps/avoid-unnecessary-hook-invocation-with-packed-refs' into seen, 2022-01-12), specifically 2e6b34bb1b (refs: open-code deletion of packed refs, 2022-01-07). But the newer version 69840cc0f7 of the same patch (merged via 17d1824959) fixes the leak. As a result, all three of those once-failing tests now pass on 'seen' even when built with SANITIZE=leak. We should be able to discard this patch as a result. Thanks, Taylor
diff --git a/t/t1430-bad-ref-name.sh b/t/t1430-bad-ref-name.sh index ff1c967d550..a3c689819fa 100755 --- a/t/t1430-bad-ref-name.sh +++ b/t/t1430-bad-ref-name.sh @@ -4,7 +4,6 @@ test_description='Test handling of ref names that check-ref-format rejects' GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME -TEST_PASSES_SANITIZE_LEAK=true . ./test-lib.sh test_expect_success setup ' diff --git a/t/t3211-peel-ref.sh b/t/t3211-peel-ref.sh index 9cbc34fc583..37b9d26f4b6 100755 --- a/t/t3211-peel-ref.sh +++ b/t/t3211-peel-ref.sh @@ -4,7 +4,6 @@ test_description='tests for the peel_ref optimization of packed-refs' GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME -TEST_PASSES_SANITIZE_LEAK=true . ./test-lib.sh test_expect_success 'create annotated tag in refs/tags' ' diff --git a/t/t6102-rev-list-unexpected-objects.sh b/t/t6102-rev-list-unexpected-objects.sh index 6f0902b8638..52cde097dd5 100755 --- a/t/t6102-rev-list-unexpected-objects.sh +++ b/t/t6102-rev-list-unexpected-objects.sh @@ -2,7 +2,6 @@ test_description='git rev-list should handle unexpected object types' -TEST_PASSES_SANITIZE_LEAK=true . ./test-lib.sh test_expect_success 'setup well-formed objects' '