[v2] ci(main): upgrade actions/checkout to v3

Commit Message

Óscar Domínguez Celada Dec. 5, 2022, 10:01 a.m. UTC

From: Oscar Dominguez <[e-mail]>

To be up to date with actions/checkout opens the door to use the latest
features if necessary and get the latest security patches.

This also avoids a couple of deprecation warnings in the CI runs.

Note: The `actions/checkout` Action has been known to be broken in i686
containers as of v2, therefore we keep forcing it to v1 there. See
actions/runner#2115 for more details.

Signed-off-by: Oscar Dominguez <[e-mail]>
Signed-off-by: Junio C Hamano <[e-mail]>
Signed-off-by: Johannes Schindelin <[e-mail]>
---
    ci(main): upgrade actions/checkout to v3
    
    
    Description
    ===========
    
    Upgrades actions/checkout to v3 in .github/workflows/main.yml

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-1354%2Foscard0m%2Fpatch-1-v2
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-1354/oscard0m/patch-1-v2
Pull-Request: https://github.com/git/git/pull/1354

Range-diff vs v1:

 1:  2dbb779f7fd ! 1:  26fad15f97a ci(main): upgrade actions/checkout to v3
     @@ Metadata
       ## Commit message ##
          ci(main): upgrade actions/checkout to v3
      
     -    to be up to date with actions/checkout opens the door to use the latest
     +    To be up to date with actions/checkout opens the door to use the latest
          features if necessary and get the latest security patches.
      
     -    Signed-off-by: Oscar Dominguez Celada <[e-mail]>
     +    This also avoids a couple of deprecation warnings in the CI runs.
     +
     +    Note: The `actions/checkout` Action has been known to be broken in i686
     +    containers as of v2, therefore we keep forcing it to v1 there. See
     +    actions/runner#2115 for more details.
     +
     +    Signed-off-by: Oscar Dominguez <[e-mail]>
     +    Signed-off-by: Junio C Hamano <[e-mail]>
     +    Signed-off-by: Johannes Schindelin <[e-mail]>
      
       ## .github/workflows/main.yml ##
      @@ .github/workflows/main.yml: jobs:
     @@ .github/workflows/main.yml: jobs:
           runs-on: ubuntu-latest
           container: ${{matrix.vector.image}}
           steps:
     --    - uses: actions/checkout@v1
      +    - uses: actions/checkout@v3
     ++      if: matrix.vector.jobname != 'linux32'
     +     - uses: actions/checkout@v1
     ++      if: matrix.vector.jobname == 'linux32'
           - run: ci/install-docker-dependencies.sh
           - run: ci/run-build-and-tests.sh
           - name: print test failures
 2:  4ee163b9a2c < -:  ----------- ci(main): linux32 uses actions/checkout@v2


 .github/workflows/main.yml | 17 ++++++++++-------
 1 file changed, 10 insertions(+), 7 deletions(-)


base-commit: bcd6bc478adc4951d57ec597c44b12ee74bc88fb

Comments

Junio C Hamano Dec. 5, 2022, 11:28 p.m. UTC | #1

"Oscar Dominguez via GitGitGadget" <[e-mail]> writes:

> From: Oscar Dominguez <[e-mail]>
>
> To be up to date with actions/checkout opens the door to use the latest
> features if necessary and get the latest security patches.
>
> This also avoids a couple of deprecation warnings in the CI runs.
>
> Note: The `actions/checkout` Action has been known to be broken in i686
> containers as of v2, therefore we keep forcing it to v1 there. See
> actions/runner#2115 for more details.
>
> Signed-off-by: Oscar Dominguez <[e-mail]>
> Signed-off-by: Junio C Hamano <[e-mail]>
> Signed-off-by: Johannes Schindelin <[e-mail]>
> ---

I do not know about Johannes, but the latter two S-o-b by others are
very questionable, as this is the first time I see this iteration of
the patch.  The chain of S-o-b is used to record that the author
handed the patch to somebody else who forwarded it to another
(i.e. the order of custody), and the above makes it look as if I
picked this iteration of your patch up, passed it to Johannes, and
he gave it to the mailing list readers with this message.

If you wanted to say "Input from Johannes helped me greatly while I
polished the earlier work to produce this version", it is more
appropriate to end the proposed log message with:

	Helped-by: Johannes Schindelin <...>
	Signed-off-by: Oscar Dominguez <...>

in chronological order.

In any case, I've been disturbed by the "Node 12 is going away, use
the one that works with Node 16" warning at GitHub CI for the past
few weeks and it is very welcome to see this topic moving forward.

Thanks for working on it.

Patch

diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
index 831f4df56c5..5262823eb1c 100644
--- a/.github/workflows/main.yml
+++ b/.github/workflows/main.yml
@@ -83,7 +83,7 @@  jobs:
     if: needs.ci-config.outputs.enabled == 'yes'
     runs-on: windows-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - uses: git-for-windows/setup-git-for-windows-sdk@v1
     - name: build
       shell: bash
@@ -138,10 +138,10 @@  jobs:
       GIT_CONFIG_PARAMETERS: "'user.name=CI' 'user.email=ci@git'"
     runs-on: windows-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - uses: git-for-windows/setup-git-for-windows-sdk@v1
     - name: initialize vcpkg
-      uses: actions/checkout@v2
+      uses: actions/checkout@v3
       with:
         repository: 'microsoft/vcpkg'
         path: 'compat/vcbuild/vcpkg'
@@ -258,7 +258,7 @@  jobs:
       runs_on_pool: ${{matrix.vector.pool}}
     runs-on: ${{matrix.vector.pool}}
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - run: ci/install-dependencies.sh
     - run: ci/run-build-and-tests.sh
     - name: print test failures
@@ -291,7 +291,10 @@  jobs:
     runs-on: ubuntu-latest
     container: ${{matrix.vector.image}}
     steps:
+    - uses: actions/checkout@v3
+      if: matrix.vector.jobname != 'linux32'
     - uses: actions/checkout@v1
+      if: matrix.vector.jobname == 'linux32'
     - run: ci/install-docker-dependencies.sh
     - run: ci/run-build-and-tests.sh
     - name: print test failures
@@ -311,7 +314,7 @@  jobs:
       jobname: StaticAnalysis
     runs-on: ubuntu-22.04
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - run: ci/install-dependencies.sh
     - run: ci/run-static-analysis.sh
     - run: ci/check-directional-formatting.bash
@@ -331,7 +334,7 @@  jobs:
         artifact: sparse-20.04
     - name: Install the current `sparse` package
       run: sudo dpkg -i sparse-20.04/sparse_*.deb
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - name: Install other dependencies
       run: ci/install-dependencies.sh
     - run: make sparse
@@ -343,6 +346,6 @@  jobs:
       jobname: Documentation
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v2
+    - uses: actions/checkout@v3
     - run: ci/install-dependencies.sh
     - run: ci/test-documentation.sh