| Message ID | pull.1422.git.1668888407433.gitgitgadget@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Makefile: suppress macOS deprecation warning | expand |
On 11/20/22 03:06, Stefan Sundin via GitGitGadget wrote: > From: Stefan Sundin <git@stefansundin.com> > > Compiling git on macOS 13 emits the following deprecation warning: > > CC compat/fsmonitor/fsm-listen-darwin.o > compat/fsmonitor/fsm-listen-darwin.c:495:2: warning: 'FSEventStreamScheduleWithRunLoop' is deprecated: first deprecated in macOS 13.0 - Use FSEventStreamSetDispatchQueue instead. [-Wdeprecated-declarations] > FSEventStreamScheduleWithRunLoop(data->stream, data->rl, kCFRunLoopDefaultMode); > ^ > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/FSEvents.framework/Headers/FSEvents.h:1138:1: note: 'FSEventStreamScheduleWithRunLoop' has been explicitly marked deprecated here > FSEventStreamScheduleWithRunLoop( > ^ > 1 warning generated. > > Setting a minimum macOS version will suppress this deprecation warning. > Using a version lower than 10.13 will cause other warning messages to > be emitted. > Why don't instead follow the suggestion on the warning message (FSEventStreamSetDispatchQueue) instead?
On Sat, Nov 19, 2022 at 5:48 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote: > > On 11/20/22 03:06, Stefan Sundin via GitGitGadget wrote: > > From: Stefan Sundin <git@stefansundin.com> > > > > Compiling git on macOS 13 emits the following deprecation warning: > > > > CC compat/fsmonitor/fsm-listen-darwin.o > > compat/fsmonitor/fsm-listen-darwin.c:495:2: warning: 'FSEventStreamScheduleWithRunLoop' is deprecated: first deprecated in macOS 13.0 - Use FSEventStreamSetDispatchQueue instead. [-Wdeprecated-declarations] > > FSEventStreamScheduleWithRunLoop(data->stream, data->rl, kCFRunLoopDefaultMode); > > ^ > > /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/System/Library/Frameworks/CoreServices.framework/Frameworks/FSEvents.framework/Headers/FSEvents.h:1138:1: note: 'FSEventStreamScheduleWithRunLoop' has been explicitly marked deprecated here > > FSEventStreamScheduleWithRunLoop( > > ^ > > 1 warning generated. > > > > Setting a minimum macOS version will suppress this deprecation warning. > > Using a version lower than 10.13 will cause other warning messages to > > be emitted. > > > > Why don't instead follow the suggestion on the warning message > (FSEventStreamSetDispatchQueue) instead? > > -- > An old man doll... just what I always wanted! - Clara You are right, Bagas. I assumed, without actually looking it up, that the new function had a higher-than-acceptable minimum macOS version requirement. It turns out that the new function was added in 10.6 which is far better than requiring 10.13. Please disregard this patch and I will attempt to update the code to use the new function instead.
On 11/20/22 09:14, Stefan Sundin wrote: > You are right, Bagas. I assumed, without actually looking it up, that > the new function had a higher-than-acceptable minimum macOS version > requirement. It turns out that the new function was added in 10.6 > which is far better than requiring 10.13. > > Please disregard this patch and I will attempt to update the code to > use the new function instead. OK. But unfortunately, I don't have any macOS machines handy, so I can't test your future patch. Thanks.
On 11/20/22 7:29 AM, Bagas Sanjaya wrote: > On 11/20/22 09:14, Stefan Sundin wrote: >> You are right, Bagas. I assumed, without actually looking it up, that >> the new function had a higher-than-acceptable minimum macOS version >> requirement. It turns out that the new function was added in 10.6 >> which is far better than requiring 10.13. >> >> Please disregard this patch and I will attempt to update the code to >> use the new function instead. > > OK. But unfortunately, I don't have any macOS machines handy, so I can't > test your future patch. > > Thanks. > As I mentioned in another thread, I'm working on a solution for this deprecated function. As soon the CI builds finish I'll submit it. Jeff
diff --git a/Makefile b/Makefile index 4927379184c..8a729efd2d1 100644 --- a/Makefile +++ b/Makefile @@ -1430,6 +1430,7 @@ ifneq (,$(SOCKLEN_T)) endif ifeq ($(uname_S),Darwin) + BASIC_CFLAGS += -mmacosx-version-min=10.13 ifndef NO_FINK ifeq ($(shell test -d /sw/lib && echo y),y) BASIC_CFLAGS += -I/sw/include