diff mbox series

t0040: declare non-tab indentation to be okay in this script

Message ID pull.1568.git.1691491054706.gitgitgadget@gmail.com (mailing list archive)
State Accepted
Commit 12009a182b51c1dd1f8020a3d88a1813e0af5f33
Headers show
Series t0040: declare non-tab indentation to be okay in this script | expand

Commit Message

Johannes Schindelin Aug. 8, 2023, 10:37 a.m. UTC 
From: Johannes Schindelin <johannes.schindelin@gmx.de>

By necessity, this script needs to verify that certain Git output
matches expectations, including text indented with spaces instead of
tabs.

Most recently, such a check was introduced in 448abbba6347 (short help:
allow multi-line opthelp, 2023-07-18) which is reported by `git diff
--check 448abbba6347^!` as having whitespace issues.

Let's not complain about this because it is intentional.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
---
    t0040: declare non-tab indentation to be okay in this script
    
    When preparing Git for Windows v2.42.0-rc0, I ran into this issue: the
    Pull Request's check-whitespace run failed. Let's prevent having future
    contributors from also running into this type of issue when modifying
    t0040.

Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-1568%2Fdscho%2Fsuppress-t0040-whitespace-error-v1
Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-1568/dscho/suppress-t0040-whitespace-error-v1
Pull-Request: https://github.com/gitgitgadget/git/pull/1568

 t/.gitattributes | 1 +
 1 file changed, 1 insertion(+)


base-commit: 448abbba63471153df6ba520a5621595557ce3c8

Comments

Taylor Blau Aug. 8, 2023, 8:19 p.m. UTC | #1 
On Tue, Aug 08, 2023 at 10:37:34AM +0000, Johannes Schindelin via GitGitGadget wrote:
> ---
>     t0040: declare non-tab indentation to be okay in this script
>
>     When preparing Git for Windows v2.42.0-rc0, I ran into this issue: the
>     Pull Request's check-whitespace run failed. Let's prevent having future
>     contributors from also running into this type of issue when modifying
>     t0040.

Thanks for hardening these up. This looks obviously correct to me!

Thanks,
Taylor
diff mbox series

Patch

diff --git a/t/.gitattributes b/t/.gitattributes
index 9930e283512..b9cea1795d8 100644
--- a/t/.gitattributes
+++ b/t/.gitattributes
@@ -22,3 +22,4 @@  t[0-9][0-9][0-9][0-9]/* -whitespace
 /t7500/* eol=lf
 /t8005/*.txt eol=lf
 /t9*/*.dump eol=lf
+/t0040*.sh whitespace=-indent-with-non-tab