[v8,0/5] clk: imx: clk-audiomix: Improvement for audiomix

Message

Shengjiu Wang June 14, 2024, 7:41 a.m. UTC

Some improvement for audiomix driver:
Add CLK_SET_RATE_PARENT flags for clocks
Correct parent clock for earc_phy and audpll clocks.
Add reset controller for EARC function, use the auxiliary device
framework:
https://lore.kernel.org/lkml/[e-mail]/

changes in v8:
- drop '_priv' and add 'to_imx8mp_audiomix_reset()' in reset-imx8mp-audiomix.c
- update to 'select AUXILIARY_BUS if RESET_CONTROLLER'

changes in v7:
- add property "#reset-cells" exist check
- change the reset driver to be specific for 8MP-audiomix
  remove the design for general usage.

changes in v6:
- fix type for "correct"
- fix coding style for " * adev"

changes in v5:
- fix miss header issue reported by kernel test robot
  https://lore.kernel.org/oe-kbuild-all/[e-mail]/
- use scoped free

changes in v4:
- use auxiliary device framework for reset controller driver.
- drop syscon and simple-mfd related changes in v3

changes in v3:
- separate reset driver to driver/reset/
- add binding doc for reset driver.
- modify imx8mp.dtsi accordingly

changes in v2:
- add more info in commit messages

Shengjiu Wang (5):
  dt-bindings: clock: imx8mp: Add #reset-cells property
  clk: imx: clk-audiomix: Add reset controller
  reset: imx8mp-audiomix: Add AudioMix Block Control reset driver
  clk: imx: clk-audiomix: Add CLK_SET_RATE_PARENT flags for clocks
  clk: imx: clk-audiomix: Correct parent clock for earc_phy and audpll

 .../bindings/clock/imx8mp-audiomix.yaml       |   3 +
 drivers/clk/imx/Kconfig                       |   1 +
 drivers/clk/imx/clk-imx8mp-audiomix.c         |  86 +++++++++++++-
 drivers/reset/Kconfig                         |   8 ++
 drivers/reset/Makefile                        |   1 +
 drivers/reset/reset-imx8mp-audiomix.c         | 106 ++++++++++++++++++
 6 files changed, 199 insertions(+), 6 deletions(-)
 create mode 100644 drivers/reset/reset-imx8mp-audiomix.c

Comments

Abel Vesa June 21, 2024, 6:26 a.m. UTC | #1

On Fri, 14 Jun 2024 15:41:58 +0800, Shengjiu Wang wrote:
> Some improvement for audiomix driver:
> Add CLK_SET_RATE_PARENT flags for clocks
> Correct parent clock for earc_phy and audpll clocks.
> Add reset controller for EARC function, use the auxiliary device
> framework:
> https://lore.kernel.org/lkml/[e-mail]/
> 
> [...]

Applied, thanks!

[1/5] dt-bindings: clock: imx8mp: Add #reset-cells property
      commit: d7d9ef1f40dc0639ba0901097139fcdc4bedb32e
[2/5] clk: imx: clk-audiomix: Add reset controller
      commit: 6f0e817175c5b2e453f7ad6a4e9a8a7fd904ee4a
[3/5] reset: imx8mp-audiomix: Add AudioMix Block Control reset driver
      commit: b7604e8b805a6e52161ff98728122005e6975a46
[4/5] clk: imx: clk-audiomix: Add CLK_SET_RATE_PARENT flags for clocks
      commit: 163e678c0b24d0e45f617f4496c4ae9b1afd8d63
[5/5] clk: imx: clk-audiomix: Correct parent clock for earc_phy and audpll
      commit: 22fb849ead1b109f868e83b309223d906e4b7d96

Best regards,

Abel Vesa June 21, 2024, 6:36 a.m. UTC | #2

On 24-06-21 09:26:52, Abel Vesa wrote:
> 
> On Fri, 14 Jun 2024 15:41:58 +0800, Shengjiu Wang wrote:
> > Some improvement for audiomix driver:
> > Add CLK_SET_RATE_PARENT flags for clocks
> > Correct parent clock for earc_phy and audpll clocks.
> > Add reset controller for EARC function, use the auxiliary device
> > framework:
> > https://lore.kernel.org/lkml/[e-mail]/
> > 
> > [...]
> 
> Applied, thanks!
> 
> [1/5] dt-bindings: clock: imx8mp: Add #reset-cells property
>       commit: d7d9ef1f40dc0639ba0901097139fcdc4bedb32e
> [2/5] clk: imx: clk-audiomix: Add reset controller
>       commit: 6f0e817175c5b2e453f7ad6a4e9a8a7fd904ee4a
> [3/5] reset: imx8mp-audiomix: Add AudioMix Block Control reset driver
>       commit: b7604e8b805a6e52161ff98728122005e6975a46

Dropped the this one. Needs to go through different tree.

> [4/5] clk: imx: clk-audiomix: Add CLK_SET_RATE_PARENT flags for clocks
>       commit: 163e678c0b24d0e45f617f4496c4ae9b1afd8d63
> [5/5] clk: imx: clk-audiomix: Correct parent clock for earc_phy and audpll
>       commit: 22fb849ead1b109f868e83b309223d906e4b7d96
> 
> Best regards,
> -- 
> Abel Vesa <[e-mail]>
>

Shengjiu Wang June 21, 2024, 8:09 a.m. UTC | #3

Hi Philipp Zabel

On Fri, Jun 21, 2024 at 2:36 PM Abel Vesa <[e-mail]> wrote:
>
> On 24-06-21 09:26:52, Abel Vesa wrote:
> >
> > On Fri, 14 Jun 2024 15:41:58 +0800, Shengjiu Wang wrote:
> > > Some improvement for audiomix driver:
> > > Add CLK_SET_RATE_PARENT flags for clocks
> > > Correct parent clock for earc_phy and audpll clocks.
> > > Add reset controller for EARC function, use the auxiliary device
> > > framework:
> > > https://lore.kernel.org/lkml/[e-mail]/
> > >
> > > [...]
> >
> > Applied, thanks!
> >
> > [1/5] dt-bindings: clock: imx8mp: Add #reset-cells property
> >       commit: d7d9ef1f40dc0639ba0901097139fcdc4bedb32e
> > [2/5] clk: imx: clk-audiomix: Add reset controller
> >       commit: 6f0e817175c5b2e453f7ad6a4e9a8a7fd904ee4a
> > [3/5] reset: imx8mp-audiomix: Add AudioMix Block Control reset driver
> >       commit: b7604e8b805a6e52161ff98728122005e6975a46
>
> Dropped the this one. Needs to go through different tree.

In case that you may miss this commit which is in a clock driver patch set.
Could you please have a review?  Thanks.

https://lore.kernel.org/linux-arm-kernel/[e-mail]/T/#m4bd8091438d9fbe0bd1400005d681483c59607c7

Best regards
Shengjiu Wang

>
> > [4/5] clk: imx: clk-audiomix: Add CLK_SET_RATE_PARENT flags for clocks
> >       commit: 163e678c0b24d0e45f617f4496c4ae9b1afd8d63
> > [5/5] clk: imx: clk-audiomix: Correct parent clock for earc_phy and audpll
> >       commit: 22fb849ead1b109f868e83b309223d906e4b7d96
> >
> > Best regards,
> > --
> > Abel Vesa <[e-mail]>
> >