mbox series

[0/6] EDAC: fsl-ddr, add imx9 support

Message ID 20240709-imx95_edac-v1-0-3e9c146c1b01@nxp.com (mailing list archive)
Headers show
Series EDAC: fsl-ddr, add imx9 support | expand

Message

Frank Li July 9, 2024, 8:23 p.m. UTC 
Add imx9 support for fsl-ddr.

Patch 1-2 is prepare patch, no function chagne
Patch 3 is small fix for bit shift
Patch 4 is dt binding patch.
Patch 5 is driver change to support imx9
Patch 6 is imx93 dts change

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Frank Li (4):
      EDAC: fsl_ddr: Pass down fsl_mc_pdata in ddr_in32() and ddr_out32()
      EDAC, fsl_ddr: Move global variable into struct fsl_mc_pdata
      dt-bindings: memory: fsl: Add compatible string nxp,imx9-memory-controller
      arm64: dts: imx93: add ddr edac support

Priyanka Singh (1):
      EDAC: fsl: Fix bad bit shift operations

Ye Li (1):
      EDAC: fsl_ddr: Add support for i.MX9 DDR controller

 .../bindings/memory-controllers/fsl/fsl,ddr.yaml   |  31 ++++-
 arch/arm64/boot/dts/freescale/imx93.dtsi           |   8 ++
 drivers/edac/fsl_ddr_edac.c                        | 134 ++++++++++++++-------
 drivers/edac/fsl_ddr_edac.h                        |  13 ++
 drivers/edac/layerscape_edac.c                     |   1 +
 5 files changed, 141 insertions(+), 46 deletions(-)
---
base-commit: 82d01fe6ee52086035b201cfa1410a3b04384257
change-id: 20240704-imx95_edac-209cec208446

Best regards,
---
Frank Li <Frank.Li@nxp.com>

Comments

Frank Li Sept. 30, 2024, 8:42 p.m. UTC | #1 
On Tue, Jul 09, 2024 at 04:23:01PM -0400, Frank Li wrote:
> Add imx9 support for fsl-ddr.
>
> Patch 1-2 is prepare patch, no function chagne
> Patch 3 is small fix for bit shift
> Patch 4 is dt binding patch.
> Patch 5 is driver change to support imx9
> Patch 6 is imx93 dts change
>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---

Borislav Petkov:

	More than 2 monthes. I ping at Thu, 29 Aug
https://lore.kernel.org/imx/ZtDwG2xFGaUssJVN@lizhi-Precision-Tower-5810/

	Any reason why not pick these EDAC patches?  Or do you have
additional comment to improve patches?

Frank


> Frank Li (4):
>       EDAC: fsl_ddr: Pass down fsl_mc_pdata in ddr_in32() and ddr_out32()
>       EDAC, fsl_ddr: Move global variable into struct fsl_mc_pdata
>       dt-bindings: memory: fsl: Add compatible string nxp,imx9-memory-controller
>       arm64: dts: imx93: add ddr edac support
>
> Priyanka Singh (1):
>       EDAC: fsl: Fix bad bit shift operations
>
> Ye Li (1):
>       EDAC: fsl_ddr: Add support for i.MX9 DDR controller
>
>  .../bindings/memory-controllers/fsl/fsl,ddr.yaml   |  31 ++++-
>  arch/arm64/boot/dts/freescale/imx93.dtsi           |   8 ++
>  drivers/edac/fsl_ddr_edac.c                        | 134 ++++++++++++++-------
>  drivers/edac/fsl_ddr_edac.h                        |  13 ++
>  drivers/edac/layerscape_edac.c                     |   1 +
>  5 files changed, 141 insertions(+), 46 deletions(-)
> ---
> base-commit: 82d01fe6ee52086035b201cfa1410a3b04384257
> change-id: 20240704-imx95_edac-209cec208446
>
> Best regards,
> ---
> Frank Li <Frank.Li@nxp.com>
>
Borislav Petkov Oct. 2, 2024, 9:08 a.m. UTC | #2 
On Mon, Sep 30, 2024 at 04:42:14PM -0400, Frank Li wrote:
> On Tue, Jul 09, 2024 at 04:23:01PM -0400, Frank Li wrote:
> > Add imx9 support for fsl-ddr.
> >
> > Patch 1-2 is prepare patch, no function chagne
> > Patch 3 is small fix for bit shift
> > Patch 4 is dt binding patch.
> > Patch 5 is driver change to support imx9
> > Patch 6 is imx93 dts change
> >
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> 
> Borislav Petkov:
> 
> 	More than 2 monthes. I ping at Thu, 29 Aug
> https://lore.kernel.org/imx/ZtDwG2xFGaUssJVN@lizhi-Precision-Tower-5810/
> 
> 	Any reason why not pick these EDAC patches?

$ ./scripts/get_maintainer.pl -f  drivers/edac/fsl_ddr_edac.c
York Sun <york.sun@nxp.com> (maintainer:EDAC-FSL_DDR)
Borislav Petkov <bp@alien8.de> (supporter:EDAC-CORE)
Tony Luck <tony.luck@intel.com> (supporter:EDAC-CORE)
James Morse <james.morse@arm.com> (reviewer:EDAC-CORE)
Mauro Carvalho Chehab <mchehab@kernel.org> (reviewer:EDAC-CORE)
Robert Richter <rric@kernel.org> (reviewer:EDAC-CORE)
linux-edac@vger.kernel.org (open list:EDAC-FSL_DDR)
linux-kernel@vger.kernel.org (open list)

This driver has a maintainer. Is he going to review it or can I remove
him from MAINTAINERS?
Krzysztof Kozlowski Oct. 2, 2024, 10:48 a.m. UTC | #3 
On 02/10/2024 11:08, Borislav Petkov wrote:
> On Mon, Sep 30, 2024 at 04:42:14PM -0400, Frank Li wrote:
>> On Tue, Jul 09, 2024 at 04:23:01PM -0400, Frank Li wrote:
>>> Add imx9 support for fsl-ddr.
>>>
>>> Patch 1-2 is prepare patch, no function chagne
>>> Patch 3 is small fix for bit shift
>>> Patch 4 is dt binding patch.
>>> Patch 5 is driver change to support imx9
>>> Patch 6 is imx93 dts change
>>>
>>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>>> ---
>>
>> Borislav Petkov:
>>
>> 	More than 2 monthes. I ping at Thu, 29 Aug
>> https://lore.kernel.org/imx/ZtDwG2xFGaUssJVN@lizhi-Precision-Tower-5810/
>>
>> 	Any reason why not pick these EDAC patches?
> 
> $ ./scripts/get_maintainer.pl -f  drivers/edac/fsl_ddr_edac.c
> York Sun <york.sun@nxp.com> (maintainer:EDAC-FSL_DDR)
> Borislav Petkov <bp@alien8.de> (supporter:EDAC-CORE)
> Tony Luck <tony.luck@intel.com> (supporter:EDAC-CORE)
> James Morse <james.morse@arm.com> (reviewer:EDAC-CORE)
> Mauro Carvalho Chehab <mchehab@kernel.org> (reviewer:EDAC-CORE)
> Robert Richter <rric@kernel.org> (reviewer:EDAC-CORE)
> linux-edac@vger.kernel.org (open list:EDAC-FSL_DDR)
> linux-kernel@vger.kernel.org (open list)
> 
> This driver has a maintainer. Is he going to review it or can I remove
> him from MAINTAINERS?

Let's drop York, it's a stale maintainer entry.

Best regards,
Krzysztof
Krzysztof Kozlowski Oct. 2, 2024, 10:52 a.m. UTC | #4 
On 02/10/2024 12:48, Krzysztof Kozlowski wrote:
> On 02/10/2024 11:08, Borislav Petkov wrote:
>> On Mon, Sep 30, 2024 at 04:42:14PM -0400, Frank Li wrote:
>>> On Tue, Jul 09, 2024 at 04:23:01PM -0400, Frank Li wrote:
>>>> Add imx9 support for fsl-ddr.
>>>>
>>>> Patch 1-2 is prepare patch, no function chagne
>>>> Patch 3 is small fix for bit shift
>>>> Patch 4 is dt binding patch.
>>>> Patch 5 is driver change to support imx9
>>>> Patch 6 is imx93 dts change
>>>>
>>>> Signed-off-by: Frank Li <Frank.Li@nxp.com>
>>>> ---
>>>
>>> Borislav Petkov:
>>>
>>> 	More than 2 monthes. I ping at Thu, 29 Aug
>>> https://lore.kernel.org/imx/ZtDwG2xFGaUssJVN@lizhi-Precision-Tower-5810/
>>>
>>> 	Any reason why not pick these EDAC patches?
>>
>> $ ./scripts/get_maintainer.pl -f  drivers/edac/fsl_ddr_edac.c
>> York Sun <york.sun@nxp.com> (maintainer:EDAC-FSL_DDR)
>> Borislav Petkov <bp@alien8.de> (supporter:EDAC-CORE)
>> Tony Luck <tony.luck@intel.com> (supporter:EDAC-CORE)
>> James Morse <james.morse@arm.com> (reviewer:EDAC-CORE)
>> Mauro Carvalho Chehab <mchehab@kernel.org> (reviewer:EDAC-CORE)
>> Robert Richter <rric@kernel.org> (reviewer:EDAC-CORE)
>> linux-edac@vger.kernel.org (open list:EDAC-FSL_DDR)
>> linux-kernel@vger.kernel.org (open list)
>>
>> This driver has a maintainer. Is he going to review it or can I remove
>> him from MAINTAINERS?
> 
> Let's drop York, it's a stale maintainer entry.

I sent a patch now for this.

Best regards,
Krzysztof
Frank Li Oct. 9, 2024, 3:48 p.m. UTC | #5 
On Wed, Oct 02, 2024 at 11:08:34AM +0200, Borislav Petkov wrote:
> On Mon, Sep 30, 2024 at 04:42:14PM -0400, Frank Li wrote:
> > On Tue, Jul 09, 2024 at 04:23:01PM -0400, Frank Li wrote:
> > > Add imx9 support for fsl-ddr.
> > >
> > > Patch 1-2 is prepare patch, no function chagne
> > > Patch 3 is small fix for bit shift
> > > Patch 4 is dt binding patch.
> > > Patch 5 is driver change to support imx9
> > > Patch 6 is imx93 dts change
> > >
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> >
> > Borislav Petkov:
> >
> > 	More than 2 monthes. I ping at Thu, 29 Aug
> > https://lore.kernel.org/imx/ZtDwG2xFGaUssJVN@lizhi-Precision-Tower-5810/
> >
> > 	Any reason why not pick these EDAC patches?
>
> $ ./scripts/get_maintainer.pl -f  drivers/edac/fsl_ddr_edac.c
> York Sun <york.sun@nxp.com> (maintainer:EDAC-FSL_DDR)
> Borislav Petkov <bp@alien8.de> (supporter:EDAC-CORE)
> Tony Luck <tony.luck@intel.com> (supporter:EDAC-CORE)
> James Morse <james.morse@arm.com> (reviewer:EDAC-CORE)
> Mauro Carvalho Chehab <mchehab@kernel.org> (reviewer:EDAC-CORE)
> Robert Richter <rric@kernel.org> (reviewer:EDAC-CORE)
> linux-edac@vger.kernel.org (open list:EDAC-FSL_DDR)
> linux-kernel@vger.kernel.org (open list)
>
> This driver has a maintainer. Is he going to review it or can I remove
> him from MAINTAINERS?

Borislav:

Krzy already sent patch remove him from MAINTANINERS.

Do you have any more concerns about this patch series?

Frank

>
> --
> Regards/Gruss,
>     Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette
Borislav Petkov Oct. 9, 2024, 4:20 p.m. UTC | #6 
Frank,

On Wed, Oct 09, 2024 at 11:48:00AM -0400, Frank Li wrote:
> Krzy already sent patch remove him from MAINTANINERS.
> 
> Do you have any more concerns about this patch series?

What are you actually asking?

Whether I should drop everything I'm doing and review your patches?

Do you need to read about the kernel development process and when new stuff
gets queued for the next merge window?

Let's cut to the chase and you explain to me what the reason is for you not
waiting patiently for your turn to come but keep pinging.

So, which is it?
Frank Li Oct. 9, 2024, 6:31 p.m. UTC | #7 
On Wed, Oct 09, 2024 at 06:20:38PM +0200, Borislav Petkov wrote:
> Frank,
>
> On Wed, Oct 09, 2024 at 11:48:00AM -0400, Frank Li wrote:
> > Krzy already sent patch remove him from MAINTANINERS.
> >
> > Do you have any more concerns about this patch series?
>
> What are you actually asking?

I ask if there are any other things to prevent this moving foreward.

>
> Whether I should drop everything I'm doing and review your patches?
>
> Do you need to read about the kernel development process and when new stuff
> gets queued for the next merge window?

I think I understood the process since
git log --oneline --author='Frank Li' v6.10..v6.11 | wc
87

It is first time to work with EDAC. The difference maintainer has differece
method to collect new stuff.

>
> Let's cut to the chase and you explain to me what the reason is for you not
> waiting patiently for your turn to come but keep pinging.
>
> So, which is it?

Generally, 7-10 days is reasonable frequent to ask. Contributor also takes
their time and efforts to make kernel better. Why they have to endure a
questioning or accusatory tone!

These patches was already takes more than 3 months. I ask just because
avoid to hold for the another 3 months just because some none technical
reason.

Frank
>
> --
> Regards/Gruss,
>     Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette
Borislav Petkov Oct. 9, 2024, 7:22 p.m. UTC | #8 
On Wed, Oct 09, 2024 at 02:31:10PM -0400, Frank Li wrote:
> Generally, 7-10 days is reasonable frequent to ask. Contributor also takes
> their time and efforts to make kernel better. Why they have to endure a
> questioning

You're asking me about your patches! I'm enduring questioning!

> or accusatory tone!

Where is that accusatory tone exactly? Please point me to it.

> These patches was already takes more than 3 months. I ask just because
> avoid to hold for the another 3 months just because some none technical
> reason.

I'm sorry that you have to hold for three months. I, like all maintainers, am
swamped with work for the next 10 years. You asking every 7-10 days does not
really help.

You're on the TODO list and I will get to your patches when I get to them.