mbox series

[treewide,00/11] ASoC: Clean up {hp,mic}-det-gpio handling

Message ID cover.1727438777.git.geert+renesas@glider.be (mailing list archive)
Headers show
Series ASoC: Clean up {hp,mic}-det-gpio handling | expand

Message

Geert Uytterhoeven Sept. 27, 2024, 12:42 p.m. UTC
Hi all,

The "gpio" suffix for GPIO consumers was deprecated a while ago, in
favor of the "gpios" suffix.  However, there are still several users of
the "hp-det-gpio" and "mic-det-gpio" properties, in DT bindings,
drivers, and DT source files.

Drivers that use gpiolib handle both the deprecated and new properties
transparently, but that is not the case when using of_property_*() calls
directly.

  - The first patch fixes a bug, as the Freescale Generic ASoC Sound
    driver handles only the deprecated properties, while there is
    already a user of the new variants,
  - The second patch updates the Audio Graph and Simple Audio Card DT
    bindings,
  - Patches 3-9 converts various DTS files to use the new properties,
  - The last 2 patches convert Freescale sound device nodes to use the
    new properties.

All patches can be applied independently, except for the last two, which
depend on the first patch to avoid regressions.
This series was compile-tested only.

Thanks for your comments!

Geert Uytterhoeven (11):
  ASoC: fsl-asoc-card: Add missing handling of {hp,mic}-dt-gpios
  ASoC: dt-bindings: Deprecate {hp,mic}-det-gpio
  ARM: dts: marvell: mmp2-olpc-xo-1-75: Switch to {hp,mic}-det-gpios
  arm64: dts: freescale: imx: Switch to simple-audio-card,hp-det-gpios
  arm64: dts: renesas: beacon-renesom: Switch to mic-det-gpios
  arm64: dts: rockchip: Switch to simple-audio-card,hp-det-gpios
  arm64: dts: rockchip: Switch to hp-det-gpios
  arm64: dts: uniphier: Switch to hp-det-gpios
  mips: dts: ingenic: Switch to simple-audio-card,hp-det-gpios
  ARM: dts: nxp: imx: Switch to {hp,mic}-det-gpios
  arm64: dts: freescale: imx: Switch to hp-det-gpios

 .../devicetree/bindings/sound/audio-graph.yaml       |  6 ++++++
 .../devicetree/bindings/sound/simple-card.yaml       | 12 ++++++++++++
 arch/arm/boot/dts/marvell/mmp2-olpc-xo-1-75.dts      |  4 ++--
 arch/arm/boot/dts/nxp/imx/imx6qdl-sabresd.dtsi       |  4 ++--
 arch/arm/boot/dts/nxp/imx/imx6sl-evk.dts             |  2 +-
 arch/arm/boot/dts/nxp/imx/imx6sll-evk.dts            |  2 +-
 arch/arm/boot/dts/nxp/imx/imx6sx-sdb.dtsi            |  2 +-
 arch/arm/boot/dts/nxp/imx/imx6ul-14x14-evk.dtsi      |  2 +-
 arch/arm/boot/dts/nxp/imx/imx7d-sdb.dts              |  2 +-
 .../boot/dts/freescale/imx8mq-librem5-devkit.dts     |  2 +-
 arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi    |  2 +-
 arch/arm64/boot/dts/freescale/imx8qm-mek.dts         |  2 +-
 arch/arm64/boot/dts/freescale/imx8qxp-mek.dts        |  2 +-
 arch/arm64/boot/dts/freescale/imx95-19x19-evk.dts    |  2 +-
 .../boot/dts/renesas/beacon-renesom-baseboard.dtsi   |  2 +-
 .../boot/dts/rockchip/rk3326-anbernic-rg351m.dtsi    |  2 +-
 .../arm64/boot/dts/rockchip/rk3326-gameforce-chi.dts |  2 +-
 arch/arm64/boot/dts/rockchip/rk3326-odroid-go.dtsi   |  2 +-
 arch/arm64/boot/dts/rockchip/rk3368-lba3368.dts      |  2 +-
 arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts    |  2 +-
 arch/arm64/boot/dts/rockchip/rk3399-pinebook-pro.dts |  2 +-
 arch/arm64/boot/dts/rockchip/rk3399-roc-pc-plus.dts  |  2 +-
 .../boot/dts/rockchip/rk3399-rock-pi-4a-plus.dts     |  2 +-
 .../boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts     |  2 +-
 arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4c.dts   |  2 +-
 .../boot/dts/rockchip/rk3399-sapphire-excavator.dts  |  2 +-
 .../boot/dts/rockchip/rk3566-anbernic-rg-arc.dtsi    |  2 +-
 .../boot/dts/rockchip/rk3566-anbernic-rg353p.dts     |  2 +-
 .../boot/dts/rockchip/rk3566-anbernic-rg353ps.dts    |  2 +-
 .../boot/dts/rockchip/rk3566-anbernic-rg353v.dts     |  2 +-
 .../boot/dts/rockchip/rk3566-anbernic-rg353vs.dts    |  2 +-
 .../boot/dts/rockchip/rk3566-anbernic-rg503.dts      |  2 +-
 arch/arm64/boot/dts/rockchip/rk3566-pinetab2.dtsi    |  2 +-
 arch/arm64/boot/dts/rockchip/rk3566-powkiddy-x55.dts |  2 +-
 arch/arm64/boot/dts/rockchip/rk3568-odroid-m1.dts    |  2 +-
 arch/arm64/boot/dts/rockchip/rk3588-armsom-sige7.dts |  2 +-
 arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dts     |  2 +-
 .../dts/rockchip/rk3588-friendlyelec-cm3588-nas.dts  |  2 +-
 arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dtsi   |  2 +-
 arch/arm64/boot/dts/rockchip/rk3588-ok3588-c.dts     |  2 +-
 .../boot/dts/rockchip/rk3588-orangepi-5-plus.dts     |  2 +-
 arch/arm64/boot/dts/rockchip/rk3588-quartzpro64.dts  |  2 +-
 arch/arm64/boot/dts/rockchip/rk3588-rock-5-itx.dts   |  2 +-
 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts      |  2 +-
 .../boot/dts/rockchip/rk3588s-gameforce-ace.dts      |  2 +-
 .../boot/dts/socionext/uniphier-ld11-global.dts      |  2 +-
 .../boot/dts/socionext/uniphier-ld20-global.dts      |  2 +-
 arch/mips/boot/dts/ingenic/gcw0.dts                  |  2 +-
 arch/mips/boot/dts/ingenic/rs90.dts                  |  2 +-
 sound/soc/fsl/fsl-asoc-card.c                        |  8 +++++---
 50 files changed, 72 insertions(+), 52 deletions(-)

Comments

Heiko Stübner Sept. 27, 2024, 2:44 p.m. UTC | #1
Hi Geert,

Am Freitag, 27. September 2024, 14:42:15 CEST schrieb Geert Uytterhoeven:
>   - The second patch updates the Audio Graph and Simple Audio Card DT
>     bindings,
>   - Patches 3-9 converts various DTS files to use the new properties,
>   - The last 2 patches convert Freescale sound device nodes to use the
>     new properties.
> 
> All patches can be applied independently,

though I guess dts patches should wait till patch 2 gets applied
somewhere, so that changed dts and changed binding can again find
together in linux-next?


Heiko
Geert Uytterhoeven Sept. 27, 2024, 5:09 p.m. UTC | #2
Hi Heiko,

On Fri, Sep 27, 2024 at 4:45 PM Heiko Stuebner <heiko@sntech.de> wrote:
> Am Freitag, 27. September 2024, 14:42:15 CEST schrieb Geert Uytterhoeven:
> >   - The second patch updates the Audio Graph and Simple Audio Card DT
> >     bindings,
> >   - Patches 3-9 converts various DTS files to use the new properties,
> >   - The last 2 patches convert Freescale sound device nodes to use the
> >     new properties.
> >
> > All patches can be applied independently,
>
> though I guess dts patches should wait till patch 2 gets applied
> somewhere, so that changed dts and changed binding can again find
> together in linux-next?

Yes, if we want to avoid introducing new dtbs_check warnings in linux-next.

Gr{oetje,eeting}s,

                        Geert
Mark Brown Oct. 5, 2024, 9:50 a.m. UTC | #3
On Fri, 27 Sep 2024 14:42:15 +0200, Geert Uytterhoeven wrote:
> 	Hi all,
> 
> The "gpio" suffix for GPIO consumers was deprecated a while ago, in
> favor of the "gpios" suffix.  However, there are still several users of
> the "hp-det-gpio" and "mic-det-gpio" properties, in DT bindings,
> drivers, and DT source files.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[01/11] ASoC: fsl-asoc-card: Add missing handling of {hp,mic}-dt-gpios
        commit: cfd1054c65eefec30972416a83eb62920bc1ff8d
[02/11] ASoC: dt-bindings: Deprecate {hp,mic}-det-gpio
        commit: e58b3914ab8303a2783ec1873c17b7a83dd515f7

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Heiko Stübner Oct. 7, 2024, 8:05 a.m. UTC | #4
On Fri, 27 Sep 2024 14:42:15 +0200, Geert Uytterhoeven wrote:
> 	Hi all,
> 
> The "gpio" suffix for GPIO consumers was deprecated a while ago, in
> favor of the "gpios" suffix.  However, there are still several users of
> the "hp-det-gpio" and "mic-det-gpio" properties, in DT bindings,
> drivers, and DT source files.
> 
> [...]

Applied, thanks!

[06/11] arm64: dts: rockchip: Switch to simple-audio-card,hp-det-gpios
        commit: 7ac5c0a592f73fdc52393f6469ce8211ff3e771f
[07/11] arm64: dts: rockchip: Switch to hp-det-gpios
        commit: 3ca743f8a5b568dc5e5d5f1bab0298a4a43c2360

after the binding change from patch 02 got merged into the sound tree

Best regards,