| Message ID | 20240407051913.1989364-2-joy.zou@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add rtc PCF2131 support | expand |
On 07/04/2024 07:19, Joy Zou wrote: > Support rtc PCF2131 on imx93-11x11-evk. > > Signed-off-by: Joy Zou <joy.zou@nxp.com> > --- > .../boot/dts/freescale/imx93-11x11-evk.dts | 25 +++++++++++++++++++ > 1 file changed, 25 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > index 07e85a30a25f..065fa3390791 100644 > --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts > @@ -281,6 +281,24 @@ ldo5: LDO5 { > }; > }; > > +&lpi2c3 { > + #address-cells = <1>; > + #size-cells = <0>; > + clock-frequency = <400000>; > + pinctrl-names = "default", "sleep"; > + pinctrl-0 = <&pinctrl_lpi2c3>; > + pinctrl-1 = <&pinctrl_lpi2c3>; > + status = "okay"; > + > + pcf2131: rtc@53 { > + compatible = "nxp,pcf2131"; > + reg = <0x53>; > + interrupt-parent = <&pcal6524>; > + interrupts = <1 IRQ_TYPE_EDGE_FALLING>; > + status = "okay"; Really, just drop... Best regards, Krzysztof
> -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: 2024年4月7日 17:04 > To: Joy Zou <joy.zou@nxp.com>; Jacky Bai <ping.bai@nxp.com>; > robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; > conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de > Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx > <linux-imx@nxp.com>; devicetree@vger.kernel.org; imx@lists.linux.dev; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: [EXT] Re: [PATCH v1 1/1] arm64: dts: imx93-11x11-evk: add rtc > PCF2131 support > > +&lpi2c3 { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + clock-frequency = <400000>; > > + pinctrl-names = "default", "sleep"; > > + pinctrl-0 = <&pinctrl_lpi2c3>; > > + pinctrl-1 = <&pinctrl_lpi2c3>; > > + status = "okay"; > > + > > + pcf2131: rtc@53 { > > + compatible = "nxp,pcf2131"; > > + reg = <0x53>; > > + interrupt-parent = <&pcal6524>; > > + interrupts = <1 IRQ_TYPE_EDGE_FALLING>; > > + status = "okay"; > > Really, just drop... Ok, will drop the status in next version. Thanks for your comment! BR Joy Zou > > > Best regards, > Krzysztof
On 07/04/2024 11:09, Joy Zou wrote: > >> -----Original Message----- >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Sent: 2024年4月7日 17:04 >> To: Joy Zou <joy.zou@nxp.com>; Jacky Bai <ping.bai@nxp.com>; >> robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; >> conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de >> Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx >> <linux-imx@nxp.com>; devicetree@vger.kernel.org; imx@lists.linux.dev; >> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org >> Subject: [EXT] Re: [PATCH v1 1/1] arm64: dts: imx93-11x11-evk: add rtc >> PCF2131 support >>> +&lpi2c3 { >>> + #address-cells = <1>; >>> + #size-cells = <0>; >>> + clock-frequency = <400000>; >>> + pinctrl-names = "default", "sleep"; >>> + pinctrl-0 = <&pinctrl_lpi2c3>; >>> + pinctrl-1 = <&pinctrl_lpi2c3>; >>> + status = "okay"; >>> + >>> + pcf2131: rtc@53 { >>> + compatible = "nxp,pcf2131"; >>> + reg = <0x53>; >>> + interrupt-parent = <&pcal6524>; >>> + interrupts = <1 IRQ_TYPE_EDGE_FALLING>; >>> + status = "okay"; >> >> Really, just drop... > Ok, will drop the status in next version. > Thanks for your comment! Please read DTS coding style. Best regards, Krzysztof
BR Joy Zou > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: 2024年4月7日 17:12 > To: Joy Zou <joy.zou@nxp.com>; Jacky Bai <ping.bai@nxp.com>; > robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; > conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de > Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx > <linux-imx@nxp.com>; devicetree@vger.kernel.org; imx@lists.linux.dev; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: Re: [EXT] Re: [PATCH v1 1/1] arm64: dts: imx93-11x11-evk: add rtc > PCF2131 support > > Caution: This is an external email. Please take care when clicking links or > opening attachments. When in doubt, report the message using the 'Report > this email' button > > > On 07/04/2024 11:09, Joy Zou wrote: > > > >> -----Original Message----- > >> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >> Sent: 2024年4月7日 17:04 > >> To: Joy Zou <joy.zou@nxp.com>; Jacky Bai <ping.bai@nxp.com>; > >> robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org; > >> conor+dt@kernel.org; shawnguo@kernel.org; s.hauer@pengutronix.de > >> Cc: kernel@pengutronix.de; festevam@gmail.com; dl-linux-imx > >> <linux-imx@nxp.com>; devicetree@vger.kernel.org; imx@lists.linux.dev; > >> linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org > >> Subject: [EXT] Re: [PATCH v1 1/1] arm64: dts: imx93-11x11-evk: add > >> rtc > >> PCF2131 support > >>> +&lpi2c3 { > >>> + #address-cells = <1>; > >>> + #size-cells = <0>; > >>> + clock-frequency = <400000>; > >>> + pinctrl-names = "default", "sleep"; > >>> + pinctrl-0 = <&pinctrl_lpi2c3>; > >>> + pinctrl-1 = <&pinctrl_lpi2c3>; > >>> + status = "okay"; > >>> + > >>> + pcf2131: rtc@53 { > >>> + compatible = "nxp,pcf2131"; > >>> + reg = <0x53>; > >>> + interrupt-parent = <&pcal6524>; > >>> + interrupts = <1 IRQ_TYPE_EDGE_FALLING>; > >>> + status = "okay"; > >> > >> Really, just drop... > > Ok, will drop the status in next version. > > Thanks for your comment! > > Please read DTS coding style. Thanks you very much! Yeah, I have read the DTS coding style. The “status” property is by default “okay”, thus it can be omitted. BR Joy Zou > > Best regards, > Krzysztof
diff --git a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts index 07e85a30a25f..065fa3390791 100644 --- a/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx93-11x11-evk.dts @@ -281,6 +281,24 @@ ldo5: LDO5 { }; }; +&lpi2c3 { + #address-cells = <1>; + #size-cells = <0>; + clock-frequency = <400000>; + pinctrl-names = "default", "sleep"; + pinctrl-0 = <&pinctrl_lpi2c3>; + pinctrl-1 = <&pinctrl_lpi2c3>; + status = "okay"; + + pcf2131: rtc@53 { + compatible = "nxp,pcf2131"; + reg = <0x53>; + interrupt-parent = <&pcal6524>; + interrupts = <1 IRQ_TYPE_EDGE_FALLING>; + status = "okay"; + }; +}; + &iomuxc { pinctrl_eqos: eqosgrp { fsl,pins = < @@ -343,6 +361,13 @@ MX93_PAD_I2C2_SDA__LPI2C2_SDA 0x40000b9e >; }; + pinctrl_lpi2c3: lpi2c3grp { + fsl,pins = < + MX93_PAD_GPIO_IO28__LPI2C3_SDA 0x40000b9e + MX93_PAD_GPIO_IO29__LPI2C3_SCL 0x40000b9e + >; + }; + pinctrl_pcal6524: pcal6524grp { fsl,pins = < MX93_PAD_CCM_CLKO2__GPIO3_IO27 0x31e
Support rtc PCF2131 on imx93-11x11-evk. Signed-off-by: Joy Zou <joy.zou@nxp.com> --- .../boot/dts/freescale/imx93-11x11-evk.dts | 25 +++++++++++++++++++ 1 file changed, 25 insertions(+)