From patchwork Mon Apr 15 19:33:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13630588 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2086.outbound.protection.outlook.com [40.107.21.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 92058156995 for ; Mon, 15 Apr 2024 19:34:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.86 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713209648; cv=fail; b=IP5/qgiZwuwEKSIPwQW/oqLDidCgOBVlEXEFitkcQ66yg5qoZw+r3r+5x+qefjPgCVpE7bHg7xqf96mCN6ykbuJ1MIBtfsMSkceGVkoCPMTu+6KVSL7EWiLQjXTp4s97E7oqghk1LZoojNkYG3ekyf0S2YX0lG/5BadyL527U0g= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1713209648; c=relaxed/simple; bh=iaMVhIlaxnDKrjo/B86UwmBA4lUHgRwjSU/hHDluay0=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=H0HTEE3YzZAIdD09bHwlVPIhgC4t2rP6bdVyXg7WZiLD9Np8GAdsK6w4afpMhq0PYKAChuh4kaby46oRx8hfzg5HSzh+7pnRMgsf3sjk7Udt2NQrn2loP3OWvpyEHyOdC+8L6YO4Gl9DRsCsTm4TKax8Vuv1bR9VZJoMekE6Q5I= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=jjGjGV/x; arc=fail smtp.client-ip=40.107.21.86 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="jjGjGV/x" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rp+LmnqwXpe3Kz10UfEsEGY3M/BP/0LEsUiuFgoSieZylKJ3Jx28taxUGzrAEPs9lyGmOL9PJm3X/KV/qjYDDW+z9il52OA8pBwR0Ip+B4EK9rzb+pekKevWHeoH1sY99W8MFH8dLXBdjtkOnaPaRBsPrmtGTpYHlDpFlCCSmUWeGhRtOvyPNmWLZdsv0ZCO8DxSZHKbUeaacYEWbiiTOnWWj5jrSYwtfBXSI90xabmwhp6vXugRwG/oYahG9EvKwGSMxjuCrgmsuKvW5jAvgOf0fUGJzlmjzivpo3r1nAJxk2cLwVjSeAW2UChxSzPkorqP1j/f9ApVsxcWR1UNiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=wqraZNkbMXJ8bdVBUWBtPeGCWP+ilAu0pVj9SSD+e7E=; b=KJW7dUmyfkCMH/NJXm1AIg9tNuu7ufeDntpuFh8dTHyVj6sN929SrLSSYKj6dCDOBFCXJ3UQATlApXsWxH1BMu3l1QM4R6wEHbyphMMds8DWM9dU+xeCoZivfkWTvJwYrmJjD6z/uP3OYDOYIoMeuT3NIdNnJ9TyA4IVkE0/cyfxhBouRhORW/SOc0q9lWo6CJJUoKcgkS9SviUiZp1kkRJAjJ+IFUQ9sI5lR4svIVvTTin1nfefD6SKvKdzT/XDWwzekabuYJQ3SWMxLZShFn+M9u9s7J7bLo2mNJDEIlpQdrwB+u4QkSms/DMdJut5wmJ3HM9o9qUd828xMBOBtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wqraZNkbMXJ8bdVBUWBtPeGCWP+ilAu0pVj9SSD+e7E=; b=jjGjGV/xVpxUKNrGc3Tw0WQtiqFOk8h/ErwRq7LFCaaCyB7mneDGCHmbw6yjNFJsPB70HIWDd86U9y9l1nCd+NsWcIQRTYDPkaa2+sGtE91zW5llpldefyt4BLAJaio0GlAZgDR+7CC8DAPDkLZwJImG6pfwPVMBec4j37e/oCc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PA2PR04MB10279.eurprd04.prod.outlook.com (2603:10a6:102:406::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.43; Mon, 15 Apr 2024 19:34:04 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::1e67:dfc9:d0c1:fe58]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::1e67:dfc9:d0c1:fe58%7]) with mapi id 15.20.7452.049; Mon, 15 Apr 2024 19:34:04 +0000 From: Frank Li Date: Mon, 15 Apr 2024 15:33:27 -0400 Subject: [PATCH v6 3/5] PCI: dwc: Add outbound MSG TLPs support Message-Id: <20240415-pme_msg-v6-3-56dad968ad3a@nxp.com> References: <20240415-pme_msg-v6-0-56dad968ad3a@nxp.com> In-Reply-To: <20240415-pme_msg-v6-0-56dad968ad3a@nxp.com> To: Bjorn Helgaas , Jingoo Han , Gustavo Pimentel , Manivannan Sadhasivam , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , imx@lists.linux.dev Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Frank Li , Yoshihiro Shimoda , Serge Semin X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1713209628; l=2940; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=Vx141tscxeq3VO/J2v1vu73YFB2QjcNfIuChtPapKMY=; b=I8T0zdscJFazCZ8U2IXx9zOstAk0Ehh4oNJIapRsZHp0rULNlNxD75K17v7J1vDuZn4wYikWF rzJyAXXLK6aCROrzlBCUyKdybzk3aDzHJMqrsCwF9EYJALFboOajbvW X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR13CA0102.namprd13.prod.outlook.com (2603:10b6:a03:2c5::17) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PA2PR04MB10279:EE_ X-MS-Office365-Filtering-Correlation-Id: 4c0f9ae1-caf8-4f4d-aeef-08dc5d830272 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: eCYi5xD0QsdLlqpAA20H7n/WkgCdd1C3Dwk+WPWerwTIcGZSwIqGzEAP26egJul7jBsb2idk30SBQI1W4zgkPx+lBnPdyhu6PddNhFP9ViObFBToR76lqLz2pXh8Ted7VGivOA048KDjzuvH9+4/TVBPjUX7VY0Y8+hulFV2/4lu7BMekkpKqdiRIHFdfqhpwANi27tg+Lt2EHuUrDRkBbUmbGK+nkPG/CBgqgOTUvSfar603Xj0n1hElBXa1a6VLmcAD9FmjXiptxSOu9LABQtq1qXwlr5gHgHXxWp1CF9fe84y/OpfxD42EF6uUNdRH1gRd308ELZlstHn0Ca9uofG1+DX1+aD/W9qC6j1PTZ9Lu7KB3AT1+jzqRH/zH3gWLD882mJTCI9s6Vk80pmtvRsucShLmcKppPBM/zoZp7/VS86C1oQ0OoKKbQ0JhcnH/L1WM5Nh2SZIQ9vAcyZ21FwpkGYB6OEYQikLc3axaTOnvITUSGwOviIgo24F/y7N5BjGhXlfs0NoAEfiIqY0luJ+K8lDEGX9kYnDhVwxhucCsEVemwkpQckaSVxq+BefF1/CSMC+x1KfG6n6UfJ/S00hD2Vwn7fMLJTURVk2PQKXZpf0y9X48teT54TFGMcHDwRaHEix3LqF3ziF0MHjxdU8xDONrGB2vd9GfP9T7uk5ZbNbL7mq3xESHA5fYDJOdTEywSorLjfFx+fYpqeFxOCGd4DEAh3w8BW4Yg3KR4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(1800799015)(366007)(376005)(7416005)(52116005)(38350700005)(921011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?ZkFcbVY6aKSSaQoPRGW3W0x1ykRn?= =?utf-8?q?Z4Y3n3Opm35xS94ouPGjeSKnBLk+o6J4oesCC/s2mRwyEphuDMUR2I6434Y0SeZ8J?= =?utf-8?q?LhpWvj7gZAAoct/rU/I+j55fMR5rUJVicLmZ9zEfZI0qUutkzau8VHLJRok1VnPNn?= =?utf-8?q?WIO691eowaA+Hb4AzkFRDm+RyksIUXoKSYtTTUnRUzullWpljBWe3jeN/WZOBeP+P?= =?utf-8?q?fYAQSfn4SEH1wUMJ4aTfwun21hbq9SdOmQpeulVThsllPM4+3i/zoI9668t4bB5L8?= =?utf-8?q?N10r8LpZaQcoRvUugK5yg0Cvg3wUWNT6UgnmnagHqjhSVHDsOhxCRt6byLm4WuJdx?= =?utf-8?q?teYZMRx6NIysGCWoEamajUIfYbTxKVp4wY41nSteOyU9dA1FhoPjIsTwtpVr3Sh/p?= =?utf-8?q?sokJDnOyCoOAxMAQGk2E3KtIwmw6EhRN8kXgPleITgLtedQDYItkj6Qds68nrPYpj?= =?utf-8?q?DTPRrNJR9405zROr0YLTs2699UvP4gHtSJE6W23uQTMi7VKAB00oFz4Uz/pieILWP?= =?utf-8?q?MJpQ66ZW0BwAkVlF9bYVcNh6nJ4kKNbEvrOdbIov4uHP71nRHcArmG045NyJOfST9?= =?utf-8?q?8GFsVCmlOGnRU3xNJusgTOQkg0UBFN+uI/qMJsX3kfNUCGhyoomBDHDTwTZAvhjG7?= =?utf-8?q?lyQ3mbh9L7J2ouhYf//a4f+AmarBT/ytd6mO/Hfyb0N0hZnBlFPgr5VJGNXzc1FCY?= =?utf-8?q?8cspPUCSJzL6x5ZijSHX5wY08O7suBay7eO7HwjAzhXY1KtpzVJ6nwwwUK0c/wKVi?= =?utf-8?q?kcu7x6c8hcG3JdWfvMXCKp/Uhun1ObIA3k+hvKaS/SpX/gf9IgK/kjyUfcnQ7Gvum?= =?utf-8?q?bq8TtGqhNiPIWe/gKp7X5STLxx3Swg0J+2aJEun0rpKnmZmNVo9f+rARuP67pc1sq?= =?utf-8?q?KcnZ42DMkIQnXaeyFxX5yIYIz4HeAqnU9NEHvgjCMdA7vkqxKKC6rG18uzG2pb02P?= =?utf-8?q?7Dzo6oph6v1ycwq1Rz5s49rqMDGQrh+uV8iNfFIyZq+2ji5ENIUcKt+Pe6FEziTZg?= =?utf-8?q?Md2A2+xdDI/kmxO3yHgmD4OijfqicSKJLweYCgIcAeEU0mYlF9x5XqZLE0/7prw0t?= =?utf-8?q?vDrO0K5uJtxPetDQpIQnh3Ob7yX+kqjzHPl+iXSq9OH/XI4PLtGKKAd3affT6ZeN4?= =?utf-8?q?iVt+L1jbLDytv7K/42Pu27rPQFnCK4em853aXmhLUZtjToUXxTchDV3i+hWCl7eZd?= =?utf-8?q?Op+ZqqwREOqNEjR9Jlwyl4k7R12GS9p8Pz5P1xx2+HB6hFGFcwbSegTwNro6089BA?= =?utf-8?q?0sO+feN3DQedcIXZ4aJz3xTB3CPjtEfzIj5zD0iH53z6IhKG7Lw0XqQYr3Wm7mwDn?= =?utf-8?q?u92Hn1iW8noVzuS6/OJYulKaQ4EcPReCsHLQqfqgePWis7JnTjlakiq3d4zEZsAQ6?= =?utf-8?q?t440Y7ndz5Y2VyfEwqejISFzzNc0UVRFKEuaDZZqca2AP9WXQaG3IApTECJXfgynd?= =?utf-8?q?bzOfPguiUItijluXIlk4+Zsx5PIYteWxumRyr4bNGamSquCngFxoKPFQ=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c0f9ae1-caf8-4f4d-aeef-08dc5d830272 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Apr 2024 19:34:04.3890 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 8Iax4aiSNHthBHPCXNxmUu58H+MPk+VdcFa5uAPm07shOhUIcqA8CwYK4nurz5Arr0Fyn7IMF+lkYi7zUBIKMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA2PR04MB10279 From: Yoshihiro Shimoda Add "code" and "routing" into struct dw_pcie_ob_atu_cfg for triggering INTx IRQs by iATU in the PCIe endpoint mode in near the future. PCIE_ATU_INHIBIT_PAYLOAD is set to issue TLP type of Msg instead of MsgD. So, this implementation supports the data-less messages only for now. Signed-off-by: Yoshihiro Shimoda Reviewed-by: Serge Semin Reviewed-by: Manivannan Sadhasivam Signed-off-by: Frank Li --- drivers/pci/controller/dwc/pcie-designware.c | 9 +++++++-- drivers/pci/controller/dwc/pcie-designware.h | 4 ++++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c index df2575ec5f44c..ba909fade9db1 100644 --- a/drivers/pci/controller/dwc/pcie-designware.c +++ b/drivers/pci/controller/dwc/pcie-designware.c @@ -499,7 +499,7 @@ int dw_pcie_prog_outbound_atu(struct dw_pcie *pci, dw_pcie_writel_atu_ob(pci, atu->index, PCIE_ATU_UPPER_TARGET, upper_32_bits(atu->pci_addr)); - val = atu->type | PCIE_ATU_FUNC_NUM(atu->func_no); + val = atu->type | atu->routing | PCIE_ATU_FUNC_NUM(atu->func_no); if (upper_32_bits(limit_addr) > upper_32_bits(cpu_addr) && dw_pcie_ver_is_ge(pci, 460A)) val |= PCIE_ATU_INCREASE_REGION_SIZE; @@ -507,7 +507,12 @@ int dw_pcie_prog_outbound_atu(struct dw_pcie *pci, val = dw_pcie_enable_ecrc(val); dw_pcie_writel_atu_ob(pci, atu->index, PCIE_ATU_REGION_CTRL1, val); - dw_pcie_writel_atu_ob(pci, atu->index, PCIE_ATU_REGION_CTRL2, PCIE_ATU_ENABLE); + val = PCIE_ATU_ENABLE; + if (atu->type == PCIE_ATU_TYPE_MSG) { + /* The data-less messages only for now */ + val |= PCIE_ATU_INHIBIT_PAYLOAD | atu->code; + } + dw_pcie_writel_atu_ob(pci, atu->index, PCIE_ATU_REGION_CTRL2, val); /* * Make sure ATU enable takes effect before any subsequent config diff --git a/drivers/pci/controller/dwc/pcie-designware.h b/drivers/pci/controller/dwc/pcie-designware.h index d21db82e586d5..703b50bc5e0f1 100644 --- a/drivers/pci/controller/dwc/pcie-designware.h +++ b/drivers/pci/controller/dwc/pcie-designware.h @@ -148,11 +148,13 @@ #define PCIE_ATU_TYPE_IO 0x2 #define PCIE_ATU_TYPE_CFG0 0x4 #define PCIE_ATU_TYPE_CFG1 0x5 +#define PCIE_ATU_TYPE_MSG 0x10 #define PCIE_ATU_TD BIT(8) #define PCIE_ATU_FUNC_NUM(pf) ((pf) << 20) #define PCIE_ATU_REGION_CTRL2 0x004 #define PCIE_ATU_ENABLE BIT(31) #define PCIE_ATU_BAR_MODE_ENABLE BIT(30) +#define PCIE_ATU_INHIBIT_PAYLOAD BIT(22) #define PCIE_ATU_FUNC_NUM_MATCH_EN BIT(19) #define PCIE_ATU_LOWER_BASE 0x008 #define PCIE_ATU_UPPER_BASE 0x00C @@ -303,6 +305,8 @@ struct dw_pcie_ob_atu_cfg { int index; int type; u8 func_no; + u8 code; + u8 routing; u64 cpu_addr; u64 pci_addr; u64 size;