diff mbox series

[v2,1/3] dt-bindings: arm: fsl: add Engicam i.Core MX93 EDIMM 2.0 Starter Kit

Message ID 20240418133923.3705-2-fabio.aiuto@engicam.com (mailing list archive)
State Superseded
Headers show
Series arm64: dts: imx93: add i.Core MX93 EDIMM 2.0 board | expand

Commit Message

Fabio Aiuto April 18, 2024, 1:39 p.m. UTC
i.Core MX93 is a NXP i.MX93 based EDIMM SoM by Engicam.

EDIMM 2.0 Starter Kit is an EDIMM 2.0 Form Factor Capacitive
Evaluation Board by Engicam.

i.Core MX93 needs to be mounted on top of EDIMM 2.0 Starter Kit
to get the full i.Core MX93 EDIMM 2.0 Starter Kit board.

Add bindings for this board.

Cc: Matteo Lisi <matteo.lisi@engicam.com>
Cc: Mirko Ardinghi <mirko.ardinghi@engicam.com>
Signed-off-by: Fabio Aiuto <fabio.aiuto@engicam.com>
---
 Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Conor Dooley April 18, 2024, 3:33 p.m. UTC | #1
On Thu, Apr 18, 2024 at 03:39:21PM +0200, Fabio Aiuto wrote:
> i.Core MX93 is a NXP i.MX93 based EDIMM SoM by Engicam.
> 
> EDIMM 2.0 Starter Kit is an EDIMM 2.0 Form Factor Capacitive
> Evaluation Board by Engicam.
> 
> i.Core MX93 needs to be mounted on top of EDIMM 2.0 Starter Kit
> to get the full i.Core MX93 EDIMM 2.0 Starter Kit board.
> 
> Add bindings for this board.
> 
> Cc: Matteo Lisi <matteo.lisi@engicam.com>
> Cc: Mirko Ardinghi <mirko.ardinghi@engicam.com>
> Signed-off-by: Fabio Aiuto <fabio.aiuto@engicam.com>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Thanks,
Conor.

> ---
>  Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
> index 0027201e19f8..b497a01c7418 100644
> --- a/Documentation/devicetree/bindings/arm/fsl.yaml
> +++ b/Documentation/devicetree/bindings/arm/fsl.yaml
> @@ -1265,6 +1265,13 @@ properties:
>                - fsl,imx93-11x11-evk       # i.MX93 11x11 EVK Board
>            - const: fsl,imx93
>  
> +      - description: Engicam i.Core MX93 based Boards
> +        items:
> +          - enum:
> +              - engicam,icore-mx93-edimm2         # i.MX93 Engicam i.Core MX93 EDIMM 2.0 Starter Kit
> +          - const: engicam,icore-mx93             # i.MX93 Engicam i.Core MX93 Som
> +          - const: fsl,imx93
> +
>        - description: i.MXRT1050 based Boards
>          items:
>            - enum:
> -- 
> 2.34.1
>
Conor Dooley April 18, 2024, 4:34 p.m. UTC | #2
On Thu, Apr 18, 2024 at 04:33:21PM +0100, Conor Dooley wrote:
> On Thu, Apr 18, 2024 at 03:39:21PM +0200, Fabio Aiuto wrote:
> > i.Core MX93 is a NXP i.MX93 based EDIMM SoM by Engicam.
> > 
> > EDIMM 2.0 Starter Kit is an EDIMM 2.0 Form Factor Capacitive
> > Evaluation Board by Engicam.
> > 
> > i.Core MX93 needs to be mounted on top of EDIMM 2.0 Starter Kit
> > to get the full i.Core MX93 EDIMM 2.0 Starter Kit board.
> > 
> > Add bindings for this board.
> > 
> > Cc: Matteo Lisi <matteo.lisi@engicam.com>
> > Cc: Mirko Ardinghi <mirko.ardinghi@engicam.com>
> > Signed-off-by: Fabio Aiuto <fabio.aiuto@engicam.com>
> 
> Acked-by: Conor Dooley <conor.dooley@microchip.com>

Looks like you might've already got an Ack from Krzysztof on a previous
version. Please make sure to pick up acks etc when you post new
versions.

Thanks,
Conor.
Fabio Aiuto April 19, 2024, 7:20 a.m. UTC | #3
Dear Conor,

Il Thu, Apr 18, 2024 at 05:34:07PM +0100, Conor Dooley ha scritto:
> On Thu, Apr 18, 2024 at 04:33:21PM +0100, Conor Dooley wrote:
> > On Thu, Apr 18, 2024 at 03:39:21PM +0200, Fabio Aiuto wrote:
> > > i.Core MX93 is a NXP i.MX93 based EDIMM SoM by Engicam.
> > > 
> > > EDIMM 2.0 Starter Kit is an EDIMM 2.0 Form Factor Capacitive
> > > Evaluation Board by Engicam.
> > > 
> > > i.Core MX93 needs to be mounted on top of EDIMM 2.0 Starter Kit
> > > to get the full i.Core MX93 EDIMM 2.0 Starter Kit board.
> > > 
> > > Add bindings for this board.
> > > 
> > > Cc: Matteo Lisi <matteo.lisi@engicam.com>
> > > Cc: Mirko Ardinghi <mirko.ardinghi@engicam.com>
> > > Signed-off-by: Fabio Aiuto <fabio.aiuto@engicam.com>
> > 
> > Acked-by: Conor Dooley <conor.dooley@microchip.com>
> 
> Looks like you might've already got an Ack from Krzysztof on a previous
> version. Please make sure to pick up acks etc when you post new
> versions.

thanks for your Ack, will send a v3 including both your Ack and Krzysztof's
one.

kr,

fabio

> 
> Thanks,
> Conor.
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml
index 0027201e19f8..b497a01c7418 100644
--- a/Documentation/devicetree/bindings/arm/fsl.yaml
+++ b/Documentation/devicetree/bindings/arm/fsl.yaml
@@ -1265,6 +1265,13 @@  properties:
               - fsl,imx93-11x11-evk       # i.MX93 11x11 EVK Board
           - const: fsl,imx93
 
+      - description: Engicam i.Core MX93 based Boards
+        items:
+          - enum:
+              - engicam,icore-mx93-edimm2         # i.MX93 Engicam i.Core MX93 EDIMM 2.0 Starter Kit
+          - const: engicam,icore-mx93             # i.MX93 Engicam i.Core MX93 Som
+          - const: fsl,imx93
+
       - description: i.MXRT1050 based Boards
         items:
           - enum: