From patchwork Fri May 10 09:19:04 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13661110 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05on2080.outbound.protection.outlook.com [40.107.22.80]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5BB6D161B53 for ; Fri, 10 May 2024 09:11:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.22.80 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715332321; cv=fail; b=VTwKF8wwwh/nY4jpRHNg0VR7NVzQT0RXtKoCQsddXp/ZxZIyfNfQUPbtYrog0lfZcJ+4pFxb0k/BffbChAqwr6jeietIs4BGvHqNmttbUGi9XUxWK/Bx9NlaadRd2WQqOcZRSnapn4QrufAG/P2LpInybKE/RdQR6y8gMag8Pzc= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715332321; c=relaxed/simple; bh=tTnmH/6Qnb9N9OjP7YpZL6Z0qYEvJ4SWgZIDAnZMSPo=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=kHxYM2Uml2a1JPrCUPB3VrUq37/IzWAvFaguqhvQTizbodpwHgpCWbT5t/jTOmfwJdDBspR9rJqKB++KmAeZzbl85YVxWpbRF+Vq4erQojj22l3CdXY5gVuCn6AKONZEUGKGx87jnFQ4Z8sj3e8dWsgCq/62Bp8yCvgbemJogOM= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=T4Hj+GTR; arc=fail smtp.client-ip=40.107.22.80 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="T4Hj+GTR" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=UN+FbZbx0j1mSOmshnjvhnedBCaTB4zT+MBt0Yrz61DjAm0EVUe34u8IpIMLvc1HzqNJtRhiqbTeVoWVgNWbx2C/CICzgiiSU3QE/kUjIJD+TNJvswSmVqc6a6VgcTcN/6rh7cgNLKPVypUJZ1J97cfDzKASj0oMnIjUJlyWu9bANeX/D8q7ci45FCtAxsfPDlLBIQ7ZCv+KHqIyZsTFKYodWEnoeA+5RKtuxCbkHWyLXwjtzHX2uxEg+eJt82bGu35S4MWJEx2TKc6r29BvEaPYXN6Nc/VN2CAQomXp3Z0zRE6rhrqc5EzCMLdioe0lLXTuILk6TX+4Rf/J8ZIUmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=shqQpCU+zit6vu8mozb5Ood+1gNMCo0go1qiqqcoK28=; b=e2R4iqP/fOUqtREmJVUf5EIaPnZjSP0V1CikVWgi7K6Dm6uThrSP/Fya2XyPUMvprss8cx04Ek67MCtiGLwa7nHsLAykwzjMsxAOO84ULu6Ic5jD17PsWhXWRbxSqYpVKE+s+E1hd5WHU4I6XsvYOeZLQb32PoN5CBXpCjcsbFzVIwI3CAqPyEzhK0WpDhJeDfiCED58YnTKmnNjV3lZtFZhOalsiMdMqmMa7ybdqsVF1iCPvo6A4qDy4qmQE4k4e7mPcO1I7XfFrB+WPUshvYzmc81ACary6fYDFiRA7FZS9daKjQAVgL85WNpCRnLxHbDqf/wr1WfzoGEIikJsjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=shqQpCU+zit6vu8mozb5Ood+1gNMCo0go1qiqqcoK28=; b=T4Hj+GTRuZN/y58gdURv3u8olNkmjss/UAfdQk/cBOZnOTuNU1K5Qmq/ufS/gU/mX1+IEH2EynjV9sPkd2Uiync/xKy71V7Kdr33JKSvaGGHbaag1NaF3OIpJK2HlpnYAVDYcR1XQbOkj8eIilM8v16V8iy3oLL1aWgWcPqzqe0= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) by PA1PR04MB10399.eurprd04.prod.outlook.com (2603:10a6:102:452::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.47; Fri, 10 May 2024 09:11:55 +0000 Received: from DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d]) by DU0PR04MB9417.eurprd04.prod.outlook.com ([fe80::d30b:44e7:e78e:662d%4]) with mapi id 15.20.7544.046; Fri, 10 May 2024 09:11:55 +0000 From: "Peng Fan (OSS)" Date: Fri, 10 May 2024 17:19:04 +0800 Subject: [PATCH v2 09/17] clk: imx: Remove CLK_SET_PARENT_GATE for DRAM mux for i.MX7D Message-Id: <20240510-imx-clk-v2-9-c998f315d29c@nxp.com> References: <20240510-imx-clk-v2-0-c998f315d29c@nxp.com> In-Reply-To: <20240510-imx-clk-v2-0-c998f315d29c@nxp.com> To: Abel Vesa , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Jacky Bai , Ye Li , Dong Aisheng Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Abel Vesa , Peng Fan X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1715332748; l=2512; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=tawkmb4o3zsB4Mw7AonWFpkCgwbnD1LyifvXX0BKqZk=; b=kP5gJRE7VvRevnaIu1GoCAYVqRE47ZC5cdgIcdz9kKUTODsSbYV8uyLzOAoj+ILGMOdpbUAiY XjvUaRXWVVVD5MNHbMPPydZ1p1RTkdGCJM8p5ni0VDUdSYbhcfHM+eJ X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR02CA0008.apcprd02.prod.outlook.com (2603:1096:4:194::12) To DU0PR04MB9417.eurprd04.prod.outlook.com (2603:10a6:10:358::11) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9417:EE_|PA1PR04MB10399:EE_ X-MS-Office365-Filtering-Correlation-Id: b0f7530c-883c-4a0a-0a93-08dc70d13d02 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230031|376005|1800799015|52116005|7416005|366007|38350700005|921011; X-Microsoft-Antispam-Message-Info: =?utf-8?q?v0l4kJtqAx66OBSedeUvB41iHRYm0JR?= =?utf-8?q?PE9vX/aKWvgsVC46tJ77AabOWCUhSp1eafpN5W+He9XJmj6p3kWhhbfhnjn8C5tB2?= =?utf-8?q?coLm8jbQIHtP8VQSzxDJiEUkMdsyNFQtUqDeTrgghyCd6UT5wXajNmorKqIObIzaS?= =?utf-8?q?rwVxk0vwS9Lu6C9b+L5Flgu/rHMzdjISlN3h7XLgStdYauzY++QgflNm9RVeWm7w8?= =?utf-8?q?7lkBzMfvcq+v3NYJ702dwftRTDH9z7QsLfyecf8qnF9CJHB9+uaNUbLD7JIeXe0Kw?= =?utf-8?q?LW0kg/1TmMHspEGWqxmF7wGLL0fySOHbxku7arReWyUH6X3i2DJwfkm7/wp7heIit?= =?utf-8?q?KDJRWPZ4+rSHGNKOtcgHTbRnl2yq1MgYHhgYNT4/NHP1L4tRYyHdeuZ/Qxavjz7wV?= =?utf-8?q?DVS4Kt8GjXes5NadECjibU2JJIyQVcPflNIRnr+mQekHwhrCmI9k9cDx42L97VWrs?= =?utf-8?q?18T4yHy5OIZLz8YwIUeusjh18zcUgp6/lCwuOcahgAQyeI4IOJH4Wt61f9jeeeNX5?= =?utf-8?q?GG0RcFcBkvLzIVYzn4tYiyC09+MmD3hg7A9125W1rFtr+os3tEoY6RzmdIgRvgvry?= =?utf-8?q?2mmuML4PghZeiQOWvcOD5wMlniTRDNeCu3PjiWT70pUN4pVpe2LuRqo2w0dT2gTnb?= =?utf-8?q?NTZaNfstagYeqjchfE+Z5mx0q6BC0mpxFNJoB8y/l7ZFg6laIwk0j0Q9G0dVLJukI?= =?utf-8?q?JGZ8G00c6OpGca/11C+jYLu+2PnUI+2I2QPY0HZHLFyo/hTiiXNao1mh/oN0PK1K0?= =?utf-8?q?2ENRgMK+RPFwF2Hjqnpm7BP75S8k9PKnhRKhwdOeNWg2QtBCNo4s5o6ciSjh614sc?= =?utf-8?q?5uBZtsX2t08pFMAVoa/4LbjkRA0cyFyzxo4j5O9Oqp90SjsW4aR1dkdQjpuoLneq/?= =?utf-8?q?UWOEASXlbjmPEqesPu+GIK0dfGNLz9+/4cigSHnb9deT9+atb0c0AONZVqRD6KBMr?= =?utf-8?q?gAQNuX/fpJEdzBEO1R39w5OEFpwGABkiFxn/iRrxwDWe0vFWyTQmsqZwFUPpy1/Hy?= =?utf-8?q?kJpMUittln1rT6rFfeTczYnT1nTEZ9TTABwhxnXcOG/aA3XzbwRmT769cgFZBfF10?= =?utf-8?q?V6MBsx09BCng8J9oatl/JRutBeb+0Hz11l+omtezjDP5qezBaGo7FGhS7xvwI479P?= =?utf-8?q?PlE3iqoQWhi5PWkxe8waVbRCcuCVaytFP2eIic7naM1jiX7xIZJS2Qsogm8hQ625I?= =?utf-8?q?lyv6LPGTOrHCysJmyR7K1JGEICzzb4F2JJ4Ww+7t6iNCThYB9s0Rp24PS+k0o92rc?= =?utf-8?q?N3Oqb6qWBYzAUJxaTNaQfBuYr2bDhRWx7vPsDlmS5nnjmBOQybStBrLM=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9417.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(376005)(1800799015)(52116005)(7416005)(366007)(38350700005)(921011);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?h8+oXL4hi1alzRKxsEMbpPcSxAb6?= =?utf-8?q?DZdheJgTy1TKIClAp7XehxA2HWpMbwsgXuPTkoeborK42k3ui7+MVP/ubdVFd1qfS?= =?utf-8?q?0b6NOUX/3u4oVoyGzgei4earLaWCmOy/EVWWag+Eb20dXFg2pXqoQsnvY5ddpJjYP?= =?utf-8?q?bNR3v6to38xviMha8pwQuAPMsl03DDghd1S1GQxc95t/RJUxwMreWqjG5AwlJ3pVM?= =?utf-8?q?beMFhjoTrLyFXC6f6XzjlNrk45dCSzm8zHOSROne5ic62FTZODEcE/55+wvIHvu4k?= =?utf-8?q?TmDwLR2671utky/nIpV2SR/mGwx8L7rFOBhCn9pjPZiYPRZXhkCrypNEZrN48gM66?= =?utf-8?q?LtFSIZL0vXmZz7G/Ahz/x99aaGzREbF+gBGeRXOM+z7enxJSiSdkgggn0LytfprbF?= =?utf-8?q?gVP1TPTUdrZM7JhE3Ryf9QWJlLEwvBit8N4E/Hg5oaGKmjuFJuG02YVxGgBDshzKR?= =?utf-8?q?VAGL94Cur2CyikC+57LYPsBNmr8p7yTXo+uDWXXeopMI59xh8eUBrve+AGoWJq3Kk?= =?utf-8?q?qHwR8dhKBQqU0Hqrog7rQk7UGut+BAq8tSDtdbRnfQSpWfM5yb/dS07YHYPs8e9wd?= =?utf-8?q?JjCAVbH3GExoInt0uWwz4mQWN/Or2mva76stiLL0aMUQFWhKXrmzzM2oD4X13WpFR?= =?utf-8?q?hirPSdicaj5g5NfjvLNDa33sTZR3XcIHiDHhnBlTtFNfVeJbNpmVfw63NnfXzh/lU?= =?utf-8?q?afnxloyrusUhQtXOL7UCQxQLBV29XpgUQAzqRaZAje9lKaTLSW06Vp0bcv3z927AQ?= =?utf-8?q?s9Nq6BLNexYQZvYnCj2V6Rl0PwJUCfTKUeCluiO4AioZluXw2J8ewsmBod15RlJ26?= =?utf-8?q?YBm4gQfbZImTt7o2I/elr/rufzFesmsYJcb9k/2L6k9lBHxgwnJELL6E/oYbzMmTI?= =?utf-8?q?Rkn3nw9vc2IxYVvdCiaVicv36SNEt6FvPbwItx9BTNTBWjS5NcOmPG9XTLBvPZRDY?= =?utf-8?q?+EDvxwwzAT5H1PVEqzsD+H3zR76IM3rtaD99aM/NFO5YghMMt+So2c2FAksp1USq3?= =?utf-8?q?6wAPidmot8UqssTT/TH4xiP4NSP+A6az0tcP2A8XrIJFXNJJItbrUYO/FwkRupE6U?= =?utf-8?q?eDg1jMHs+19vBjSrSSLO4MQdmALA/tt0x1XZTE0WgDETh/suWsodSwuZxktKo5V4c?= =?utf-8?q?qzrEqda+NiFntY2FAayIS5O+5cjOorfBsDS75D3/oUzLHIpjsv2OtFcFvuDSdL1u9?= =?utf-8?q?wGM02yU29vOR/FJZsarCI7/CBKrGGrAq8oT2x/prxuLNVdMR7JR4fmZUKuzs6DXEb?= =?utf-8?q?POPQwjDV0tC7ZYVcAJRFosykK+XV9RThayTgUm4Y2wsU6/DdA6MB/HthhptR6qkH3?= =?utf-8?q?EzS8BTkGOM77nwtqjzekdZKWyGZwW+2KYdP3Ge6kf9ON7PGtmOOX6d3LLGiOkSIPR?= =?utf-8?q?SiOIIjjO7Oe9gkXG2f70X/U5g5yZWapuHBXQm/W1erpLSRKwnRF89mQdHpyZlrdGW?= =?utf-8?q?vMaulfcvUvdVShOpmK48pAOsqVsQ/Psi6XalQSMnTYp4iqdxFRlWRzr6Hnx0rYx+8?= =?utf-8?q?6ylpaTP9zlUr?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: b0f7530c-883c-4a0a-0a93-08dc70d13d02 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9417.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 May 2024 09:11:55.5463 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 348JiIgJMVrekWjPkG7zqNJvXvISWCQCXWd0lt3VuyMA7Yo8juwfS4Z6uUNV2ElnW8XFeKpB6jTsI03XMbUgrw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA1PR04MB10399 From: Peng Fan For i.MX7D DRAM related mux clock, the clock source change should ONLY be done done in low level asm code without accessing DRAM, and then calling clk API to sync the HW clock status with clk tree, it should never touch real clock source switch via clk API, so CLK_SET_PARENT_GATE flag should NOT be added, otherwise, DRAM's clock parent will be disabled when DRAM is active, and system will hang. Signed-off-by: Peng Fan --- drivers/clk/imx/clk-imx7d.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/imx/clk-imx7d.c b/drivers/clk/imx/clk-imx7d.c index 2b77d1fc7bb9..1e1296e74835 100644 --- a/drivers/clk/imx/clk-imx7d.c +++ b/drivers/clk/imx/clk-imx7d.c @@ -498,9 +498,9 @@ static void __init imx7d_clocks_init(struct device_node *ccm_node) hws[IMX7D_ENET_AXI_ROOT_SRC] = imx_clk_hw_mux2_flags("enet_axi_src", base + 0x8900, 24, 3, enet_axi_sel, ARRAY_SIZE(enet_axi_sel), CLK_SET_PARENT_GATE); hws[IMX7D_NAND_USDHC_BUS_ROOT_SRC] = imx_clk_hw_mux2_flags("nand_usdhc_src", base + 0x8980, 24, 3, nand_usdhc_bus_sel, ARRAY_SIZE(nand_usdhc_bus_sel), CLK_SET_PARENT_GATE); hws[IMX7D_DRAM_PHYM_ROOT_SRC] = imx_clk_hw_mux2_flags("dram_phym_src", base + 0x9800, 24, 1, dram_phym_sel, ARRAY_SIZE(dram_phym_sel), CLK_SET_PARENT_GATE); - hws[IMX7D_DRAM_ROOT_SRC] = imx_clk_hw_mux2_flags("dram_src", base + 0x9880, 24, 1, dram_sel, ARRAY_SIZE(dram_sel), CLK_SET_PARENT_GATE); + hws[IMX7D_DRAM_ROOT_SRC] = imx_clk_hw_mux2("dram_src", base + 0x9880, 24, 1, dram_sel, ARRAY_SIZE(dram_sel)); hws[IMX7D_DRAM_PHYM_ALT_ROOT_SRC] = imx_clk_hw_mux2_flags("dram_phym_alt_src", base + 0xa000, 24, 3, dram_phym_alt_sel, ARRAY_SIZE(dram_phym_alt_sel), CLK_SET_PARENT_GATE); - hws[IMX7D_DRAM_ALT_ROOT_SRC] = imx_clk_hw_mux2_flags("dram_alt_src", base + 0xa080, 24, 3, dram_alt_sel, ARRAY_SIZE(dram_alt_sel), CLK_SET_PARENT_GATE); + hws[IMX7D_DRAM_ALT_ROOT_SRC] = imx_clk_hw_mux2("dram_alt_src", base + 0xa080, 24, 3, dram_alt_sel, ARRAY_SIZE(dram_alt_sel)); hws[IMX7D_USB_HSIC_ROOT_SRC] = imx_clk_hw_mux2_flags("usb_hsic_src", base + 0xa100, 24, 3, usb_hsic_sel, ARRAY_SIZE(usb_hsic_sel), CLK_SET_PARENT_GATE); hws[IMX7D_PCIE_CTRL_ROOT_SRC] = imx_clk_hw_mux2_flags("pcie_ctrl_src", base + 0xa180, 24, 3, pcie_ctrl_sel, ARRAY_SIZE(pcie_ctrl_sel), CLK_SET_PARENT_GATE); hws[IMX7D_PCIE_PHY_ROOT_SRC] = imx_clk_hw_mux2_flags("pcie_phy_src", base + 0xa200, 24, 3, pcie_phy_sel, ARRAY_SIZE(pcie_phy_sel), CLK_SET_PARENT_GATE);