diff mbox series

[v2,01/13] ARM: dts: imx6qdl-kontron-samx6i: fix phy-mode

Message ID 20240606090206.2021237-2-mwalle@kernel.org (mailing list archive)
State Superseded
Headers show
Series ARM: dts: kontron-samx6i: various fixes | expand

Commit Message

Michael Walle June 6, 2024, 9:01 a.m. UTC 
The iMX.6 cannot add any RGMII delays. The PHY has to add both the RX
and TX delays on the RGMII interface. Fix the interface mode. While at
it, use the new phy-connection-type property name.

Fixes: 5694eed98cca ("ARM: dts: imx6qdl-kontron-samx6i: move phy reset into phy-node")
Signed-off-by: Michael Walle <mwalle@kernel.org>
---
 arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Shawn Guo June 17, 2024, 1:39 a.m. UTC | #1 
On Thu, Jun 06, 2024 at 11:01:54AM +0200, Michael Walle wrote:
> The iMX.6 cannot add any RGMII delays. The PHY has to add both the RX

s/iMX.6/i.MX6?

Shawn

> and TX delays on the RGMII interface. Fix the interface mode. While at
> it, use the new phy-connection-type property name.
> 
> Fixes: 5694eed98cca ("ARM: dts: imx6qdl-kontron-samx6i: move phy reset into phy-node")
> Signed-off-by: Michael Walle <mwalle@kernel.org>
> ---
>  arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi
> index 85aeebc9485d..d8c1dfb8c9ab 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi
> +++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi
> @@ -259,7 +259,7 @@ smarc_flash: flash@0 {
>  &fec {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_enet>;
> -	phy-mode = "rgmii";
> +	phy-connection-type = "rgmii-id";
>  	phy-handle = <&ethphy>;
>  
>  	mdio {
> -- 
> 2.39.2
>
diff mbox series

Patch

diff --git a/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi b/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi
index 85aeebc9485d..d8c1dfb8c9ab 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi
+++ b/arch/arm/boot/dts/nxp/imx/imx6qdl-kontron-samx6i.dtsi
@@ -259,7 +259,7 @@  smarc_flash: flash@0 {
 &fec {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_enet>;
-	phy-mode = "rgmii";
+	phy-connection-type = "rgmii-id";
 	phy-handle = <&ethphy>;
 
 	mdio {