| Message ID | 20240606143648.152668-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | In Next, archived |
| Headers | show |
| Series | [1/3] mfd: max14577: Fix Wvoid-pointer-to-enum-cast warning (again) | expand |
On Thu, 06 Jun 2024 16:36:46 +0200, Krzysztof Kozlowski wrote: > 'type' is an enum, thus cast of pointer on 64-bit compile test with > clang and W=1 causes: > > max14577.c:400:23: error: cast to smaller integer type 'enum maxim_device_type' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast] > > Year ago this was solved, although LKML discussion suggested warning is > not suitable for kernel. Nothing changed in this regard for a year, so > assume the warning will stay and we want to have warnings-free builds. > > [...] Applied, thanks! [1/3] mfd: max14577: Fix Wvoid-pointer-to-enum-cast warning (again) commit: 9d1e745c2dc06fed0eb6e3b549b75669f9da77be [2/3] mfd: mxs-lradc: Fix Wvoid-pointer-to-enum-cast warning (again) commit: a377d89e5064e787deecfb87d9464ea18f5f067e [3/3] mfd: wm8994: Fix Wvoid-pointer-to-enum-cast warning (again) commit: 05bb1fb09b523136acb58421361a259127de68d4 -- Lee Jones [李琼斯]
diff --git a/drivers/mfd/max14577.c b/drivers/mfd/max14577.c index 8f7472c76009..67bf4de4c0c1 100644 --- a/drivers/mfd/max14577.c +++ b/drivers/mfd/max14577.c @@ -397,7 +397,7 @@ static int max14577_i2c_probe(struct i2c_client *i2c) return ret; } - max14577->dev_type = (enum maxim_device_type)i2c_get_match_data(i2c); + max14577->dev_type = (kernel_ulong_t)i2c_get_match_data(i2c); max14577_print_dev_type(max14577);
'type' is an enum, thus cast of pointer on 64-bit compile test with clang and W=1 causes: max14577.c:400:23: error: cast to smaller integer type 'enum maxim_device_type' from 'const void *' [-Werror,-Wvoid-pointer-to-enum-cast] Year ago this was solved, although LKML discussion suggested warning is not suitable for kernel. Nothing changed in this regard for a year, so assume the warning will stay and we want to have warnings-free builds. Link: https://lore.kernel.org/all/20230814160457.GA2836@dev-arch.thelio-3990X/ Link: https://lore.kernel.org/all/20230810095849.123321-1-krzysztof.kozlowski@linaro.org/ Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/mfd/max14577.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)