From patchwork Mon Jun 17 20:16:45 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13701389 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2087.outbound.protection.outlook.com [40.107.103.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C445219D067 for ; Mon, 17 Jun 2024 20:18:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.103.87 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718655490; cv=fail; b=Ej0Sjz1i5bQj4DCS8Ylk7huTVwoOMZmqbuNNQ3ZaNEr0VQlXh+lcCVrch0NWrolDXU04om7cb2ylOZzXq/ES9E0rt6aKsLVF2lN0im2W8IVxBsYKmEmvgsQ6UokTwo94dB7zuvGVlkQINQ+HGygP3Yi9rKcs1qB2rbEOvNwgTFk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718655490; c=relaxed/simple; bh=SHH+RxbPVg9d9vvgQwAyIOSN1a0ktF2Q9tORg7XL1Wg=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=BAASp77DUvJeouY4dyfCDTrXOpv5W1WWBeiehymJUeASDzfSkIQWvCJX6kZGdOVHIL9vpDrJJe1PvzQx7s36lbLtRWqzyuKrLQkCbNt/5hr//sQttrEgq7ka5Ew6UNvAI64hQWiykrHIe9QIJRGjTFcmhLbfL1veBf0WoIg6D/c= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=nUALNL3y; arc=fail smtp.client-ip=40.107.103.87 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="nUALNL3y" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JLlh1Q4LU71Zy6JKAcX+isitunPdsHwVaLip4liZSK4MkU9YqF4RlSYo3+NuH+2KRUt1DBFSB3+40qOO7ZTsoujfwz0Jkl1hV1NYu04pSKtgsI1A9j5/6NV+nHirvMdxkg1aeAmmWVkt3E9esjLDpeTdcuJ9INmN0tYqV6NsLgVhpt8Tjqa9iPrT3X+bXNHl6W5ABUOAIWK+RNTdyYmqp1zLqBVheyUz09uB8IEPFvMGIpQUq3tYmbyY8AAfDzBq6cDio29wWFgBYmRFWwIGHlrgKU9ZaXbSsL/BCdSNeVkzlIqkW4WZPzOLl2nFIV7NW4/fAf+uPa4bpwG+poJjEg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tHd1Na5jpn2/1hr3DnG0fdy90jL7MoCN4Eo+Mj/vcaY=; b=eRXZiA3m8NhUpK9/ZotHyUvmjksuivr9nNIGaFYhFlm67zpKZnmY3ZoKEh+y3KCkww+EMu0NbmtnQZncTexLDHbIxENGAF6zuWMQ4yKkQmXjGAxvl7G7IcOdmrkPinm++QbJ3Tqd9SXI9TmjihLXUvOSxgnMUHqDxW08PFAgfeq7BFFRSW3XnJWwBIyn7sCVJYNp5YYhvd46a3e4ctv7WJWLvTXSSIu+3J+D+V/f1X6idLe2BWfxKpPsagHFMP5BGPIfFPicBnHjPAbhI4dKqnp7FAE4MLo6UA5xL7HIh+r+9ZSqRCCrm8Y6TibgP7jxWglSiybv+QJfxor1+iLhEA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tHd1Na5jpn2/1hr3DnG0fdy90jL7MoCN4Eo+Mj/vcaY=; b=nUALNL3yY13rFk4t5BpAKAS0N7C4vD3lhhclDrk56DvI1/QwFRN83+ZdDsPwDP4whKvx52lb/sJVdPWLVEoExsMU3ENGmGvwSiFba+x2ymsyudSm7jBiDRQvgBzt5pLqZkRaP6bKcQN3UmrZUBqSLOUud7XQS7DKo8xzMOmzqhI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PA4PR04MB7997.eurprd04.prod.outlook.com (2603:10a6:102:c9::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7677.30; Mon, 17 Jun 2024 20:18:05 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.7677.030; Mon, 17 Jun 2024 20:18:05 +0000 From: Frank Li Date: Mon, 17 Jun 2024 16:16:45 -0400 Subject: [PATCH v6 09/10] PCI: imx6: Call: Common PHY API to set mode, speed, and submode Message-Id: <20240617-pci2_upstream-v6-9-e0821238f997@nxp.com> References: <20240617-pci2_upstream-v6-0-e0821238f997@nxp.com> In-Reply-To: <20240617-pci2_upstream-v6-0-e0821238f997@nxp.com> To: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Liam Girdwood , Mark Brown , Manivannan Sadhasivam , Krzysztof Kozlowski , Conor Dooley Cc: linux-pci@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1718655424; l=2342; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=SHH+RxbPVg9d9vvgQwAyIOSN1a0ktF2Q9tORg7XL1Wg=; b=1DI3HJ76h3fwRbwaWh5+zj2zcwaMy67Ux3uNEvoY+VsVDXNwCeK8AK9kbH+c+fD5DiENFwqw8 s3npenmN8jJBqLfo2zclPe35U8r/3CQzw/wF27Wwy8LUHJeKwEj12gS X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR05CA0116.namprd05.prod.outlook.com (2603:10b6:a03:334::31) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PA4PR04MB7997:EE_ X-MS-Office365-Filtering-Correlation-Id: 19e2af5f-b5ba-4353-2f27-08dc8f0a98dd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230037|376011|7416011|1800799021|366013|52116011|38350700011|921017; X-Microsoft-Antispam-Message-Info: =?utf-8?q?WVHqviDWkREWBd5G2IMln0t9mCx/t1V?= =?utf-8?q?7Jzb7p08Z8MygWH2APB2d5yH/7QwWUjJsZgw4MVpp0UZLIPCUwQyaZ3AI5N/50ub+?= =?utf-8?q?2xE38hQFocMjmurJhWt4PibyVWY97KTwQp1P59ZdQoOtRZsH/BcjpUvCo+e6gwgW2?= =?utf-8?q?eDX/hAwLXANQjkRl2TyNFu1UZK+1iPuGz6/BGUtki8cK+gN68rO7D1crDsKEFfsR7?= =?utf-8?q?7BtaNcJmZihDvKBPQlyQ32Ewjz+OoAWhW3TV1xym+lG6ZhOPIn4emJnZCuzKj0ziO?= =?utf-8?q?j8fTuX02tj9oxrYoKY/aMjge66bEtSxM4GUKMVVK2JfaqjhSW3RClWKYBQfdqlHlI?= =?utf-8?q?S5Zi1YX7YBkrMgfvx/oGaiXDKZrlNTc7vH/4BMgIdOmdRzEf7m8bsr3/KPSzQDu+J?= =?utf-8?q?yziziQYtIZ76Umq4jD6Q7U5J2bYX+43ZO4lr3bj/nDQDpZsXwtPhKAyPyLzGBlyXE?= =?utf-8?q?GIa3PFprtMOfjIy2Cl7gLnRxJ+lsrWUCRpBvC1Zy4121BbK0fk4asqo0rRHXaARb9?= =?utf-8?q?sZxgZOVVEA/0Qbx4g51intFlmAoXuPBGXQ3b+SzjNq1/4RTW9IdpUFUA/fWYV3pNh?= =?utf-8?q?DeZiTQh4Lu1mVOyBoqkAaP60DzwB8FRAns5kyaFoSYI4ZLW4LYm2Z9iZ24Z9G5S7d?= =?utf-8?q?OW6j5nuqcKUYTdZ7SQrJTUAE/5T5RJwQds1FApbHlI5Faiqttzd3A541UKq4UzPSe?= =?utf-8?q?T6nPMoSpnOUhAdm91RwN+vsV98q2h4xCipP7guLd6pOTZ9puJ7z53vwH4WC5brJyr?= =?utf-8?q?KNaNCHHx8HQLbm9wWVMN4GdpfnAznj7ny71R0q82H5ThXYk+pBDeLa05q+X+rpYXe?= =?utf-8?q?qwjAHIYZHh/XTXFmNk5N7vZw3fhOoXwXhIIAdyUlsCvdoBvpgDWbxbXn4H7tYJh33?= =?utf-8?q?i5KQftJ3oI28loC4I1wviXFUTpENDEBgTF8rlWR2fxWm2NxWH7PCQbgk6qMEjGmKd?= =?utf-8?q?KKBeTYQP92PgK3Pcd1Zhrfj7nNXRQA0DxAC5oXq2f9z8fw/6xD4cBP+9g/DGU2qqE?= =?utf-8?q?dexntM19f+nOz2WcT4v9l5po3rf8H9br9Pt8zIir51ygb6K3xjbPDaoIDeWbJwctr?= =?utf-8?q?LxY/fELllvwlP/FFRcsREVYmS4o+a9Z8gDmUM0lP/ltdnlfxcIwUa4JIVHa+s/LK2?= =?utf-8?q?myEwK7QYzkgqHYZcc2vhYREy3i7/FjEsK2ePF+4SVotzoNl9b4KFpshlq6UR3uBsQ?= =?utf-8?q?EhqR/EG8vPTqeNgiWvqCF4LEY143t/2C/Cv54Lsy/NJas1DcY197uNucb4iBFDv3F?= =?utf-8?q?olDX78vWyJ/gaAOcd9dw6vaN0CiTGdJOe3AwT4rJHQz5ApmUawFT7EXMGLkioN8kO?= =?utf-8?q?eM0dYvg3k6Ug?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230037)(376011)(7416011)(1800799021)(366013)(52116011)(38350700011)(921017);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?kYOctL2qazr3jxbZjeFmPFWVAljM?= =?utf-8?q?soE0Z6d0yuDJ4nyfX4U8fk3eozIGEeMxq8akG9S0djXkFPRhZWs7DLo0vYxoHmxbJ?= =?utf-8?q?swAfvbMjfrgQMzJ8qxcYJMrnq009Q+P7q/z4dxaPCx4kDKc6eaYx6wJwX7OEJfzJo?= =?utf-8?q?30Gsa06wAMWVyu3ow2Acp5Lg5FtLrR2zytqoLZjxqokuyp24y+IXC+T2ARrhVMO/R?= =?utf-8?q?wldSJtZCPp/w4hz9jGx8hya5dXDEgjYMGaxkzu+w1ZxQ02P+SM1DfZ14AMu0s9EFH?= =?utf-8?q?EDOQH1t//XaXI1q/+wvzJmJdEcKNyIKhJQYegMl0g79Obo39+lLmcynoWtZFAAr52?= =?utf-8?q?iOs9kLlvlHbE/kNn19Az/gM7QWZo5oXkHt5BR3manpBkAhkU5NuFn5EWf8MhPSrSl?= =?utf-8?q?GThCZuJRxfcMtVVvSADV+hS91KMhZukeoCaq6bUbhGFm6DVImEx6XWFrSbQYNeB3S?= =?utf-8?q?HrxD0fqIfStkvuJIjNwiBk3DkSJDSL5KPHKsXL9qUW0PZBiDVC/LyDZOXiqJi9WQR?= =?utf-8?q?+2qxGodTxysW6ItuQLCgN65HKnc2hHWyPLbkIGtXPGAiHSxotHUoT5RHc+LSgy7rI?= =?utf-8?q?lje8CaAT0ploQS8II8fMqyIkJzPdNzPc4Y2bFuG49Iae7B3KarVZlIOkbK/1k9DPh?= =?utf-8?q?SrhyJePiO5OeieB8Ppouh4tqDL7GuZ0iD/TjiednYCW+jn6WIjgp+glsWC3w08KUC?= =?utf-8?q?qMQ3JGkeiuTXgirJPamX9GrgfsRIzZySE3m9cUZH63YEYmZdUinL5zrpzZnnsmzfR?= =?utf-8?q?+Ots2RQ3AIjDVAEzn8lhTTvZ7pM9ipCft22uQ+rQ2AabfUoXKNKsKbAcYAE70eTyO?= =?utf-8?q?zkxckOvAZyo0C6BB2OXFdA6agchuO7rpb95RvK12d7YDdbGQysGogczLd7HmGtIQX?= =?utf-8?q?d313c6Hs2RQVTFdjze/W00S0i7aGNAUhmDRTP6C8Go/ww+RJ8r3MtmX1dBJS5sQbU?= =?utf-8?q?95KCUNmIq3WZEDYf9x1CmTV5zdZX+QyiJlz7nvSHaB+js5rEezy4Acs58roJr6f9R?= =?utf-8?q?AFqm+JxDQOJ6saIiHyG7f1/HxNo0KCH+02S6Pz42UUbH25LpsOoEypVaZbAjqm6J0?= =?utf-8?q?aSycgFQnwAEWfFzq6R3kuD0B3xgP5WvIarebGCm1xjdVHHjqbv7Kgis5llcgG3peo?= =?utf-8?q?KcBCqNAdFA4QGvdpbgD1B9WOWaMxtt5G0TOAHsslUAkAwq+kefecanjE5vaESudGw?= =?utf-8?q?8+heJ4rm2JxrocU2sNmWKqSREY9vBcWamLy8hz12geVEy+kerEG/42pV6tkU4olxg?= =?utf-8?q?fTT/fOLxGa7kJT1Q+Y+rolGeMHNBo0v0nIAOBENnDiC+d33XodkpmPC5Mg2NvVo2R?= =?utf-8?q?WpjHhkhqAOgqg6KBIIkcy30+ZTPWMvFGBoSqnnxBgJka5pQlKzSCmM/N6Gbw1zDtY?= =?utf-8?q?cdkhWgc+2OFYZnjGV7Jw/kSUlLeaAr1vjDDlqmf3P2tI72QZF/cygtVnDDnRKCsGI?= =?utf-8?q?wDEqhTkGvt2CLV1uyT5BN81zXQ9pO0woHZUock898W92qWNnVWunA0XU5l4Dp/FIj?= =?utf-8?q?lfXaq1YgR8rg?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 19e2af5f-b5ba-4353-2f27-08dc8f0a98dd X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2024 20:18:05.7756 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: TcQGik/0oNDC8zazY4KbcK01Tw0mraCBnbMElbrZU86Fsd1fYBixyg6LgD+6RyacYUIRUB+vKr9HYZoGUuSVRw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7997 Invoke the common PHY API to configure mode, speed, and submode. While these functions are optional in the PHY interface, they are necessary for certain PHY drivers. Lack of support for these functions in a PHY driver does not cause harm. Signed-off-by: Frank Li --- drivers/pci/controller/dwc/pci-imx6.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index ab0ed7ab3007a..18c133f5a56fc 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -30,6 +30,7 @@ #include #include #include +#include #include #include @@ -229,6 +230,10 @@ static void imx_pcie_configure_type(struct imx_pcie *imx_pcie) id = imx_pcie->controller_id; + /* If mode_mask[0] is 0, means use phy driver to set mode */ + if (!drvdata->mode_mask[0]) + return; + /* If mode_mask[id] is zero, means each controller have its individual gpr */ if (!drvdata->mode_mask[id]) id = 0; @@ -808,6 +813,7 @@ static void imx_pcie_ltssm_enable(struct device *dev) struct imx_pcie *imx_pcie = dev_get_drvdata(dev); const struct imx_pcie_drvdata *drvdata = imx_pcie->drvdata; + phy_set_speed(imx_pcie->phy, PCI_EXP_LNKCAP_SLS_2_5GB); if (drvdata->ltssm_mask) regmap_update_bits(imx_pcie->iomuxc_gpr, drvdata->ltssm_off, drvdata->ltssm_mask, drvdata->ltssm_mask); @@ -820,6 +826,7 @@ static void imx_pcie_ltssm_disable(struct device *dev) struct imx_pcie *imx_pcie = dev_get_drvdata(dev); const struct imx_pcie_drvdata *drvdata = imx_pcie->drvdata; + phy_set_speed(imx_pcie->phy, 0); if (drvdata->ltssm_mask) regmap_update_bits(imx_pcie->iomuxc_gpr, drvdata->ltssm_off, drvdata->ltssm_mask, 0); @@ -955,6 +962,12 @@ static int imx_pcie_host_init(struct dw_pcie_rp *pp) goto err_clk_disable; } + ret = phy_set_mode_ext(imx_pcie->phy, PHY_MODE_PCIE, PHY_MODE_PCIE_RC); + if (ret) { + dev_err(dev, "unable to set pcie PHY mode\n"); + goto err_phy_off; + } + ret = phy_power_on(imx_pcie->phy); if (ret) { dev_err(dev, "waiting for PHY ready timeout!\n");