| Message ID | 20240621165149.2275794-3-Frank.Li@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/6] arm64: dts: layerscape: add platform special compatible string for gpio | expand |
On Fri, Jun 21, 2024 at 10:52 AM Frank Li <Frank.Li@nxp.com> wrote: > > Add '#power-control-cells' for rcpm: power-control node to fix below You mean #power-domain-cells? > warning. > > power-controller@1ee2140: '#power-domain-cells' is a required property > from schema $id: http://devicetree.org/schemas/power/power-domain.yaml# > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 1 + > arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 1 + > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 1 + > arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 1 + > arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 1 + > arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 1 + > 6 files changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > index 1331858add942..1b6ab9550cce9 100644 > --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi > @@ -560,6 +560,7 @@ pcie1: pcie@3400000 { > rcpm: power-controller@1ee2140 { > compatible = "fsl,ls1012a-rcpm", "fsl,qoriq-rcpm-2.1+"; > reg = <0x0 0x1ee2140 0x0 0x4>; > + #power-domain-cells = <0>; The thing is this h/w is not controlling power domains nor using the binding. So I think the fix here is either rename the node name or drop this schema check ($nodename). We really only do the latter if we want to only reference the power-domain.yaml schema from all specific power domain controller schemas. That's really only done if there's more than just #foo-cells defined by the schema which is not the case here. So we should probably rename the node to 'rcpm' or something. Seems like a step back, but there's really nothing generic to use here. Rob
diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi index 1331858add942..1b6ab9550cce9 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi @@ -560,6 +560,7 @@ pcie1: pcie@3400000 { rcpm: power-controller@1ee2140 { compatible = "fsl,ls1012a-rcpm", "fsl,qoriq-rcpm-2.1+"; reg = <0x0 0x1ee2140 0x0 0x4>; + #power-domain-cells = <0>; #fsl,rcpm-wakeup-cells = <1>; }; diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi index 09897fe8a1a2f..c43d73e2d090e 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi @@ -1322,6 +1322,7 @@ pwm7: pwm@2870000 { rcpm: power-controller@1e34040 { compatible = "fsl,ls1028a-rcpm", "fsl,qoriq-rcpm-2.1+"; reg = <0x0 0x1e34040 0x0 0x1c>; + #power-domain-cells = <0>; #fsl,rcpm-wakeup-cells = <7>; little-endian; }; diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi index b61e03e4cce15..caf765593547b 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi @@ -986,6 +986,7 @@ qdma: dma-controller@8380000 { rcpm: power-controller@1ee2140 { compatible = "fsl,ls1043a-rcpm", "fsl,qoriq-rcpm-2.1+"; reg = <0x0 0x1ee2140 0x0 0x4>; + #power-domain-cells = <0>; #fsl,rcpm-wakeup-cells = <1>; }; diff --git a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi index d8680ebef137e..81b80b6b27d31 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi @@ -1036,6 +1036,7 @@ dpmac10: ethernet@a { rcpm: power-controller@1e34040 { compatible = "fsl,ls1088a-rcpm", "fsl,qoriq-rcpm-2.1+"; reg = <0x0 0x1e34040 0x0 0x18>; + #power-domain-cells = <0>; #fsl,rcpm-wakeup-cells = <6>; little-endian; }; diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi index 5695b43fba587..dac33a3eab841 100644 --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi @@ -1221,6 +1221,7 @@ ccn@4000000 { rcpm: power-controller@1e34040 { compatible = "fsl,ls208xa-rcpm", "fsl,qoriq-rcpm-2.1+"; reg = <0x0 0x1e34040 0x0 0x18>; + #power-domain-cells = <0>; #fsl,rcpm-wakeup-cells = <6>; little-endian; }; diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi index 26c7ca31e22e7..12b6ec4926456 100644 --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi @@ -1081,6 +1081,7 @@ watchdog@23a0000 { rcpm: power-controller@1e34040 { compatible = "fsl,lx2160a-rcpm", "fsl,qoriq-rcpm-2.1+"; reg = <0x0 0x1e34040 0x0 0x1c>; + #power-domain-cells = <0>; #fsl,rcpm-wakeup-cells = <7>; little-endian; };
Add '#power-control-cells' for rcpm: power-control node to fix below warning. power-controller@1ee2140: '#power-domain-cells' is a required property from schema $id: http://devicetree.org/schemas/power/power-domain.yaml# Signed-off-by: Frank Li <Frank.Li@nxp.com> --- arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 1 + arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 1 + arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 1 + arch/arm64/boot/dts/freescale/fsl-ls1088a.dtsi | 1 + arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 1 + arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 1 + 6 files changed, 6 insertions(+)