| Message ID | 20240628144858.2363300-1-Frank.Li@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/1] dt-bindings: PCI: layerscape-pci: Fix property 'fsl,pcie-scfg' type | expand |
On Fri, Jun 28, 2024 at 10:48:57AM -0400, Frank Li wrote: > fsl,pcie-scfg actually need an argument when there are more than one PCIe > instances. Change it to phandle-array and use items to describe each field > means. > > Fix below warning. > > arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dtb: pcie@3400000: fsl,pcie-scfg:0: [22, 0] is too long > from schema $id: http://devicetree.org/schemas/pci/fsl,layerscape-pcie.yaml# > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Change from v1 to v2 > - update commit message. > --- > .../devicetree/bindings/pci/fsl,layerscape-pcie.yaml | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml > index 793986c5af7ff..679c2989de7a2 100644 > --- a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml > @@ -43,10 +43,16 @@ properties: > - const: config > > fsl,pcie-scfg: > - $ref: /schemas/types.yaml#/definitions/phandle > + $ref: /schemas/types.yaml#/definitions/phandle-array > description: A phandle to the SCFG device node. The second entry is the > physical PCIe controller index starting from '0'. This is used to get > SCFG PEXN registers. > + items: > + items: > + - description: A phandle to the SCFG device node > + - description: PCIe controller index starting from '0' > + minItems: 1 Are there any cases with only the phandle? I don't see any in tree and looks like the driver requires the 2nd entry. > + maxItems: 1 > > big-endian: > $ref: /schemas/types.yaml#/definitions/flag > -- > 2.34.1 >
diff --git a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml index 793986c5af7ff..679c2989de7a2 100644 --- a/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml +++ b/Documentation/devicetree/bindings/pci/fsl,layerscape-pcie.yaml @@ -43,10 +43,16 @@ properties: - const: config fsl,pcie-scfg: - $ref: /schemas/types.yaml#/definitions/phandle + $ref: /schemas/types.yaml#/definitions/phandle-array description: A phandle to the SCFG device node. The second entry is the physical PCIe controller index starting from '0'. This is used to get SCFG PEXN registers. + items: + items: + - description: A phandle to the SCFG device node + - description: PCIe controller index starting from '0' + minItems: 1 + maxItems: 1 big-endian: $ref: /schemas/types.yaml#/definitions/flag
fsl,pcie-scfg actually need an argument when there are more than one PCIe instances. Change it to phandle-array and use items to describe each field means. Fix below warning. arch/arm64/boot/dts/freescale/fsl-ls1043a-rdb.dtb: pcie@3400000: fsl,pcie-scfg:0: [22, 0] is too long from schema $id: http://devicetree.org/schemas/pci/fsl,layerscape-pcie.yaml# Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Change from v1 to v2 - update commit message. --- .../devicetree/bindings/pci/fsl,layerscape-pcie.yaml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)