diff mbox series

[v2,1/1] dt-bindings: fsl-qdma: fix interrupts 'if' check logic

Message ID 20240701195717.1843041-1-Frank.Li@nxp.com (mailing list archive)
State Superseded
Headers show
Series [v2,1/1] dt-bindings: fsl-qdma: fix interrupts 'if' check logic | expand

Commit Message

Frank Li July 1, 2024, 7:57 p.m. UTC
All compatible string include 'fsl,ls1021a-qdma'. Previous if check are
always true.

if:
  properties:
    compatible:
      contains:
       enum:
         - fsl,ls1021a-qdma

Change to check other compatible strings to get correct logic and fix
below CHECK_DTB warnings.

arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dtb:
dma-controller@8380000: interrupts: [[0, 43, 4], [0, 251, 4], [0, 252, 4], [0, 253, 4], [0, 254, 4]] is too long

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Change from v1 to v2
- Change  maxItems: 5 to minItems: 5. because maxItems: 5 already restrict
at top

interrupts:
    minItems: 2
    maxItems: 5
---
 Documentation/devicetree/bindings/dma/fsl-qdma.yaml | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

Comments

Rob Herring (Arm) July 8, 2024, 2:57 p.m. UTC | #1
On Mon, 01 Jul 2024 15:57:16 -0400, Frank Li wrote:
> All compatible string include 'fsl,ls1021a-qdma'. Previous if check are
> always true.
> 
> if:
>   properties:
>     compatible:
>       contains:
>        enum:
>          - fsl,ls1021a-qdma
> 
> Change to check other compatible strings to get correct logic and fix
> below CHECK_DTB warnings.
> 
> arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dtb:
> dma-controller@8380000: interrupts: [[0, 43, 4], [0, 251, 4], [0, 252, 4], [0, 253, 4], [0, 254, 4]] is too long
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Change from v1 to v2
> - Change  maxItems: 5 to minItems: 5. because maxItems: 5 already restrict
> at top
> 
> interrupts:
>     minItems: 2
>     maxItems: 5
> ---
>  Documentation/devicetree/bindings/dma/fsl-qdma.yaml | 10 +++++++++-
>  1 file changed, 9 insertions(+), 1 deletion(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Vinod Koul July 10, 2024, 10:15 a.m. UTC | #2
On Mon, 01 Jul 2024 15:57:16 -0400, Frank Li wrote:
> All compatible string include 'fsl,ls1021a-qdma'. Previous if check are
> always true.
> 
> if:
>   properties:
>     compatible:
>       contains:
>        enum:
>          - fsl,ls1021a-qdma
> 
> [...]

Applied, thanks!

[1/1] dt-bindings: fsl-qdma: fix interrupts 'if' check logic
      commit: b8ec9dba02a74797421c52b1226b23a4302362a6

Best regards,
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/dma/fsl-qdma.yaml b/Documentation/devicetree/bindings/dma/fsl-qdma.yaml
index 25e410a149fce..9401b1f6300d4 100644
--- a/Documentation/devicetree/bindings/dma/fsl-qdma.yaml
+++ b/Documentation/devicetree/bindings/dma/fsl-qdma.yaml
@@ -92,8 +92,16 @@  allOf:
         compatible:
           contains:
             enum:
-              - fsl,ls1021a-qdma
+              - fsl,ls1028a-qdma
+              - fsl,ls1043a-qdma
+              - fsl,ls1046a-qdma
     then:
+      properties:
+        interrupts:
+          minItems: 5
+        interrupt-names:
+          minItems: 5
+    else:
       properties:
         interrupts:
           maxItems: 3