diff mbox series

arm64: dts: freescale: tqma9352: Fix watchdog reset

Message ID 20240703120409.1103787-1-s.hauer@pengutronix.de (mailing list archive)
State Superseded
Headers show
Series arm64: dts: freescale: tqma9352: Fix watchdog reset | expand

Commit Message

Sascha Hauer July 3, 2024, 12:04 p.m. UTC
On the tqma9352 the board is reset through an external PMIC, so
set the fsl,ext-reset-output property to enable triggering the
output pin on a watchdog trigger.

Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
---
 arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Fabio Estevam July 3, 2024, 12:15 p.m. UTC | #1
Hi Sascha,

On Wed, Jul 3, 2024 at 9:05 AM Sascha Hauer <s.hauer@pengutronix.de> wrote:

> @@ -151,6 +151,7 @@ &wdog3 {
>         pinctrl-names = "default";
>         pinctrl-0 = <&pinctrl_wdog>;
>         status = "okay";
> +       fsl,ext-reset-output;

Nitpick: it is preferred to keep status as the last entry.

Other than that:

Reviewed-by: Fabio Estevam <festevam@gmail.com>
Alexander Stein July 3, 2024, 12:40 p.m. UTC | #2
Hi Sascha,

thanks for the patch.

Am Mittwoch, 3. Juli 2024, 14:04:09 CEST schrieb Sascha Hauer:
> On the tqma9352 the board is reset through an external PMIC, so
> set the fsl,ext-reset-output property to enable triggering the
> output pin on a watchdog trigger.
> 
> Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
> index 9d2328c185c90..e9d89b4bbba04 100644
> --- a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
> @@ -151,6 +151,7 @@ &wdog3 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_wdog>;
>  	status = "okay";
> +	fsl,ext-reset-output;

As Fabio mentioned, status is the last property. With that fixed:
Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>

>  };
>  
>  &iomuxc {
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
index 9d2328c185c90..e9d89b4bbba04 100644
--- a/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx93-tqma9352.dtsi
@@ -151,6 +151,7 @@  &wdog3 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_wdog>;
 	status = "okay";
+	fsl,ext-reset-output;
 };
 
 &iomuxc {