From patchwork Wed Jul 3 16:32:50 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shenwei Wang X-Patchwork-Id: 13722582 Received: from AM0PR83CU005.outbound.protection.outlook.com (mail-westeuropeazon11010059.outbound.protection.outlook.com [52.101.69.59]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 581DC181D0A for ; Wed, 3 Jul 2024 16:33:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.69.59 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720024387; cv=fail; b=K4AfPzbHsg9Tm7gJJ74MwK+9vnhGJofnbATWYodtgtsEcT8oDZP5lG46HfVDHMpMHW7MOSpW+qlgYwGRrdFvS1VZULavSsp3jbHid6sLy3Q+8QKKuxVqdDwjpM6dfIc5qD1Jq69rQccdQZ7cRID3Ss9RtGk+vfGpGbkvKtMWGkk= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720024387; c=relaxed/simple; bh=Gs7wXChJqaTLzE5lh0TEaSZRZKEc1pkI59kk7LP1ze8=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=EdaO9vTTkg02mQPeKnhZqKoSB6Xo3tzBlk9m9o+7lxpJpqj82tN9IvYPTyuI5YlN3VkbCPSer2u9Ndqty4Dqp1MGAu5rrOlATc85KRPpOHrz6AuseCFth8yUseKOl/IgI2Z0weIy13JpZhbnHMUOyIwzr0nq4I+8zCYn5OI9Pww= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=l63O/Frs; arc=fail smtp.client-ip=52.101.69.59 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="l63O/Frs" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=M7FJ/6lfYsJ/58lNbUhoNWBgpx7G1LlSLNHTLY4jYsYcfMN0JHZtyV43S9t9NWU2zeRsB+PKk8Sl3cbrd18f3l0AyMpzX4bFeo0j7r5RgNHZdkdcxRmtENF84g9p2oWTMQHJFlRWxOF4ieLElXQO5V43qJg6TmM/vNqF4ZzUBoGO3UEopFUWBsynyvBelVwZ/owjXIzNE7XbpzfsxIEjbCQNwU6lmsRXbiBbolz0Rud9slY413aBuxwLwPMuX8XPfkW6p3sB4fy7aOFCWeHxg9d+lkNGCgFrLIO4iAAMvl5cpbJuE4sT1AjaiHqkhw9qBiBPfzZcSn+i+5URo/dDQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fiMGaSdwi8CrmbPKBdzCI3wWPztvyWNa9svQfeECg48=; b=dgUuRZBqBFyQeDVW4OG/1Gsj+SdDtFRTTYOhQdZnMApsdtNff0cPwcL87UevnQgVedz3KwBTzym1Hrop5Kh6jLjrB7venRj8zjwCCxfyss92b2Ci7UyWZszMVuzHQMDYvacv9iDOuQVqwsp5IG1lWOjY2goRSdNVJPlxdmix97gLby70aKd7M9v2XgHKuxw6UVnbpJbWOQbFQ9O6+KywMUWggru130THWD5c+9u5oVFJW4NmwTc78A4AP8vq60B8i6xWOHbtffvPRlgatQz1k9q8KA6gT+qjaP9PyV/IAfFmvwboStdh4THfSmiFdW1OxYshtpxkiD+kGbXMUIjBOA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fiMGaSdwi8CrmbPKBdzCI3wWPztvyWNa9svQfeECg48=; b=l63O/Frs6sUHOQMDiruV35Uw/W7t5PkTHpxYuoJrh2VsJ39qRwtFF1lggK3zCG7WUqLV+PCiAPSvzbf88z+c066OV4LeO4SfDicopXQyOthKshNUBxq6ItBgez3VwnVY+AfXLwIOQMKlY9b2wh5RvU5NBKq76+09MsWiUOlHfsc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9185.eurprd04.prod.outlook.com (2603:10a6:102:231::11) by AS8PR04MB8676.eurprd04.prod.outlook.com (2603:10a6:20b:42b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7719.29; Wed, 3 Jul 2024 16:33:01 +0000 Received: from PAXPR04MB9185.eurprd04.prod.outlook.com ([fe80::21bf:975e:f24d:1612]) by PAXPR04MB9185.eurprd04.prod.outlook.com ([fe80::21bf:975e:f24d:1612%2]) with mapi id 15.20.7698.025; Wed, 3 Jul 2024 16:33:01 +0000 From: Shenwei Wang To: Thomas Gleixner , Shawn Guo , Sascha Hauer Cc: Pengutronix Kernel Team , Fabio Estevam , linux-kernel@vger.kernel.org, imx@lists.linux.dev, linux-imx@nxp.com, Shenwei Wang Subject: [PATCH] irqchip/imx-irqsteer: Add irq_bus_lock/sync_unlock handlers Date: Wed, 3 Jul 2024 11:32:50 -0500 Message-Id: <20240703163250.47887-1-shenwei.wang@nxp.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: SJ0PR03CA0071.namprd03.prod.outlook.com (2603:10b6:a03:331::16) To PAXPR04MB9185.eurprd04.prod.outlook.com (2603:10a6:102:231::11) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9185:EE_|AS8PR04MB8676:EE_ X-MS-Office365-Filtering-Correlation-Id: 88e48531-021c-4db6-685d-08dc9b7dce13 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|52116014|1800799024|366016|38350700014; X-Microsoft-Antispam-Message-Info: uPOohj3JHFDIZyvU0HElcRBpv4yUoeTM5sMKx+WxreDLLjADAgpnQlaShQov/T+jdjNVDH81hpzujerN3odRd/kT/vvD98BSk6/oDIINZOnsLCSpUqcNj3sTANJl4bZxHIhTqF6+k72aGMMQoyWHRj5tVbT2mre9YIlzljCHrmb4lm7X2w6D1gl/fiD87T6JgBLfJTbF1QRiKcj576JoNR2AqnOYTNJggHYIOmbfh5vkb87e7+TUfy76lFXMdNBQ2QpU+29+U4HeO2xD9t0s5zUQBaVxSiaq+SAGw6NKqWTtnGOgF9hI/+cBEW4riV3FmSwwOtv1SqyXeKrP0N1cJ71qAoLc5Nj3yakUaEs9MWi29Snz1MIRpOO3+EKIwfvhGbrSOxboaDttY3+yDwQ2pMfAl/WebCqznCxk6whEEvIt5sVJei2eApiK2XySnNN1nIsSlRDBtR/dYF4yWQH8Auq3EH/WxYscwkegxUb7+RQ5eFODTZLsavzcuaRsEMXldRN3/DPdB0yUXaDlZwgqD1XMU7Swi1jNujF0Hls9MoIWfbcfymiIoXDDuD7uvYadi9hrjqbBhPzhnsR3FcAqQkGlOuPS5TM0W2/eppOBBBi42B7VU2eowejxSr7PCGyEiWazr0INfdyY/iqMmgm58hCuYVGMnDGzIKm16EH1SY3+m+KTqvX8jzJ8Ra1ZajTyH3XOx8olq+o2SrfF6K0fSmFR9HDuCVJ1+cbYakKE3y6AzT2ozWhmATd+uWtpUVu8ICWh7j+G32+a7NwnbEak4u7BtkjNoTrp2eIflMKqlh+agLaseh1bWSRhJzZRALeNG4XhTR8Zb+fqGiGVi+2t/QrQ7iCe9nPlKHYCjksxMmxIMl7H40dKyXvguvgXHP/4AAYXsItROfmAXUD+aB5l5uWJjAJwZTW9H0eFX86PswciOgdnfJ+EMzawpoLxITTS7/Y05V2hSTrTXglmwJfMxnXoaMcRGrT3S056d9VidECfiO3mPr83uEa3Dx58cUaeljiQtqJtNgm0anHPLwspdE0iSecBzZJjaBGLvVWqpgCscMUJwidvqYXb1muuJA5dFWMueWgMWsEj7SPQwSvIEG4vRyk7cFjEbj4Q43qtDKPVSQXXR68ZiCE1pGrjlLUeVyYjpek2XwML6Eqg5jWgKugZxUCYwiCo+WSdB8jLxFkXnPSoFheHBNpxekR5f0snpFailb/9Z5WUQzYsLnt//vI47c33zfS1MRPDMjY2dMCpKhDjjYGO//yLsnJwpqEyuySyA5l7jwJOmlcsI0TveWoPkqnrvFbnDz/d+YIiaxHjcZrTpuioRrQ1k3aUBcdupTLJ3JscTr/uvKfIY0AZDpcmGJqRuFgkPa24Eow62vIw6A1WzXK2GSxH+LoIJ7JbfQpy8kX3lwYHhR/QWXAmIw== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9185.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(52116014)(1800799024)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: ThQ+NKcp/ZdAgCge06KPMWyI5iEgDCb/14fIXLuCbnoecvVn1CM05Jha8iS0CFaZgT4QMUiXWzmt6qq/mZYDq9TmhCwqe0LStWsXIUJYgBkHanKK+0Hxhq1k8LI4tv4UusMZaJtmPOnpuOjfP9AvEP89ia8o9B6SCyvBCM6h+JFohFvYvrdU2LygGDLNTO4U95XIxLtpCjo0R4/sUU7dCxDPrSH63JF5mBiv6Eh5A/QUjJPcM5aU1ojCfusl2faSui2k+IomuAs76O8hr6sUBDoawC3q51DmeEnfIa96ivmLhnQtrGOem7hXuRREjCn2qvl7rMbDWMJukykIUhe7rJ4B0m3kNRDa4GmtWfnZAI+qxUFEzQVutNPjY4UQp+MM8k4LpM3rBm8T86EkDFeT0PFKkPUt1Xl5uGFxst1WeNdwRPHQ69KGN66ocdg87O8W3JrhQ9MMeQigtru4pNzvGBNYhfTTE+t+EHMpQeNNIfHhFjvmPOh/bGQ66gLw8MxX80ELBrlLv7JJLL/IQ5eQnn4OVUbxBky8ZPqyxHtn4Jgn9FwmKRW9aX3gno6Lc6xIDKTmCoxzgghgtfw2xJNuXElJfna82pJ1z+4Ztf7/z9EdMnCTmFBFGfJI88znH5SC3wj9GvhTdLGV4sCb74MZdMH/8jN0s2LKS+DiX47WMasF+n7Z7TSPAn42HMzecUas1muWSd90LKhqMesPEvk7V+xOPqiT/2Mg7eJzxA470K50a8mSiS5fEVUCPZCrJVWT0FiNt5CxosZ17UNLUVoXy4zXYN9rtDRdY02yL4Dy+w8ZfkILPwzzikK0GjrBxnpTiiKpB2WPj7h/B8abQo+18YPDf80btfseHGMa4URjUCGMi1OOBU0Yer6e0OnYP5SzO+slQXQ0NkeGYviz3OcDf3xXmF7RsMJOa6X43cJolhAGEF5okIE7B+X0ZxLoXeZIZMl4S/T2f4T4F+PMx5ojzahC8qfMAWk8IxTWvj6qywg/iO/zcA4H770pgqkwj9QEZ6jZX6fBDy/2MV23u/qBYQyncpV0yH0g3MFPwM16y7jtPv5cOkjpCzQ4zIArAfyM83Tzf46oVWZDBZ9T0H+nMPz95yXr+vMi3c+9x6bxlTuofgL2OF/jnKNJWRPw1lAX1CtN7wFjIc2UQnbpCqORvk/niyBRUAPP8/56KKNH7nlclTLhXNt/vuvusKey+7oqwL0rR5uHFGVH7zIiYYO6q5Z0uEbxQK2ZwwiszZNcK3bvxYx17xTBQyDdNLSlbaESWbnpabXZ2b4SVGQ4V8G3kUcQOFkR83XTkwDnezczamUXG6iT3gb3IX1MAiSqPE1i2bZLsPAqBTDi5eq0kdvJ+NljDyHpyv3U5gDchv1bbPq7nRyKUUPMC6EPlbJfQ4azDAQ24IEfoa3xhSpm4lmbjvsOkfyNMJevdllgDUFkSNgcZyyoutAaYQmNXwdkVV6vpROW9g1P2rPZTcOMqp98fN4nlTvzOAEAEqjgovbPaiJawCTSWLEOYPDDaqQ0c86JR1K03GvN6rc43IODcZw8IjTm8hGihSWyagZcAOCLhWM0Bmh2C38nvOGKTdWm92ms X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 88e48531-021c-4db6-685d-08dc9b7dce13 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9185.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jul 2024 16:33:01.3042 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: OUNNy58FfxLHjgCfww8YVPrwTuxKbA7GM4lqOg7XAI43VXsagghroYecmMYt+A31N/4UdR770/Cf5GrwsdAvhg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8676 Add irq_bus_lock/sync_unlock handlers. Without these handlers, the power domain is automatically activated during clk_prepare. However, on certain platforms like i.MX8QM and i.MX8QXP, the power-on phase may involve sleep function calls, which can lead to random system dumps during driver probes at system boot. By adding these handlers, the actual power-on actions are moved to occur before clk_prepare, thus resolving the system dump issue. The following is the example of system dump on i.MX8QM MEK. [ 3.135799] BUG: scheduling while atomic: kworker/u13:1/48/0x00000002 [ 3.142270] Modules linked in: [ 3.145349] CPU: 0 PID: 48 Comm: kworker/u13:1 Not tainted 6.6.3-lts-next-g5a913c7fc95d #1 [ 3.153616] Hardware name: Freescale i.MX8QM MEK (DT) [ 3.158678] Workqueue: events_unbound deferred_probe_work_func [ 3.164529] Call trace: [ 3.166981] dump_backtrace+0x90/0xe8 [ 3.170652] show_stack+0x18/0x24 [ 3.173971] dump_stack_lvl+0x48/0x60 [ 3.177644] dump_stack+0x18/0x24 [ 3.180964] __schedule_bug+0x54/0x6c [ 3.184628] __schedule+0x7f0/0xa94 [ 3.188121] schedule+0x5c/0xc4 [ 3.191266] schedule_preempt_disabled+0x24/0x40 [ 3.195887] __mutex_lock.constprop.0+0x2c0/0x540 [ 3.200596] __mutex_lock_slowpath+0x14/0x20 [ 3.204870] mutex_lock+0x48/0x54 [ 3.208189] clk_prepare_lock+0x44/0xa0 [ 3.212040] clk_prepare+0x20/0x44 [ 3.215452] imx_irqsteer_resume+0x28/0xe0 [ 3.219552] pm_generic_runtime_resume+0x2c/0x44 [ 3.224174] __genpd_runtime_resume+0x30/0x80 [ 3.228535] genpd_runtime_resume+0xc8/0x2c0 [ 3.232809] __rpm_callback+0x48/0x1d8 [ 3.236562] rpm_callback+0x6c/0x78 [ 3.240055] rpm_resume+0x490/0x6b4 [ 3.243549] __pm_runtime_resume+0x50/0x94 [ 3.247648] irq_chip_pm_get+0x2c/0xa0 [ 3.251401] __irq_do_set_handler+0x178/0x24c [ 3.255762] irq_set_chained_handler_and_data+0x60/0xa4 [ 3.260992] mxc_gpio_probe+0x160/0x4b0 [ 3.264840] platform_probe+0x68/0xc8 [ 3.268506] really_probe+0x148/0x2b0 [ 3.272172] __driver_probe_device+0x78/0x12c [ 3.276536] driver_probe_device+0xd8/0x15c [ 3.280721] __device_attach_driver+0xb8/0x134 [ 3.285169] bus_for_each_drv+0x88/0xe8 [ 3.289009] __device_attach+0xa0/0x190 [ 3.292849] device_initial_probe+0x14/0x20 [ 3.297036] bus_probe_device+0xac/0xb0 [ 3.300876] deferred_probe_work_func+0x80/0xb8 [ 3.305411] process_one_work+0x138/0x248 [ 3.309427] worker_thread+0x320/0x438 [ 3.313177] kthread+0x110/0x114 [ 3.316409] ret_from_fork+0x10/0x20 Signed-off-by: Shenwei Wang --- drivers/irqchip/irq-imx-irqsteer.c | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/drivers/irqchip/irq-imx-irqsteer.c b/drivers/irqchip/irq-imx-irqsteer.c index 20cf7a9e9ece..f81e4ff3aec3 100644 --- a/drivers/irqchip/irq-imx-irqsteer.c +++ b/drivers/irqchip/irq-imx-irqsteer.c @@ -36,6 +36,7 @@ struct irqsteer_data { int channel; struct irq_domain *domain; u32 *saved_reg; + struct device *dev; }; static int imx_irqsteer_get_reg_index(struct irqsteer_data *data, @@ -72,10 +73,26 @@ static void imx_irqsteer_irq_mask(struct irq_data *d) raw_spin_unlock_irqrestore(&data->lock, flags); } +static void imx_irqsteer_irq_bus_lock(struct irq_data *d) +{ + struct irqsteer_data *data = d->chip_data; + + pm_runtime_get_sync(data->dev); +} + +static void imx_irqsteer_irq_bus_sync_unlock(struct irq_data *d) +{ + struct irqsteer_data *data = d->chip_data; + + pm_runtime_put_autosuspend(data->dev); +} + static const struct irq_chip imx_irqsteer_irq_chip = { .name = "irqsteer", .irq_mask = imx_irqsteer_irq_mask, .irq_unmask = imx_irqsteer_irq_unmask, + .irq_bus_lock = imx_irqsteer_irq_bus_lock, + .irq_bus_sync_unlock = imx_irqsteer_irq_bus_sync_unlock, }; static int imx_irqsteer_irq_map(struct irq_domain *h, unsigned int irq, @@ -150,6 +167,7 @@ static int imx_irqsteer_probe(struct platform_device *pdev) if (!data) return -ENOMEM; + data->dev = &pdev->dev; data->regs = devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(data->regs)) { dev_err(&pdev->dev, "failed to initialize reg\n");