| Message ID | 20240722-imx-se-if-v6-2-ee26a87b824a@nxp.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | v6: firmware: imx: driver for NXP secure-enclave | expand |
On Mon, Jul 22, 2024 at 10:21:37AM +0530, Pankaj Gupta wrote: > The NXP security hardware IP(s) like: i.MX EdgeLock Enclave, V2X etc., > creates an embedded secure enclave within the SoC boundary to enable > features like: > - HSM > - SHE > - V2X > > Secure-Enclave(s) communication interface are typically via message > unit, i.e., based on mailbox linux kernel driver. This driver enables > communication ensuring well defined message sequence protocol between > Application Core and enclave's firmware. > > Driver configures multiple misc-device on the MU, for multiple > user-space applications, to be able to communicate over single MU. > > It exists on some i.MX processors. e.g. i.MX8ULP, i.MX93 etc. > > Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com> > --- > .../devicetree/bindings/firmware/fsl,imx-se.yaml | 91 ++++++++++++++++++++++ > 1 file changed, 91 insertions(+) > > diff --git a/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml b/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml > new file mode 100644 > index 000000000000..7511d0e9cf98 > --- /dev/null > +++ b/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml > @@ -0,0 +1,91 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/firmware/fsl,imx-se.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP i.MX HW Secure Enclave(s) EdgeLock Enclave > + > +maintainers: > + - Pankaj Gupta <pankaj.gupta@nxp.com> > + > +description: | > + NXP's SoC may contain one or multiple embedded secure-enclave HW > + IP(s) like i.MX EdgeLock Enclave, V2X etc. These NXP's HW IP(s) > + enables features like > + - Hardware Security Module (HSM), > + - Security Hardware Extension (SHE), and > + - Vehicular to Anything (V2X) > + > + Communication interface to the secure-enclaves(se) is based on the > + messaging unit(s). > + > +properties: > + compatible: > + enum: > + - fsl,imx8ulp-se > + - fsl,imx93-se > + - fsl,imx95-se > + > + mboxes: > + items: > + - description: mailbox phandle to send message to se firmware > + - description: mailbox phandle to receive message from se firmware > + > + mbox-names: > + items: > + - const: tx > + - const: rx > + > + memory-region: > + maxItems: 1 > + > + sram: > + maxItems: 1 > + > +required: > + - compatible > + - mboxes > + - mbox-names > + > +allOf: > + # memory-region > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx8ulp-se > + - fsl,imx93-se > + then: > + required: > + - memory-region > + else: > + properties: > + memory-region: false > + > + # sram > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx8ulp-se > + then: > + required: > + - sram > + > + else: > + properties: > + sram: false > + > +additionalProperties: false > + > +examples: > + - | > + senclave-firmware { Last revision this was "firmware", but now you've got something that appears non-generic. Why did you change it? The normal differentiator for multiple nodes is -[0-9]*, why can't you use that, if you're worried about multiple nodes? > + compatible = "fsl,imx95-se"; > + mboxes = <&ele_mu0 0 0>, <&ele_mu0 1 0>; > + mbox-names = "tx", "rx"; > + }; > +... > > -- > 2.34.1 >
> -----Original Message----- > From: Conor Dooley <conor@kernel.org> > Sent: Monday, July 22, 2024 10:20 PM > To: Pankaj Gupta <pankaj.gupta@nxp.com> > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring <robh@kernel.org>; > Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley > <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Sascha Hauer > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Rob > Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; linux- > kernel@vger.kernel.org; devicetree@vger.kernel.org; imx@lists.linux.dev; > linux-arm-kernel@lists.infradead.org > Subject: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: add imx-se-fw binding > doc > > On Mon, Jul 22, 2024 at 10:21:37AM +0530, Pankaj Gupta wrote: > > The NXP security hardware IP(s) like: i.MX EdgeLock Enclave, V2X etc., > > creates an embedded secure enclave within the SoC boundary to enable > > features like: > > - HSM > > - SHE > > - V2X > > > > Secure-Enclave(s) communication interface are typically via message > > unit, i.e., based on mailbox linux kernel driver. This driver enables > > communication ensuring well defined message sequence protocol between > > Application Core and enclave's firmware. > > > > Driver configures multiple misc-device on the MU, for multiple > > user-space applications, to be able to communicate over single MU. > > > > It exists on some i.MX processors. e.g. i.MX8ULP, i.MX93 etc. > > > > Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com> > > --- > > .../devicetree/bindings/firmware/fsl,imx-se.yaml | 91 > ++++++++++++++++++++++ > > 1 file changed, 91 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml > > b/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml > > new file mode 100644 > > index 000000000000..7511d0e9cf98 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml > > @@ -0,0 +1,91 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/firmware/fsl,imx-se.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: NXP i.MX HW Secure Enclave(s) EdgeLock Enclave > > + > > +maintainers: > > + - Pankaj Gupta <pankaj.gupta@nxp.com> > > + > > +description: | > > + NXP's SoC may contain one or multiple embedded secure-enclave HW > > + IP(s) like i.MX EdgeLock Enclave, V2X etc. These NXP's HW IP(s) > > + enables features like > > + - Hardware Security Module (HSM), > > + - Security Hardware Extension (SHE), and > > + - Vehicular to Anything (V2X) > > + > > + Communication interface to the secure-enclaves(se) is based on the > > + messaging unit(s). > > + > > +properties: > > + compatible: > > + enum: > > + - fsl,imx8ulp-se > > + - fsl,imx93-se > > + - fsl,imx95-se > > + > > + mboxes: > > + items: > > + - description: mailbox phandle to send message to se firmware > > + - description: mailbox phandle to receive message from se > > + firmware > > + > > + mbox-names: > > + items: > > + - const: tx > > + - const: rx > > + > > + memory-region: > > + maxItems: 1 > > + > > + sram: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - mboxes > > + - mbox-names > > + > > +allOf: > > + # memory-region > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - fsl,imx8ulp-se > > + - fsl,imx93-se > > + then: > > + required: > > + - memory-region > > + else: > > + properties: > > + memory-region: false > > + > > + # sram > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - fsl,imx8ulp-se > > + then: > > + required: > > + - sram > > + > > + else: > > + properties: > > + sram: false > > + > > +additionalProperties: false > > + > > +examples: > > + - | > > + senclave-firmware { > > Last revision this was "firmware", but now you've got something that appears > non-generic. Why did you change it? In case you missed, there was a previous email requesting your view on this change. Having node as "firmware {", is very generic that has wide interpretation. Hence, replaced firmware with "senclave-firmware". Why "senclave"? Like sram, for secure RAM, I proposed senclave for secure enclave. Moreover, there are plenty of examples of YAML(s), that were already committed; that are using this: linux_bkp$:> find Documentation/ -name "*.yaml" | xargs grep -r "\-firmware {" Documentation/devicetree/bindings/crypto/xlnx,zynqmp-aes.yaml: zynqmp_firmware: zynqmp-firmware { Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.yaml: zynqmp_firmware: zynqmp-firmware { Documentation/devicetree/bindings/gpio/xlnx,zynqmp-gpio-modepin.yaml: zynqmp-firmware { And more... If you any other suggested word to pre-fix , that narrows down this broad referenced word "firmware". Please suggest. > The normal differentiator for multiple > nodes is -[0-9]*, why can't you use that, if you're worried about multiple > nodes? Thanks Conor, for the suggestion this. Will use this. Thanks. > > > + compatible = "fsl,imx95-se"; > > + mboxes = <&ele_mu0 0 0>, <&ele_mu0 1 0>; > > + mbox-names = "tx", "rx"; > > + }; > > +... > > > > -- > > 2.34.1 > >
On Tue, Jul 23, 2024 at 09:28:31AM +0000, Pankaj Gupta wrote: > > > -----Original Message----- > > From: Conor Dooley <conor@kernel.org> > > Sent: Monday, July 22, 2024 10:20 PM > > To: Pankaj Gupta <pankaj.gupta@nxp.com> > > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring <robh@kernel.org>; > > Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley > > <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Sascha Hauer > > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Rob > > Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; linux- > > kernel@vger.kernel.org; devicetree@vger.kernel.org; imx@lists.linux.dev; > > linux-arm-kernel@lists.infradead.org > > Subject: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: add imx-se-fw binding > > doc Please fix this ^ > > > > On Mon, Jul 22, 2024 at 10:21:37AM +0530, Pankaj Gupta wrote: > > > The NXP security hardware IP(s) like: i.MX EdgeLock Enclave, V2X etc., > > > creates an embedded secure enclave within the SoC boundary to enable > > > features like: > > > - HSM > > > - SHE > > > - V2X > > > > > > Secure-Enclave(s) communication interface are typically via message > > > unit, i.e., based on mailbox linux kernel driver. This driver enables > > > communication ensuring well defined message sequence protocol between > > > Application Core and enclave's firmware. > > > > > > Driver configures multiple misc-device on the MU, for multiple > > > user-space applications, to be able to communicate over single MU. > > > > > > It exists on some i.MX processors. e.g. i.MX8ULP, i.MX93 etc. > > > > > > Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com> > > > --- > > > .../devicetree/bindings/firmware/fsl,imx-se.yaml | 91 > > ++++++++++++++++++++++ > > > 1 file changed, 91 insertions(+) > > > > > > diff --git > > > a/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml > > > b/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml > > > new file mode 100644 > > > index 000000000000..7511d0e9cf98 > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml > > > @@ -0,0 +1,91 @@ > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/firmware/fsl,imx-se.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: NXP i.MX HW Secure Enclave(s) EdgeLock Enclave > > > + > > > +maintainers: > > > + - Pankaj Gupta <pankaj.gupta@nxp.com> > > > + > > > +description: | > > > + NXP's SoC may contain one or multiple embedded secure-enclave HW > > > + IP(s) like i.MX EdgeLock Enclave, V2X etc. These NXP's HW IP(s) > > > + enables features like > > > + - Hardware Security Module (HSM), > > > + - Security Hardware Extension (SHE), and > > > + - Vehicular to Anything (V2X) > > > + > > > + Communication interface to the secure-enclaves(se) is based on the > > > + messaging unit(s). > > > + > > > +properties: > > > + compatible: > > > + enum: > > > + - fsl,imx8ulp-se > > > + - fsl,imx93-se > > > + - fsl,imx95-se > > > + > > > + mboxes: > > > + items: > > > + - description: mailbox phandle to send message to se firmware > > > + - description: mailbox phandle to receive message from se > > > + firmware > > > + > > > + mbox-names: > > > + items: > > > + - const: tx > > > + - const: rx > > > + > > > + memory-region: > > > + maxItems: 1 > > > + > > > + sram: > > > + maxItems: 1 > > > + > > > +required: > > > + - compatible > > > + - mboxes > > > + - mbox-names > > > + > > > +allOf: > > > + # memory-region > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + enum: > > > + - fsl,imx8ulp-se > > > + - fsl,imx93-se > > > + then: > > > + required: > > > + - memory-region > > > + else: > > > + properties: > > > + memory-region: false > > > + > > > + # sram > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + enum: > > > + - fsl,imx8ulp-se > > > + then: > > > + required: > > > + - sram > > > + > > > + else: > > > + properties: > > > + sram: false > > > + > > > +additionalProperties: false > > > + > > > +examples: > > > + - | > > > + senclave-firmware { > > > > Last revision this was "firmware", but now you've got something that appears > > non-generic. Why did you change it? > > In case you missed, there was a previous email requesting your view on this change. > Having node as "firmware {", is very generic that has wide interpretation. > Hence, replaced firmware with "senclave-firmware". Which I came across after reading the updated series. If you ask me for my opinion on something, just wait til I reply to you before sending another version. > Why "senclave"? > Like sram, for secure RAM, I proposed senclave for secure enclave. > > > Moreover, there are plenty of examples of YAML(s), that were already committed; that are using this: > linux_bkp$:> find Documentation/ -name "*.yaml" | xargs grep -r "\-firmware {" Just because something got in before doesn't mean it should now. > Documentation/devicetree/bindings/crypto/xlnx,zynqmp-aes.yaml: zynqmp_firmware: zynqmp-firmware { > Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.yaml: zynqmp_firmware: zynqmp-firmware { > Documentation/devicetree/bindings/gpio/xlnx,zynqmp-gpio-modepin.yaml: zynqmp-firmware { > And more... > > If you any other suggested word to pre-fix , that narrows down this broad referenced word "firmware". > Please suggest. I already did: > > The normal differentiator for multiple > > nodes is -[0-9]*, why can't you use that, if you're worried about multiple > > nodes? > Thanks Conor, for the suggestion this. Will use this. Thanks.
> -----Original Message----- > From: Conor Dooley <conor@kernel.org> > Sent: Tuesday, July 23, 2024 7:38 PM > To: Pankaj Gupta <pankaj.gupta@nxp.com> > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring <robh@kernel.org>; > Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley > <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Sascha Hauer > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Rob > Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; linux- > kernel@vger.kernel.org; devicetree@vger.kernel.org; imx@lists.linux.dev; > linux-arm-kernel@lists.infradead.org > Subject: Re: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: add imx-se-fw > binding doc > > On Tue, Jul 23, 2024 at 09:28:31AM +0000, Pankaj Gupta wrote: > > > > > -----Original Message----- > > > From: Conor Dooley <conor@kernel.org> > > > Sent: Monday, July 22, 2024 10:20 PM > > > To: Pankaj Gupta <pankaj.gupta@nxp.com> > > > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring <robh@kernel.org>; > > > Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley > > > <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Sascha > Hauer > > > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > > > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Rob > > > Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; linux- > > > kernel@vger.kernel.org; devicetree@vger.kernel.org; > > > imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org > > > Subject: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: add > > > imx-se-fw binding doc > > Please fix this ^ > > > > > > > On Mon, Jul 22, 2024 at 10:21:37AM +0530, Pankaj Gupta wrote: > > > > The NXP security hardware IP(s) like: i.MX EdgeLock Enclave, V2X > > > > etc., creates an embedded secure enclave within the SoC boundary > > > > to enable features like: > > > > - HSM > > > > - SHE > > > > - V2X > > > > > > > > Secure-Enclave(s) communication interface are typically via > > > > message unit, i.e., based on mailbox linux kernel driver. This > > > > driver enables communication ensuring well defined message > > > > sequence protocol between Application Core and enclave's firmware. > > > > > > > > Driver configures multiple misc-device on the MU, for multiple > > > > user-space applications, to be able to communicate over single MU. > > > > > > > > It exists on some i.MX processors. e.g. i.MX8ULP, i.MX93 etc. > > > > > > > > Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com> > > > > --- > > > > .../devicetree/bindings/firmware/fsl,imx-se.yaml | 91 > > > ++++++++++++++++++++++ > > > > 1 file changed, 91 insertions(+) > > > > > > > > diff --git > > > > a/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml > > > > b/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml > > > > new file mode 100644 > > > > index 000000000000..7511d0e9cf98 > > > > --- /dev/null > > > > +++ b/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml > > > > @@ -0,0 +1,91 @@ > > > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) %YAML > > > > +1.2 > > > > +--- > > > > +$id: http://devicetree.org/schemas/firmware/fsl,imx-se.yaml# > > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > > + > > > > +title: NXP i.MX HW Secure Enclave(s) EdgeLock Enclave > > > > + > > > > +maintainers: > > > > + - Pankaj Gupta <pankaj.gupta@nxp.com> > > > > + > > > > +description: | > > > > + NXP's SoC may contain one or multiple embedded secure-enclave > > > > +HW > > > > + IP(s) like i.MX EdgeLock Enclave, V2X etc. These NXP's HW IP(s) > > > > + enables features like > > > > + - Hardware Security Module (HSM), > > > > + - Security Hardware Extension (SHE), and > > > > + - Vehicular to Anything (V2X) > > > > + > > > > + Communication interface to the secure-enclaves(se) is based on > > > > + the messaging unit(s). > > > > + > > > > +properties: > > > > + compatible: > > > > + enum: > > > > + - fsl,imx8ulp-se > > > > + - fsl,imx93-se > > > > + - fsl,imx95-se > > > > + > > > > + mboxes: > > > > + items: > > > > + - description: mailbox phandle to send message to se firmware > > > > + - description: mailbox phandle to receive message from se > > > > + firmware > > > > + > > > > + mbox-names: > > > > + items: > > > > + - const: tx > > > > + - const: rx > > > > + > > > > + memory-region: > > > > + maxItems: 1 > > > > + > > > > + sram: > > > > + maxItems: 1 > > > > + > > > > +required: > > > > + - compatible > > > > + - mboxes > > > > + - mbox-names > > > > + > > > > +allOf: > > > > + # memory-region > > > > + - if: > > > > + properties: > > > > + compatible: > > > > + contains: > > > > + enum: > > > > + - fsl,imx8ulp-se > > > > + - fsl,imx93-se > > > > + then: > > > > + required: > > > > + - memory-region > > > > + else: > > > > + properties: > > > > + memory-region: false > > > > + > > > > + # sram > > > > + - if: > > > > + properties: > > > > + compatible: > > > > + contains: > > > > + enum: > > > > + - fsl,imx8ulp-se > > > > + then: > > > > + required: > > > > + - sram > > > > + > > > > + else: > > > > + properties: > > > > + sram: false > > > > + > > > > +additionalProperties: false > > > > + > > > > +examples: > > > > + - | > > > > + senclave-firmware { > > > > > > Last revision this was "firmware", but now you've got something that > > > appears non-generic. Why did you change it? > > > > In case you missed, there was a previous email requesting your view on this > change. > > Having node as "firmware {", is very generic that has wide interpretation. > > Hence, replaced firmware with "senclave-firmware". > > Which I came across after reading the updated series. If you ask me for my > opinion on something, just wait til I reply to you before sending another > version. Sure, will ensure that in future. > > > Why "senclave"? > > Like sram, for secure RAM, I proposed senclave for secure enclave. > > > > > > Moreover, there are plenty of examples of YAML(s), that were already > committed; that are using this: > > linux_bkp$:> find Documentation/ -name "*.yaml" | xargs grep -r "\- > firmware {" > > Just because something got in before doesn't mean it should now. > Ok, understood. > > Documentation/devicetree/bindings/crypto/xlnx,zynqmp-aes.yaml: > zynqmp_firmware: zynqmp-firmware { > > Documentation/devicetree/bindings/fpga/xlnx,zynqmp-pcap-fpga.yaml: > zynqmp_firmware: zynqmp-firmware { > > Documentation/devicetree/bindings/gpio/xlnx,zynqmp-gpio-modepin.yaml: > zynqmp-firmware { > > And more... > > > > If you any other suggested word to pre-fix , that narrows down this broad > referenced word "firmware". > > > Please suggest. > > I already did: In case of imx8ulp, there is a single node. Having a same node name for both parent and child, is bit strange. firmware { firmware { }; }; Request you to allow to re-evaluate this point. Thanks. > > > The normal differentiator for multiple nodes is -[0-9]*, why can't > > > you use that, if you're worried about multiple nodes? > > Thanks Conor, for the suggestion this. Will use this. Thanks.
On Wed, Jul 24, 2024 at 11:02:21AM +0000, Pankaj Gupta wrote: > > > > -----Original Message----- > > From: Conor Dooley <conor@kernel.org> > > Sent: Tuesday, July 23, 2024 7:38 PM > > To: Pankaj Gupta <pankaj.gupta@nxp.com> > > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring <robh@kernel.org>; > > Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley > > <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Sascha Hauer > > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Rob > > Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; linux- > > kernel@vger.kernel.org; devicetree@vger.kernel.org; imx@lists.linux.dev; > > linux-arm-kernel@lists.infradead.org > > Subject: Re: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: add imx-se-fw > > binding doc Please fix this ^ > > On Tue, Jul 23, 2024 at 09:28:31AM +0000, Pankaj Gupta wrote: > > > > > > > -----Original Message----- > > > > From: Conor Dooley <conor@kernel.org> > > > > Sent: Monday, July 22, 2024 10:20 PM > > > > To: Pankaj Gupta <pankaj.gupta@nxp.com> > > > > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring <robh@kernel.org>; > > > > Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley > > > > <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Sascha > > Hauer > > > > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > > > > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Rob > > > > Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; linux- > > > > kernel@vger.kernel.org; devicetree@vger.kernel.org; > > > > imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org > > > > Subject: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: add > > > > imx-se-fw binding doc > > > > Please fix this ^ > > > > > > > > > > On Mon, Jul 22, 2024 at 10:21:37AM +0530, Pankaj Gupta wrote: > In case of imx8ulp, there is a single node. > Having a same node name for both parent and child, is bit strange. > firmware { > firmware { > }; > }; > > Request you to allow to re-evaluate this point. I dunno, it's all firmware so I don't really get why it is so strange! Can you remind me again why it is inside a parent node to begin with?
> -----Original Message----- > From: Conor Dooley <conor@kernel.org> > Sent: Wednesday, July 24, 2024 9:00 PM > To: Pankaj Gupta <pankaj.gupta@nxp.com> > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring <robh@kernel.org>; > Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley > <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Sascha Hauer > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Rob > Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; linux- > kernel@vger.kernel.org; devicetree@vger.kernel.org; imx@lists.linux.dev; > linux-arm-kernel@lists.infradead.org > Subject: Re: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: add imx-se-fw > binding doc > > On Wed, Jul 24, 2024 at 11:02:21AM +0000, Pankaj Gupta wrote: > > > > > > > -----Original Message----- > > > From: Conor Dooley <conor@kernel.org> > > > Sent: Tuesday, July 23, 2024 7:38 PM > > > To: Pankaj Gupta <pankaj.gupta@nxp.com> > > > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring <robh@kernel.org>; > > > Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley > > > <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Sascha > Hauer > > > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > > > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Rob > > > Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; linux- > > > kernel@vger.kernel.org; devicetree@vger.kernel.org; > > > imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org > > > Subject: Re: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: add > > > imx-se-fw binding doc > > Please fix this ^ > > > > On Tue, Jul 23, 2024 at 09:28:31AM +0000, Pankaj Gupta wrote: > > > > > > > > > -----Original Message----- > > > > > From: Conor Dooley <conor@kernel.org> > > > > > Sent: Monday, July 22, 2024 10:20 PM > > > > > To: Pankaj Gupta <pankaj.gupta@nxp.com> > > > > > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring > > > > > <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; > > > > > Conor Dooley <conor+dt@kernel.org>; Shawn Guo > > > > > <shawnguo@kernel.org>; Sascha > > > Hauer > > > > > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > > > > > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Rob > > > > > Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; linux- > > > > > kernel@vger.kernel.org; devicetree@vger.kernel.org; > > > > > imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org > > > > > Subject: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: add > > > > > imx-se-fw binding doc > > > > > > Please fix this ^ > > > > > > > > > > > > > On Mon, Jul 22, 2024 at 10:21:37AM +0530, Pankaj Gupta wrote: > > In case of imx8ulp, there is a single node. > > Having a same node name for both parent and child, is bit strange. > > firmware { > > firmware { > > }; > > }; > > > > Request you to allow to re-evaluate this point. > > I dunno, it's all firmware so I don't really get why it is so strange! > Can you remind me again why it is inside a parent node to begin with? Three type of security firmware(s): HSM, V2X-SHE, V2X-HSM, are running at the cores dedicated to the each different secure-enclave hardware IP(s). Each firmware receives the message to act and response back with the completed act. This message exchanges happens through the Message-Unit hardware interface. There could be multiple MU for multiple security firmware, that would be used for respective message exchanges. This node defines the details of each such MU interface. Reason to put under firmware: Since this node specifies interface details between kernel and firmware, it was put under parent "firmware {". I am not sure if this reason is correct enough to begin with. Thanks for allowing to revisit. I will make the change to whatever you finalize now. Thanks.
On Thu, Jul 25, 2024 at 07:06:30AM +0000, Pankaj Gupta wrote: > > > > -----Original Message----- > > From: Conor Dooley <conor@kernel.org> > > Sent: Wednesday, July 24, 2024 9:00 PM > > To: Pankaj Gupta <pankaj.gupta@nxp.com> > > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring <robh@kernel.org>; > > Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley > > <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Sascha Hauer > > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Rob > > Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; linux- > > kernel@vger.kernel.org; devicetree@vger.kernel.org; imx@lists.linux.dev; > > linux-arm-kernel@lists.infradead.org > > Subject: Re: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: add imx-se-fw > > binding doc For the third time, please fix your mail client so it stops inserting this garbage. > > > > On Wed, Jul 24, 2024 at 11:02:21AM +0000, Pankaj Gupta wrote: > > > > > > > > > > -----Original Message----- > > > > From: Conor Dooley <conor@kernel.org> > > > > Sent: Tuesday, July 23, 2024 7:38 PM > > > > To: Pankaj Gupta <pankaj.gupta@nxp.com> > > > > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring <robh@kernel.org>; > > > > Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley > > > > <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Sascha > > Hauer > > > > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > > > > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Rob > > > > Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; linux- > > > > kernel@vger.kernel.org; devicetree@vger.kernel.org; > > > > imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org > > > > Subject: Re: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: add > > > > imx-se-fw binding doc > > > > Please fix this ^ > > > > > > On Tue, Jul 23, 2024 at 09:28:31AM +0000, Pankaj Gupta wrote: > > > > > > > > > > > -----Original Message----- > > > > > > From: Conor Dooley <conor@kernel.org> > > > > > > Sent: Monday, July 22, 2024 10:20 PM > > > > > > To: Pankaj Gupta <pankaj.gupta@nxp.com> > > > > > > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring > > > > > > <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; > > > > > > Conor Dooley <conor+dt@kernel.org>; Shawn Guo > > > > > > <shawnguo@kernel.org>; Sascha > > > > Hauer > > > > > > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > > > > > > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Rob > > > > > > Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; linux- > > > > > > kernel@vger.kernel.org; devicetree@vger.kernel.org; > > > > > > imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org > > > > > > Subject: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: add > > > > > > imx-se-fw binding doc > > > > > > > > Please fix this ^ > > > > > > > > > > > > > > > > On Mon, Jul 22, 2024 at 10:21:37AM +0530, Pankaj Gupta wrote: > > > In case of imx8ulp, there is a single node. > > > Having a same node name for both parent and child, is bit strange. > > > firmware { > > > firmware { > > > }; > > > }; > > > > > > Request you to allow to re-evaluate this point. > > > > I dunno, it's all firmware so I don't really get why it is so strange! > > Can you remind me again why it is inside a parent node to begin with? > > Three type of security firmware(s): HSM, V2X-SHE, V2X-HSM, are running at the cores dedicated to the each different secure-enclave hardware IP(s). > Each firmware receives the message to act and response back with the completed act. > This message exchanges happens through the Message-Unit hardware interface. > There could be multiple MU for multiple security firmware, that would be used for respective message exchanges. > > This node defines the details of each such MU interface. > > Reason to put under firmware: > Since this node specifies interface details between kernel and firmware, it was put under parent "firmware {". > I am not sure if this reason is correct enough to begin with. > > Thanks for allowing to revisit. > > I will make the change to whatever you finalize now. Thanks. I'm sorry, I still don't understand why you have the parent node. It seems pointless to me, and this new node could be added at the top level.
> -----Original Message----- > From: Conor Dooley <conor@kernel.org> > Sent: Thursday, July 25, 2024 8:09 PM > To: Pankaj Gupta <pankaj.gupta@nxp.com> > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring <robh@kernel.org>; > Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley > <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Sascha Hauer > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Rob > Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; linux- > kernel@vger.kernel.org; devicetree@vger.kernel.org; imx@lists.linux.dev; > linux-arm-kernel@lists.infradead.org > Subject: Re: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: add imx-se-fw > binding doc > > On Thu, Jul 25, 2024 at 07:06:30AM +0000, Pankaj Gupta wrote: > > > > > > > -----Original Message----- > > > From: Conor Dooley <conor@kernel.org> > > > Sent: Wednesday, July 24, 2024 9:00 PM > > > To: Pankaj Gupta <pankaj.gupta@nxp.com> > > > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring <robh@kernel.org>; > > > Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley > > > <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Sascha > Hauer > > > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > > > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Rob > > > Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; linux- > > > kernel@vger.kernel.org; devicetree@vger.kernel.org; > > > imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org > > > Subject: Re: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: add > > > imx-se-fw binding doc > > For the third time, please fix your mail client so it stops inserting this garbage. > > > > > > > On Wed, Jul 24, 2024 at 11:02:21AM +0000, Pankaj Gupta wrote: > > > > > > > > > > > > > -----Original Message----- > > > > > From: Conor Dooley <conor@kernel.org> > > > > > Sent: Tuesday, July 23, 2024 7:38 PM > > > > > To: Pankaj Gupta <pankaj.gupta@nxp.com> > > > > > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring > > > > > <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; > > > > > Conor Dooley <conor+dt@kernel.org>; Shawn Guo > > > > > <shawnguo@kernel.org>; Sascha > > > Hauer > > > > > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > > > > > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; > Rob > > > > > Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; linux- > > > > > kernel@vger.kernel.org; devicetree@vger.kernel.org; > > > > > imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org > > > > > Subject: Re: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: add > > > > > imx-se-fw binding doc > > > > > > Please fix this ^ > > > > > > > > On Tue, Jul 23, 2024 at 09:28:31AM +0000, Pankaj Gupta wrote: > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Conor Dooley <conor@kernel.org> > > > > > > > Sent: Monday, July 22, 2024 10:20 PM > > > > > > > To: Pankaj Gupta <pankaj.gupta@nxp.com> > > > > > > > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring > > > > > > > <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; > > > > > > > Conor Dooley <conor+dt@kernel.org>; Shawn Guo > > > > > > > <shawnguo@kernel.org>; Sascha > > > > > Hauer > > > > > > > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > > > > > > > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; > > > > > > > Rob Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; > > > > > > > linux- kernel@vger.kernel.org; devicetree@vger.kernel.org; > > > > > > > imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org > > > > > > > Subject: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: add > > > > > > > imx-se-fw binding doc > > > > > > > > > > Please fix this ^ > > > > > > > > > > > > > > > > > > > On Mon, Jul 22, 2024 at 10:21:37AM +0530, Pankaj Gupta wrote: > > > > In case of imx8ulp, there is a single node. > > > > Having a same node name for both parent and child, is bit strange. > > > > firmware { > > > > firmware { > > > > }; > > > > }; > > > > > > > > Request you to allow to re-evaluate this point. > > > > > > I dunno, it's all firmware so I don't really get why it is so strange! > > > Can you remind me again why it is inside a parent node to begin with? > > > > Three type of security firmware(s): HSM, V2X-SHE, V2X-HSM, are running at > the cores dedicated to the each different secure-enclave hardware IP(s). > > Each firmware receives the message to act and response back with the > completed act. > > This message exchanges happens through the Message-Unit hardware > interface. > > There could be multiple MU for multiple security firmware, that would be > used for respective message exchanges. > > > > This node defines the details of each such MU interface. > > > > Reason to put under firmware: > > Since this node specifies interface details between kernel and > firmware, it was put under parent "firmware {". > > I am not sure if this reason is correct enough to begin with. > > > > Thanks for allowing to revisit. > > > > I will make the change to whatever you finalize now. Thanks. > > I'm sorry, I still don't understand why you have the parent node. It seems > pointless to me, and this new node could be added at the top level. Lately, I got this feedback in NXP internal as well. Accepted. Will add it at the top level. Thanks. Help with the suggestion for the node name: 1. enclave-interface For multiple nodes, it will be: enclave-interface-0 enclave-interface-1 enclave-interface-2 2. secure-enclave For multiple nodes, it will be: secure-enclave-0 secure-enclave-1 secure-enclave-3 Or share any other suggested word(s). Thanks.
> -----Original Message----- > From: Pankaj Gupta > Sent: Friday, July 26, 2024 6:06 PM > To: Conor Dooley <conor@kernel.org> > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring <robh@kernel.org>; > Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley > <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Sascha Hauer > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Rob > Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; linux- > kernel@vger.kernel.org; devicetree@vger.kernel.org; imx@lists.linux.dev; > linux-arm-kernel@lists.infradead.org > Subject: RE: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: add imx-se-fw > binding doc > > > > > -----Original Message----- > > From: Conor Dooley <conor@kernel.org> > > Sent: Thursday, July 25, 2024 8:09 PM > > To: Pankaj Gupta <pankaj.gupta@nxp.com> > > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring <robh@kernel.org>; > > Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley > > <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Sascha Hauer > > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Rob > > Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; linux- > > kernel@vger.kernel.org; devicetree@vger.kernel.org; > > imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org > > Subject: Re: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: add > > imx-se-fw binding doc > > > > On Thu, Jul 25, 2024 at 07:06:30AM +0000, Pankaj Gupta wrote: > > > > > > > > > > -----Original Message----- > > > > From: Conor Dooley <conor@kernel.org> > > > > Sent: Wednesday, July 24, 2024 9:00 PM > > > > To: Pankaj Gupta <pankaj.gupta@nxp.com> > > > > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring > > > > <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor > > > > Dooley <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; > > > > Sascha > > Hauer > > > > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > > > > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Rob > > > > Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; linux- > > > > kernel@vger.kernel.org; devicetree@vger.kernel.org; > > > > imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org > > > > Subject: Re: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: add > > > > imx-se-fw binding doc > > > > For the third time, please fix your mail client so it stops inserting this garbage. > > > > > > > > > > On Wed, Jul 24, 2024 at 11:02:21AM +0000, Pankaj Gupta wrote: > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > From: Conor Dooley <conor@kernel.org> > > > > > > Sent: Tuesday, July 23, 2024 7:38 PM > > > > > > To: Pankaj Gupta <pankaj.gupta@nxp.com> > > > > > > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring > > > > > > <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; > > > > > > Conor Dooley <conor+dt@kernel.org>; Shawn Guo > > > > > > <shawnguo@kernel.org>; Sascha > > > > Hauer > > > > > > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > > > > > > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; > > Rob > > > > > > Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; > > > > > > linux- kernel@vger.kernel.org; devicetree@vger.kernel.org; > > > > > > imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org > > > > > > Subject: Re: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: > > > > > > add imx-se-fw binding doc > > > > > > > > Please fix this ^ > > > > > > > > > > On Tue, Jul 23, 2024 at 09:28:31AM +0000, Pankaj Gupta wrote: > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > From: Conor Dooley <conor@kernel.org> > > > > > > > > Sent: Monday, July 22, 2024 10:20 PM > > > > > > > > To: Pankaj Gupta <pankaj.gupta@nxp.com> > > > > > > > > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring > > > > > > > > <robh@kernel.org>; Krzysztof Kozlowski > > > > > > > > <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; > > > > > > > > Shawn Guo <shawnguo@kernel.org>; Sascha > > > > > > Hauer > > > > > > > > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > > > > > > > > <kernel@pengutronix.de>; Fabio Estevam > > > > > > > > <festevam@gmail.com>; Rob Herring <robh+dt@kernel.org>; > > > > > > > > linux-doc@vger.kernel.org; > > > > > > > > linux- kernel@vger.kernel.org; devicetree@vger.kernel.org; > > > > > > > > imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org > > > > > > > > Subject: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: > > > > > > > > add imx-se-fw binding doc > > > > > > > > > > > > Please fix this ^ > > > > > > > > > > > > > > > > > > > > > > On Mon, Jul 22, 2024 at 10:21:37AM +0530, Pankaj Gupta wrote: > > > > > In case of imx8ulp, there is a single node. > > > > > Having a same node name for both parent and child, is bit strange. > > > > > firmware { > > > > > firmware { > > > > > }; > > > > > }; > > > > > > > > > > Request you to allow to re-evaluate this point. > > > > > > > > I dunno, it's all firmware so I don't really get why it is so strange! > > > > Can you remind me again why it is inside a parent node to begin with? > > > > > > Three type of security firmware(s): HSM, V2X-SHE, V2X-HSM, are > > > running at > > the cores dedicated to the each different secure-enclave hardware IP(s). > > > Each firmware receives the message to act and response back with the > > completed act. > > > This message exchanges happens through the Message-Unit hardware > > interface. > > > There could be multiple MU for multiple security firmware, that > > > would be > > used for respective message exchanges. > > > > > > This node defines the details of each such MU interface. > > > > > > Reason to put under firmware: > > > Since this node specifies interface details between kernel and > > firmware, it was put under parent "firmware {". > > > I am not sure if this reason is correct enough to begin with. > > > > > > Thanks for allowing to revisit. > > > > > > I will make the change to whatever you finalize now. Thanks. > > > > I'm sorry, I still don't understand why you have the parent node. It > > seems pointless to me, and this new node could be added at the top level. > Lately, I got this feedback in NXP internal as well. > > Accepted. Will add it at the top level. > Thanks. > > Help with the suggestion for the node name: > 1. enclave-interface > For multiple nodes, it will be: > enclave-interface-0 > enclave-interface-1 > enclave-interface-2 > 2. secure-enclave > For multiple nodes, it will be: > secure-enclave-0 > secure-enclave-1 > secure-enclave-3 > > Or share any other suggested word(s). > Thanks. Will use "secure-enclave" as the node name, in the v7 patch. Will post the V7 patch-set, by end of the next week. Please reply if anyone think otherwise. Thanks.
On Thu, Aug 01, 2024 at 08:52:48AM +0000, Pankaj Gupta wrote: > > > > -----Original Message----- > > From: Pankaj Gupta > > Sent: Friday, July 26, 2024 6:06 PM > > To: Conor Dooley <conor@kernel.org> > > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring <robh@kernel.org>; > > Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley > > <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Sascha Hauer > > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Rob > > Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; linux- > > kernel@vger.kernel.org; devicetree@vger.kernel.org; imx@lists.linux.dev; > > linux-arm-kernel@lists.infradead.org > > Subject: RE: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: add imx-se-fw > > binding doc Every single mail I am pointing out your broken mail client, and every single time you both ignore me and fail to fix it. Fix it. > > > -----Original Message----- > > > From: Conor Dooley <conor@kernel.org> > > > Sent: Thursday, July 25, 2024 8:09 PM > > > To: Pankaj Gupta <pankaj.gupta@nxp.com> > > > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring <robh@kernel.org>; > > > Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor Dooley > > > <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Sascha Hauer > > > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > > > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Rob > > > Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; linux- > > > kernel@vger.kernel.org; devicetree@vger.kernel.org; > > > imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org > > > Subject: Re: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: add > > > imx-se-fw binding doc > > > > > > On Thu, Jul 25, 2024 at 07:06:30AM +0000, Pankaj Gupta wrote: > > > > > > > > > > > > > -----Original Message----- > > > > > From: Conor Dooley <conor@kernel.org> > > > > > Sent: Wednesday, July 24, 2024 9:00 PM > > > > > To: Pankaj Gupta <pankaj.gupta@nxp.com> > > > > > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring > > > > > <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor > > > > > Dooley <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; > > > > > Sascha > > > Hauer > > > > > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > > > > > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; Rob > > > > > Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; linux- > > > > > kernel@vger.kernel.org; devicetree@vger.kernel.org; > > > > > imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org > > > > > Subject: Re: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: add > > > > > imx-se-fw binding doc > > > > > > For the third time, please fix your mail client so it stops inserting this garbage. > > > > > > > > > > > > > On Wed, Jul 24, 2024 at 11:02:21AM +0000, Pankaj Gupta wrote: > > > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Conor Dooley <conor@kernel.org> > > > > > > > Sent: Tuesday, July 23, 2024 7:38 PM > > > > > > > To: Pankaj Gupta <pankaj.gupta@nxp.com> > > > > > > > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring > > > > > > > <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; > > > > > > > Conor Dooley <conor+dt@kernel.org>; Shawn Guo > > > > > > > <shawnguo@kernel.org>; Sascha > > > > > Hauer > > > > > > > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > > > > > > > <kernel@pengutronix.de>; Fabio Estevam <festevam@gmail.com>; > > > Rob > > > > > > > Herring <robh+dt@kernel.org>; linux-doc@vger.kernel.org; > > > > > > > linux- kernel@vger.kernel.org; devicetree@vger.kernel.org; > > > > > > > imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org > > > > > > > Subject: Re: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: > > > > > > > add imx-se-fw binding doc > > > > > > > > > > Please fix this ^ > > > > > > > > > > > > On Tue, Jul 23, 2024 at 09:28:31AM +0000, Pankaj Gupta wrote: > > > > > > > > > > > > > > > > > -----Original Message----- > > > > > > > > > From: Conor Dooley <conor@kernel.org> > > > > > > > > > Sent: Monday, July 22, 2024 10:20 PM > > > > > > > > > To: Pankaj Gupta <pankaj.gupta@nxp.com> > > > > > > > > > Cc: Jonathan Corbet <corbet@lwn.net>; Rob Herring > > > > > > > > > <robh@kernel.org>; Krzysztof Kozlowski > > > > > > > > > <krzk+dt@kernel.org>; Conor Dooley <conor+dt@kernel.org>; > > > > > > > > > Shawn Guo <shawnguo@kernel.org>; Sascha > > > > > > > Hauer > > > > > > > > > <s.hauer@pengutronix.de>; Pengutronix Kernel Team > > > > > > > > > <kernel@pengutronix.de>; Fabio Estevam > > > > > > > > > <festevam@gmail.com>; Rob Herring <robh+dt@kernel.org>; > > > > > > > > > linux-doc@vger.kernel.org; > > > > > > > > > linux- kernel@vger.kernel.org; devicetree@vger.kernel.org; > > > > > > > > > imx@lists.linux.dev; linux-arm-kernel@lists.infradead.org > > > > > > > > > Subject: [EXT] Re: [PATCH v6 2/5] dt-bindings: arm: fsl: > > > > > > > > > add imx-se-fw binding doc > > > > > > > > > > > > > > Please fix this ^ > Will use "secure-enclave" as the node name, in the v7 patch. > Will post the V7 patch-set, by end of the next week. > > Please reply if anyone think otherwise. Sure, go for it :+1: And please actually read the comments I have left on every mail about your mail client being broken. I don't want to see 20 lines of to and cc lists on every response :(
diff --git a/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml b/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml new file mode 100644 index 000000000000..7511d0e9cf98 --- /dev/null +++ b/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml @@ -0,0 +1,91 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/firmware/fsl,imx-se.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: NXP i.MX HW Secure Enclave(s) EdgeLock Enclave + +maintainers: + - Pankaj Gupta <pankaj.gupta@nxp.com> + +description: | + NXP's SoC may contain one or multiple embedded secure-enclave HW + IP(s) like i.MX EdgeLock Enclave, V2X etc. These NXP's HW IP(s) + enables features like + - Hardware Security Module (HSM), + - Security Hardware Extension (SHE), and + - Vehicular to Anything (V2X) + + Communication interface to the secure-enclaves(se) is based on the + messaging unit(s). + +properties: + compatible: + enum: + - fsl,imx8ulp-se + - fsl,imx93-se + - fsl,imx95-se + + mboxes: + items: + - description: mailbox phandle to send message to se firmware + - description: mailbox phandle to receive message from se firmware + + mbox-names: + items: + - const: tx + - const: rx + + memory-region: + maxItems: 1 + + sram: + maxItems: 1 + +required: + - compatible + - mboxes + - mbox-names + +allOf: + # memory-region + - if: + properties: + compatible: + contains: + enum: + - fsl,imx8ulp-se + - fsl,imx93-se + then: + required: + - memory-region + else: + properties: + memory-region: false + + # sram + - if: + properties: + compatible: + contains: + enum: + - fsl,imx8ulp-se + then: + required: + - sram + + else: + properties: + sram: false + +additionalProperties: false + +examples: + - | + senclave-firmware { + compatible = "fsl,imx95-se"; + mboxes = <&ele_mu0 0 0>, <&ele_mu0 1 0>; + mbox-names = "tx", "rx"; + }; +...
The NXP security hardware IP(s) like: i.MX EdgeLock Enclave, V2X etc., creates an embedded secure enclave within the SoC boundary to enable features like: - HSM - SHE - V2X Secure-Enclave(s) communication interface are typically via message unit, i.e., based on mailbox linux kernel driver. This driver enables communication ensuring well defined message sequence protocol between Application Core and enclave's firmware. Driver configures multiple misc-device on the MU, for multiple user-space applications, to be able to communicate over single MU. It exists on some i.MX processors. e.g. i.MX8ULP, i.MX93 etc. Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com> --- .../devicetree/bindings/firmware/fsl,imx-se.yaml | 91 ++++++++++++++++++++++ 1 file changed, 91 insertions(+)