diff mbox series

arm64: dts: imx8mp-verdin: drop limit to sdio wi-fi frequency to 100 mhz

Message ID 20240805174814.1944742-1-jpaulo.silvagoncalves@gmail.com (mailing list archive)
State In Next, archived
Headers show
Series arm64: dts: imx8mp-verdin: drop limit to sdio wi-fi frequency to 100 mhz | expand

Commit Message

João Paulo Gonçalves Aug. 5, 2024, 5:48 p.m. UTC
From: Marcel Ziswiler <marcel.ziswiler@toradex.com>

SDIO frequency was limited to workaround some instabilities, however it
turned out that the instability had nothing to do with the speed but was
because of an issue with the USDHC IP that was fixed in
commit 52e4c32baed2 ("mmc: sdhci-esdhc-imx: only enable DAT[0] and CMD line
auto tuning for SDIO device").

Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Signed-off-by: João Paulo Gonçalves <joao.goncalves@toradex.com>
---
 arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

Peng Fan Aug. 8, 2024, 2:59 a.m. UTC | #1
> Subject: [PATCH] arm64: dts: imx8mp-verdin: drop limit to sdio wi-fi
> frequency to 100 mhz
> 
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> SDIO frequency was limited to workaround some instabilities, however
> it turned out that the instability had nothing to do with the speed but
> was because of an issue with the USDHC IP that was fixed in commit
> 52e4c32baed2 ("mmc: sdhci-esdhc-imx: only enable DAT[0] and CMD
> line auto tuning for SDIO device").
> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Signed-off-by: João Paulo Gonçalves <joao.goncalves@toradex.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi.dtsi
> index efcab00c0142..cae06cb67cd3 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi.dtsi
> @@ -75,7 +75,6 @@ bluetooth {
>  &usdhc1 {
>  	bus-width = <4>;
>  	keep-power-in-suspend;
> -	max-frequency = <100000000>;
>  	non-removable;
>  	pinctrl-names = "default", "state_100mhz", "state_200mhz";
>  	pinctrl-0 = <&pinctrl_usdhc1>, <&pinctrl_wifi_ctrl>;
> --
> 2.34.1
> 
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Shawn Guo Aug. 13, 2024, 3:25 a.m. UTC | #2
On Mon, Aug 05, 2024 at 02:48:14PM -0300, João Paulo Gonçalves wrote:
> From: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> 
> SDIO frequency was limited to workaround some instabilities, however it
> turned out that the instability had nothing to do with the speed but was
> because of an issue with the USDHC IP that was fixed in
> commit 52e4c32baed2 ("mmc: sdhci-esdhc-imx: only enable DAT[0] and CMD line
> auto tuning for SDIO device").
> 
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> Signed-off-by: João Paulo Gonçalves <joao.goncalves@toradex.com>

Applied, thanks!
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi.dtsi b/arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi.dtsi
index efcab00c0142..cae06cb67cd3 100644
--- a/arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mp-verdin-wifi.dtsi
@@ -75,7 +75,6 @@  bluetooth {
 &usdhc1 {
 	bus-width = <4>;
 	keep-power-in-suspend;
-	max-frequency = <100000000>;
 	non-removable;
 	pinctrl-names = "default", "state_100mhz", "state_200mhz";
 	pinctrl-0 = <&pinctrl_usdhc1>, <&pinctrl_wifi_ctrl>;