| Message ID | 20240812193626.3826250-1-Frank.Li@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/1] dt-bindings: display: panel-simple-lvds-dual-ports: use unevaluatedProperties | expand |
On 08/13/2024, Frank Li wrote: > Replace additionalProperties with unevaluatedProperties because it ref to > panel-common.yaml. This would allow all properties in panel-common.yaml, which is not expected. Isn't adding 'panel-timing: true' next to 'enable-gpios: true' enough? > > Remove properties (backlight, enable-gpios and power-supply), which defined > in panel-common.yaml. > > Fix below warning: > arch/arm64/boot/dts/freescale/imx8mp-evk-mx8-dlvds-lcd1.dtb: panel-lvds: 'panel-timing' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/display/panel/panel-simple-lvds-dual-ports.yaml# > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > .../display/panel/panel-simple-lvds-dual-ports.yaml | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml > index e78160d1aa24c..10ed4b57232b9 100644 > --- a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml > @@ -84,11 +84,7 @@ properties: > - port@0 > - port@1 > > - backlight: true > - enable-gpios: true > - power-supply: true > - > -additionalProperties: false > +unevaluatedProperties: false > > required: > - compatible
On Tue, Aug 13, 2024 at 10:32:04AM +0800, Liu Ying wrote: > On 08/13/2024, Frank Li wrote: > > Replace additionalProperties with unevaluatedProperties because it ref to > > panel-common.yaml. > > This would allow all properties in panel-common.yaml, which is not expected. > Isn't adding 'panel-timing: true' next to 'enable-gpios: true' enough? Strange, you ref to panel-common.yaml, suppose it will use all common preperties. Krzysztof Kozlowski: Can I just add panel-timing:true for this case? Frank > > > > > Remove properties (backlight, enable-gpios and power-supply), which defined > > in panel-common.yaml. > > > > Fix below warning: > > arch/arm64/boot/dts/freescale/imx8mp-evk-mx8-dlvds-lcd1.dtb: panel-lvds: 'panel-timing' does not match any of the regexes: 'pinctrl-[0-9]+' > > from schema $id: http://devicetree.org/schemas/display/panel/panel-simple-lvds-dual-ports.yaml# > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > .../display/panel/panel-simple-lvds-dual-ports.yaml | 6 +----- > > 1 file changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml > > index e78160d1aa24c..10ed4b57232b9 100644 > > --- a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml > > +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml > > @@ -84,11 +84,7 @@ properties: > > - port@0 > > - port@1 > > > > - backlight: true > > - enable-gpios: true > > - power-supply: true > > - > > -additionalProperties: false > > +unevaluatedProperties: false > > > > required: > > - compatible > > -- > Regards, > Liu Ying >
On 13/08/2024 05:44, Frank Li wrote: > On Tue, Aug 13, 2024 at 10:32:04AM +0800, Liu Ying wrote: >> On 08/13/2024, Frank Li wrote: >>> Replace additionalProperties with unevaluatedProperties because it ref to >>> panel-common.yaml. >> >> This would allow all properties in panel-common.yaml, which is not expected. >> Isn't adding 'panel-timing: true' next to 'enable-gpios: true' enough? > > Strange, you ref to panel-common.yaml, suppose it will use all common > preperties. > > Krzysztof Kozlowski: > > Can I just add panel-timing:true for this case? Yes, although I would claim that most of the panel-common schema also applies here... Best regards, Krzysztof
On Mon, Aug 12, 2024 at 03:36:26PM -0400, Frank Li wrote: > Replace additionalProperties with unevaluatedProperties because it ref to > panel-common.yaml. > > Remove properties (backlight, enable-gpios and power-supply), which defined > in panel-common.yaml. > > Fix below warning: > arch/arm64/boot/dts/freescale/imx8mp-evk-mx8-dlvds-lcd1.dtb: panel-lvds: 'panel-timing' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/display/panel/panel-simple-lvds-dual-ports.yaml# > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > .../display/panel/panel-simple-lvds-dual-ports.yaml | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) Actually, I prefer doing it this way. Applied. Rob
diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml index e78160d1aa24c..10ed4b57232b9 100644 --- a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml @@ -84,11 +84,7 @@ properties: - port@0 - port@1 - backlight: true - enable-gpios: true - power-supply: true - -additionalProperties: false +unevaluatedProperties: false required: - compatible
Replace additionalProperties with unevaluatedProperties because it ref to panel-common.yaml. Remove properties (backlight, enable-gpios and power-supply), which defined in panel-common.yaml. Fix below warning: arch/arm64/boot/dts/freescale/imx8mp-evk-mx8-dlvds-lcd1.dtb: panel-lvds: 'panel-timing' does not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/display/panel/panel-simple-lvds-dual-ports.yaml# Signed-off-by: Frank Li <Frank.Li@nxp.com> --- .../display/panel/panel-simple-lvds-dual-ports.yaml | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)