diff mbox series

[v2,1/1] dt-bindings: display: panel-simple-lvds-dual-ports: add panel-timing: true

Message ID 20240813145021.3864787-1-Frank.Li@nxp.com (mailing list archive)
State Superseded
Headers show
Series [v2,1/1] dt-bindings: display: panel-simple-lvds-dual-ports: add panel-timing: true | expand

Commit Message

Frank Li Aug. 13, 2024, 2:50 p.m. UTC
Add property panel-timing: true to allow use 'panel-timing', which defined
in panel-common.yaml.

Fix below warning:
arch/arm64/boot/dts/freescale/imx8mp-evk-mx8-dlvds-lcd1.dtb: panel-lvds: 'panel-timing' does not match any of the regexes: 'pinctrl-[0-9]+'
        from schema $id: http://devicetree.org/schemas/display/panel/panel-simple-lvds-dual-ports.yaml#

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Change from v1 to v2
- add panel-timing instead of change to unevaluatedProperties
---
 .../bindings/display/panel/panel-simple-lvds-dual-ports.yaml     | 1 +
 1 file changed, 1 insertion(+)

Comments

Liu Ying Aug. 14, 2024, 7:12 a.m. UTC | #1
On 08/13/2024, Frank Li wrote:
> Add property panel-timing: true to allow use 'panel-timing', which defined
> in panel-common.yaml.
> 
> Fix below warning:
> arch/arm64/boot/dts/freescale/imx8mp-evk-mx8-dlvds-lcd1.dtb: panel-lvds: 'panel-timing' does not match any of the regexes: 'pinctrl-[0-9]+'
>         from schema $id: http://devicetree.org/schemas/display/panel/panel-simple-lvds-dual-ports.yaml#
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Change from v1 to v2
> - add panel-timing instead of change to unevaluatedProperties
> ---
>  .../bindings/display/panel/panel-simple-lvds-dual-ports.yaml     | 1 +
>  1 file changed, 1 insertion(+)

You may add:
Suggested-by: Liu Ying <victor.liu@nxp.com>

> 
> diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
> index e78160d1aa24c..1f3222d532787 100644
> --- a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
> +++ b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
> @@ -87,6 +87,7 @@ properties:
>    backlight: true
>    enable-gpios: true
>    power-supply: true
> +  panel-timing: true

Nit: As I mentioned in v1 comment, this can be put next to
'enable-gpios: true' to sort the referenced properties
alphabetically, like panel-dpi.yaml does.

>  
>  additionalProperties: false
>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
index e78160d1aa24c..1f3222d532787 100644
--- a/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
+++ b/Documentation/devicetree/bindings/display/panel/panel-simple-lvds-dual-ports.yaml
@@ -87,6 +87,7 @@  properties:
   backlight: true
   enable-gpios: true
   power-supply: true
+  panel-timing: true
 
 additionalProperties: false