| Message ID | 20240815141609.4089406-1-Frank.Li@nxp.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v2,1/1] MAINTAINERS: I3C: Add Frank Li as nxp I3C controller driver maintainer | expand |
On Thu, Aug 15, 2024 at 10:16:09AM -0400, Frank Li wrote: > Add Frank Li as NXP i3c controller driver as maintainer and add mail list > imx@lists.linux.dev for it. > > Add Frank Li as I3C subsystem reviewer. > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- Miquel: Any comments? Frank > Change from v1 to v2 > - Added to exist item > > Recently, I submit many i3c related patches and become familiar with i3c > protocol. So add me as svc-i3c-master.c maintainer. > > I reviewed other i3c patches. So add me as i3c subsystem reviewer. > --- > MAINTAINERS | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index 2b96899a78890..077e37eb018ce 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -10708,6 +10708,7 @@ F: drivers/i3c/master/dw* > > I3C SUBSYSTEM > M: Alexandre Belloni <alexandre.belloni@bootlin.com> > +R: Frank Li <Frank.Li@nxp.com> > L: linux-i3c@lists.infradead.org (moderated for non-subscribers) > S: Maintained > C: irc://chat.freenode.net/linux-i3c > @@ -20961,8 +20962,10 @@ F: drivers/video/fbdev/sm712* > > SILVACO I3C DUAL-ROLE MASTER > M: Miquel Raynal <miquel.raynal@bootlin.com> > +M: Frank Li <Frank.Li@nxp.com> > M: Conor Culhane <conor.culhane@silvaco.com> > L: linux-i3c@lists.infradead.org (moderated for non-subscribers) > +L: imx@lists.linux.dev > S: Maintained > F: Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml > F: drivers/i3c/master/svc-i3c-master.c > -- > 2.34.1 >
On Mon, Sep 09, 2024 at 04:05:32PM -0400, Frank Li wrote: > On Thu, Aug 15, 2024 at 10:16:09AM -0400, Frank Li wrote: > > Add Frank Li as NXP i3c controller driver as maintainer and add mail list > > imx@lists.linux.dev for it. > > > > Add Frank Li as I3C subsystem reviewer. > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > Miquel: > Any comments? > > Frank Alex: Almost one month passed, how make this go forward? Frank > > > Change from v1 to v2 > > - Added to exist item > > > > Recently, I submit many i3c related patches and become familiar with i3c > > protocol. So add me as svc-i3c-master.c maintainer. > > > > I reviewed other i3c patches. So add me as i3c subsystem reviewer. > > --- > > MAINTAINERS | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 2b96899a78890..077e37eb018ce 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -10708,6 +10708,7 @@ F: drivers/i3c/master/dw* > > > > I3C SUBSYSTEM > > M: Alexandre Belloni <alexandre.belloni@bootlin.com> > > +R: Frank Li <Frank.Li@nxp.com> > > L: linux-i3c@lists.infradead.org (moderated for non-subscribers) > > S: Maintained > > C: irc://chat.freenode.net/linux-i3c > > @@ -20961,8 +20962,10 @@ F: drivers/video/fbdev/sm712* > > > > SILVACO I3C DUAL-ROLE MASTER > > M: Miquel Raynal <miquel.raynal@bootlin.com> > > +M: Frank Li <Frank.Li@nxp.com> > > M: Conor Culhane <conor.culhane@silvaco.com> > > L: linux-i3c@lists.infradead.org (moderated for non-subscribers) > > +L: imx@lists.linux.dev > > S: Maintained > > F: Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml > > F: drivers/i3c/master/svc-i3c-master.c > > -- > > 2.34.1 > >
Hi Frank, Frank.li@nxp.com wrote on Mon, 9 Sep 2024 16:05:32 -0400: > On Thu, Aug 15, 2024 at 10:16:09AM -0400, Frank Li wrote: > > Add Frank Li as NXP i3c controller driver as maintainer and add mail list > > imx@lists.linux.dev for it. > > > > Add Frank Li as I3C subsystem reviewer. > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > Miquel: > Any comments? I guess we'll happily take your feedback on patches targeting the SVC driver, you've been working a lot on it. However, in general there has been a lot of discussions happening on your substantial patchsets and little to no convergence in the end. I understand you want to push your patches upstream and I also want to make things move forward, but maybe one of the reasons for the stalls is the lack of fluent exchanges between us and the difficulty to explain bigger pictures in a clear way. I believe maintaining a subsystem still requires a bit more experience on this regard. Thanks, Miquèl
On Mon, Sep 30, 2024 at 06:22:35PM +0200, Miquel Raynal wrote: > Hi Frank, > > Frank.li@nxp.com wrote on Mon, 9 Sep 2024 16:05:32 -0400: > > > On Thu, Aug 15, 2024 at 10:16:09AM -0400, Frank Li wrote: > > > Add Frank Li as NXP i3c controller driver as maintainer and add mail list > > > imx@lists.linux.dev for it. > > > > > > Add Frank Li as I3C subsystem reviewer. > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > --- > > > > Miquel: > > Any comments? > > I guess we'll happily take your feedback on patches targeting the SVC > driver, you've been working a lot on it. However, in general there has > been a lot of discussions happening on your substantial patchsets and > little to no convergence in the end. I think this can't prevent no any feedback at this thread for more than 1 month. Basic, this patch did two things, one add mail list imx@lists.linux.dev to keep us track all imx related patch in one mail list. generally, we don't check linux-i3c mail list frequently. The other things is add me to maintainer, If you have concern about it. You'd better said as - point to the path to be maintainer, such as do reviewer first for some times. - or simple reject this, I can post the patch, which only add imx@lists.linux.dev. Keep simple, two questions: 1: are you agree on add imx@lists.linux.dev? 2: are you agree on I as reviewer? > I understand you want to push your > patches upstream and I also want to make things move forward, but maybe > one of the reasons for the stalls is the lack of fluent exchanges > between us and the difficulty to explain bigger pictures in a clear > way. I agree on "the lack of fluent exchanges", No any i3c maintainer involve my i3c target support discussion, even just said, it is "not good at all". https://lore.kernel.org/imx/20240507204311.2898714-1-Frank.Li@nxp.com/ I post HCI issue/concern and not any feedback at all. https://lore.kernel.org/linux-i3c/20240819-i3c_fix-v3-0-7d69f7b0a05e@nxp.com/T/#m16fa9bb875b0ae9d37c5f6e91f90e375551c6366 Frank > I believe maintaining a subsystem still requires a bit more > experience on this regard. > > Thanks, > Miquèl
Hi Frank, Frank.li@nxp.com wrote on Mon, 30 Sep 2024 13:08:06 -0400: > On Mon, Sep 30, 2024 at 06:22:35PM +0200, Miquel Raynal wrote: > > Hi Frank, > > > > Frank.li@nxp.com wrote on Mon, 9 Sep 2024 16:05:32 -0400: > > > > > On Thu, Aug 15, 2024 at 10:16:09AM -0400, Frank Li wrote: > > > > Add Frank Li as NXP i3c controller driver as maintainer and add mail list > > > > imx@lists.linux.dev for it. > > > > > > > > Add Frank Li as I3C subsystem reviewer. > > > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > > --- > > > > > > Miquel: > > > Any comments? > > > > I guess we'll happily take your feedback on patches targeting the SVC > > driver, you've been working a lot on it. However, in general there has > > been a lot of discussions happening on your substantial patchsets and > > little to no convergence in the end. > > I think this can't prevent no any feedback at this thread for more than > 1 month. Well, there's been a lot of discussion, then no convergence, that's what I am pointing out as well. You cannot say there has been no discussion. > Basic, this patch did two things, Actually 3, and this is usually too much. > one add mail list imx@lists.linux.dev to > keep us track all imx related patch in one mail list. generally, we don't > check linux-i3c mail list frequently. > > The other things is add me to maintainer, If you have concern about it. > You'd better said as > - point to the path to be maintainer, such as do reviewer first for some > times. > - or simple reject this, I can post the patch, which only add > imx@lists.linux.dev. > > Keep simple, two questions: > 1: are you agree on add imx@lists.linux.dev? > 2: are you agree on I as reviewer? I've already answered these questions and made a difference between reviewing driver changes and core changes. > > I understand you want to push your > > patches upstream and I also want to make things move forward, but maybe > > one of the reasons for the stalls is the lack of fluent exchanges > > between us and the difficulty to explain bigger pictures in a clear > > way. Thanks, Miquèl
On Tue, Oct 01, 2024 at 12:10:27PM +0200, Miquel Raynal wrote: > Hi Frank, > > Frank.li@nxp.com wrote on Mon, 30 Sep 2024 13:08:06 -0400: > > > On Mon, Sep 30, 2024 at 06:22:35PM +0200, Miquel Raynal wrote: > > > Hi Frank, > > > > > > Frank.li@nxp.com wrote on Mon, 9 Sep 2024 16:05:32 -0400: > > > > > > > On Thu, Aug 15, 2024 at 10:16:09AM -0400, Frank Li wrote: > > > > > Add Frank Li as NXP i3c controller driver as maintainer and add mail list > > > > > imx@lists.linux.dev for it. > > > > > > > > > > Add Frank Li as I3C subsystem reviewer. > > > > > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > > > --- > > > > > > > > Miquel: > > > > Any comments? > > > > > > I guess we'll happily take your feedback on patches targeting the SVC > > > driver, you've been working a lot on it. However, in general there has > > > been a lot of discussions happening on your substantial patchsets and > > > little to no convergence in the end. > > > > I think this can't prevent no any feedback at this thread for more than > > 1 month. > > Well, there's been a lot of discussion, then no convergence, that's > what I am pointing out as well. You cannot say there has been no > discussion. Yes, but I can't understand what's that related with this independent thread. and it is fact of no feedback on this thread over 1 months and missed one merge windows. I read your comments again. "I understand you want to push your patches upstream and I also want to make things move forward", I think you mis-understand that I want to be maintainer to make ungoing patch "i3c: master: some fix and improvemnt for hotjoin" go forward. That no convergence patch is i3c common master part, not svc driver part. Even I become svc maintainer, no help for go forward at all. > > > Basic, this patch did two things, > > Actually 3, and this is usually too much. > > > one add mail list imx@lists.linux.dev to > > keep us track all imx related patch in one mail list. generally, we don't > > check linux-i3c mail list frequently. > > > > The other things is add me to maintainer, If you have concern about it. > > You'd better said as > > - point to the path to be maintainer, such as do reviewer first for some > > times. > > - or simple reject this, I can post the patch, which only add > > imx@lists.linux.dev. > > > > Keep simple, two questions: > > 1: are you agree on add imx@lists.linux.dev? > > 2: are you agree on I as reviewer? > > I've already answered these questions and made a difference between > reviewing driver changes and core changes. Can you explicite anwer yes/No for above 2 items, so I rework patches. Frank > > > > I understand you want to push your > > > patches upstream and I also want to make things move forward, but maybe > > > one of the reasons for the stalls is the lack of fluent exchanges > > > between us and the difficulty to explain bigger pictures in a clear > > > way. > > Thanks, > Miquèl > > -- > linux-i3c mailing list > linux-i3c@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-i3c
diff --git a/MAINTAINERS b/MAINTAINERS index 2b96899a78890..077e37eb018ce 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -10708,6 +10708,7 @@ F: drivers/i3c/master/dw* I3C SUBSYSTEM M: Alexandre Belloni <alexandre.belloni@bootlin.com> +R: Frank Li <Frank.Li@nxp.com> L: linux-i3c@lists.infradead.org (moderated for non-subscribers) S: Maintained C: irc://chat.freenode.net/linux-i3c @@ -20961,8 +20962,10 @@ F: drivers/video/fbdev/sm712* SILVACO I3C DUAL-ROLE MASTER M: Miquel Raynal <miquel.raynal@bootlin.com> +M: Frank Li <Frank.Li@nxp.com> M: Conor Culhane <conor.culhane@silvaco.com> L: linux-i3c@lists.infradead.org (moderated for non-subscribers) +L: imx@lists.linux.dev S: Maintained F: Documentation/devicetree/bindings/i3c/silvaco,i3c-master.yaml F: drivers/i3c/master/svc-i3c-master.c
Add Frank Li as NXP i3c controller driver as maintainer and add mail list imx@lists.linux.dev for it. Add Frank Li as I3C subsystem reviewer. Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Change from v1 to v2 - Added to exist item Recently, I submit many i3c related patches and become familiar with i3c protocol. So add me as svc-i3c-master.c maintainer. I reviewed other i3c patches. So add me as i3c subsystem reviewer. --- MAINTAINERS | 3 +++ 1 file changed, 3 insertions(+)