From patchwork Mon Aug 19 16:01:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13768540 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11012037.outbound.protection.outlook.com [52.101.66.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C7922166F2A for ; Mon, 19 Aug 2024 16:02:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.37 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724083337; cv=fail; b=SQaVzriUX1ljtV8N9t542aBkGgZy+8wJblaQIN+g7fWItK1poLlHkFh+5zHb7RSO58oJVgunvfdAxosQfcSy6eSR8RuN+pnLjVOON1yuH7NUJOXTtwmsaZnqatw0C/jWMTk2ROxAdUIyZpj/TH8v/wDyBmpufpxLmnuf9VPtrFo= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724083337; c=relaxed/simple; bh=/JI8s94ok2z+hT6L0BfTNT5ICOc99IOP4jbZmyhmqiE=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=knhSn4pWPJbNQKP2Awf5rczaWQyPbWxGRYPRRweGGPkAbS7ghp2Ym3F3fRkFRfu717m+Cn1zJcTVlmVrB30icd4J6QlTlnlXunlSFAaSHi3QSiO1mUgX6sAC9X8XSR712VVxcZcBMewjiFo5JlsTUA8kdFM6lwTf48WqhQqG9go= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=OIKaA0YL; arc=fail smtp.client-ip=52.101.66.37 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="OIKaA0YL" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=t1ecW37Gb3zLMvvEW1YQfRJ9VEOaKwpnQS0NKrvOBHCerOII16NaKMYsaymDDP6xaZgfJgiuuLpzGnGeaLjt1j0beDqckVrYmVtCByO4TlfrUEKPjK+Hm15KeqmenFfee2g7lgRN2xiH4LeNPt8KVReU+7k/mAcy4yxe4WP2+fMSLuMnCwCIcnlucdqR8lD/gNj6dG/LXnrG3/xiKQ59LsNTi4Wr2JNTEPTn8rcR1p6LylK5dxaYeU6EgLuTMSk3otj8epdEGVTHgdPgXtk9u0dku+eAtHYk4yFkHI6TMoOfJ+Z+ctVPDCzgbxkcp7P2x46aXHLHRKIBAMxMu1BkKQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=iEH3AqOKfHzxwLjQgVs3Ok5rqhSw+ALKLhi5IuDAIjI=; b=yrlT80qdOWzL50NlKeWPjZC+U49vraok5/5hjrkzdkw5qIWHOV1ddWYTGPV3UDkSTX9d8osey5VwdzDPKJXJRQV57yyhnSljp5w3bH+tNwGoAFcum2leBojdizH3D76GFMhbZDMODrdhokytcZMayiJNsFImiQCBea1smfpIdsYZYqWaaqoFjixcfJdvRD9njYGqEUrkTG4qmsjzJ5VFf151ejv4b7Ed3CFCG8BU7AWBWYgeU5VSmcaGPdQUpImxGEEIA7q3d+uHJt/aCmqSsPHgCVbrnBLZUe/88AHmzdL2zFbosOBMOVEZtB9vQpWhyYooLe25juKGDpks3unlzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iEH3AqOKfHzxwLjQgVs3Ok5rqhSw+ALKLhi5IuDAIjI=; b=OIKaA0YLZ3HpleVMFLgmvKJuzsvMEgHyubtKSSl6Kpm22127WlO2xx+O6z341s+orU0kpSnUEIHsjbAZEMTWhKYactUK2yX4hV3hdXpJnZbd5C+nT5kwEpCqnQgup5PR4LMSNzK334uNCZTbZ/zzPqwV74jF3PnqNJ79XleMFOXhlsMfa+MLXfQ+GrkmBu1YhmsRzcmH0IcTyMHIEe64rKa+ZbMidIIpAVBdp/m8bgyCZEbtUWPLKDjEcje3Bn/RbIM3cG0p5zKvtLH4DOz5a9gj5wMkXDauZ/L/JKEjfcxjfpjMEQSIorxzax+D5/hRzX78ywijtrl6WxOEVmynsw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by DU0PR04MB9659.eurprd04.prod.outlook.com (2603:10a6:10:320::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7875.21; Mon, 19 Aug 2024 16:02:10 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%3]) with mapi id 15.20.7875.019; Mon, 19 Aug 2024 16:02:10 +0000 From: Frank Li Date: Mon, 19 Aug 2024 12:01:55 -0400 Subject: [PATCH v3 01/11] i3c: master: Remove i3c_dev_disable_ibi_locked(olddev) on device hotjoin Message-Id: <20240819-i3c_fix-v3-1-7d69f7b0a05e@nxp.com> References: <20240819-i3c_fix-v3-0-7d69f7b0a05e@nxp.com> In-Reply-To: <20240819-i3c_fix-v3-0-7d69f7b0a05e@nxp.com> To: Alexandre Belloni , Boris Brezillon , Parshuram Thombare , Greg Kroah-Hartman , Boris Brezillon , Arnd Bergmann , Miquel Raynal , Conor Culhane Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1724083326; l=1374; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=/JI8s94ok2z+hT6L0BfTNT5ICOc99IOP4jbZmyhmqiE=; b=U8JWV56QJWMg7tHj0mH5hBVpJ2WB54ZuW2LJPI+LWtGmYzVgSThVRW0Ibp8hZnHCAQ6mK1Xu2 41vCFO3ye3PDMzTam1jgN1r0x5OOy6pKWMrOhZRXtoUyeEm4aPZLUNJ X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SA9PR03CA0005.namprd03.prod.outlook.com (2603:10b6:806:20::10) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|DU0PR04MB9659:EE_ X-MS-Office365-Filtering-Correlation-Id: db33ad1e-d352-4141-acfa-08dcc0684885 X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014|7416014|52116014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?SypMKOBM39/ANjzE7zv8V4mz8Q685+t?= =?utf-8?q?5vXm2CRKUKzZLUFZQyHUeMwrboPnSSYP+bfXp9+UX1VvL8WzFFwJMXACxCDQZrvC1?= =?utf-8?q?bo6XMg8hsGQ6Ej6eBJhZyJURDnV/zokucO8xojebfo7b0aADFrrC+uOBoFxRDvQPv?= =?utf-8?q?dc56hXecoCordDZWe4rgtss/6MC0u2tMB3KlWSN/q1e3Vz0S0lGoNCW7zyCHBr7LO?= =?utf-8?q?M2ai+l8VLqoEfjJrS5LKXLDRRHP9Zp5SWInIvDuaeQzUsoeRbGuQ38SW2VwCA5Mqg?= =?utf-8?q?zHfMbNryxNwZlPBz0yOvGeGUjPG5WkVZu5bNlQaUznx/Lco8Sz12qCKBbTGQkN75n?= =?utf-8?q?saoOh3egFWqi/3nqU2TZJlG2ZJYOqkcyEWe+S38RobK19xp0s1sdOBkRRKbdG7qtb?= =?utf-8?q?7HphPokoUQslgucDk9/w/uM4xokbySeA2fYZLr4BB6X+ISeVc4+N6dw/o41o23ijq?= =?utf-8?q?NPsniD6GN5hIaK3UBMwxdOGEovFJSmwcrvfKy0jByr/pU3Sd6GQjjqr3nuaT9rHqQ?= =?utf-8?q?ca4vfpVx29p3BrpQgIkaiDD3paxC1veSz0H0ayp7bdQTwXbwDglP6Gvr9Kpbbbg02?= =?utf-8?q?SM9hZiuh15PMncAmQkLn3E+yu/W/cA9qVr9nQAuLhZaW6RBFGW8v9yPXirzEM+ih7?= =?utf-8?q?J1kiJFMRTeeMzOYKOh8/bmceyY7vNX5Gj6WgBCLEOIzvnk/P3solkFJK+c5nP7nH/?= =?utf-8?q?oXp5O4G6jUrA8IO1jTmGoRrGQCKHG7476LcsIHV/0G8CMWKMWSnit9qra/rxny0Jd?= =?utf-8?q?MHyfOG7mGVpw9AcW4bUShp+1JMXcasgZ4bPwJ/Spar/apBmw9Fbdj8ANt+yW1816u?= =?utf-8?q?MZ+vrx1xdU5VjePgbVvl9wshWs4b5BfErDNAWbznEvRzSUpfIJ771hXztY2ZEoVli?= =?utf-8?q?K4kU+boTcChJLF/Scc974VB50fkoDAgrKF0OwvO+VFAC927xNjf5cFKkeR9ybjeJv?= =?utf-8?q?oxNrzeGPvB3OA6O5LTBIrWuYZqSy/Nleio9QAitN/Ia+nK+1RwsTW76Lp0yJZkV9H?= =?utf-8?q?GElrDgk0dg38FAFHBwNKgvsZ8aqTSDfLzjo1i5ZLV3DnejaBAosBOS4I8uIm11r70?= =?utf-8?q?eK4mmnEhOoN/jnvekvhjTe0ycBORZ4ohFSpdTrd0XQUn0PYWjZyZ4wSBmaM8VHsoP?= =?utf-8?q?y/j/8Mbmz1Igi7ggnDWMlouEfIPyWQ1FmZhg4pD7YCgb4mDnHK3Bo3XyER18Z1mRx?= =?utf-8?q?gXVVcX7/XJQGH3S1QdrMZJeCNt6VlHvthQWiz9/1hwo8pX7peHHXU+tZR3dJWRRPP?= =?utf-8?q?xziT36osIIHP0Y0mGSTaX2KsGP9SAaWAyjhzYUM6SMGBMW1IgKuvN8sj4VF4XSJj6?= =?utf-8?q?6ErAEVR5cWZbX5V+INMTk7ntHT+tbPtdCg=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(376014)(7416014)(52116014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?Ysu+u4xapKD0xdfSVtaSDoaD8sao?= =?utf-8?q?9r7ZYKC5e7B2k1RTj7CMoDrVOm4C1ekv2mrZEFfkoSPyl6J4O0stkYXk+u8APDXfk?= =?utf-8?q?GVOfXvyDQs8VTUNdyN7GnlE6JiGJkH2kZiPjT/Mlcp6zQ7HCZGVDfz5PFF/MB+U1h?= =?utf-8?q?uT3rDVJ6HW5crhrCShAxpe9mlVchoIctthBnUhLTcmnsX978Tgdkip4ck9bxVcfp3?= =?utf-8?q?ro6KaapabuE2pJLBZbrSdQNh32nclEmUnbfZvnZ/PjCqAqnyghoGbBzUY8y6pGqCV?= =?utf-8?q?6hRojLcpM2m6HaFD5tw+vu09RukT3eptUkTrInZBHYCqOWMNZFtFHetcU+sUEHz+r?= =?utf-8?q?4UD3ALGkbqC3XrHNM4agZaY5YNZhmPedStr+/Sp3/mZQPNq5w4hPXGozQeU0jGuoy?= =?utf-8?q?khhWAgrjqgOEF0Rjg8KzTtaCvz7IzVCPHJJHBOpjBqN1S13cpMxOLbk312O5v7JvK?= =?utf-8?q?Z+5uLGlJnGYbwyOPlWEb4v/jMHLu3suKOsmXRGpnsTjCzq4kYQIykeLp9gt+urrij?= =?utf-8?q?qxSYtrv+tYskEPCMgUHqEj6V4+IlP8oOyRNP7YhOhMpBdg8TekBHK5Pm2FF1glLgN?= =?utf-8?q?xxiRyGrOEnXoXZVn7xsO6Dqj4NsZLtbDUjQ8GtfId5yJ3DV1SDwTscXzEEKNkw/Hu?= =?utf-8?q?7MNJNPSn4+nQm7GQwhkt1gSIidfFmQNhCWgoTg9D+Dx0RDHDDAMjY8dimUnycp1/M?= =?utf-8?q?QEgTKZ901b1FsTFeT9n7tx+WdWSy9f2/5VCK9miJolzCJnwyynwqCkUTTVjYEYgsh?= =?utf-8?q?FmZ/oGiFcFGGM7nmHtnxJB2+RvcbyLu6E43eHHXASgeb1fkm8HtswxPfQxTQf66y4?= =?utf-8?q?sqLPto3vYZZgqu80RLLpP6WC8CkxfI6L3MSv/PsBdeR1v5ghxyfLw37Yrh1bi9MXb?= =?utf-8?q?mbRBaiOolkieBTKOgyxL9UIURIrfjay9F37AfjPdsbRBC7Qn+oG14OoeC8sa0/r6C?= =?utf-8?q?MdP3hiV8T/IlOaKb9sDtLetttVtQG1JJLGl9cp+gv7tbRZA5jtV8F9O6nOJ7JyaR7?= =?utf-8?q?xAwybjgxW4PL4m1ldh+BszneAVPg6gSUpvzGNmDsWHBojDMIYeYZ8uaJ52cWgVZPK?= =?utf-8?q?Rs4ickOckNj2n3KZvlcczZpK/tiaPURc1582GgrrCiPLAox8LGyMX4jPBkMIALAic?= =?utf-8?q?bK74CJKu/8jsjNPF+I9TOlEZT42RIQ+QCGarisqVk+yGwyBC8ccJdr84kZtQ7bZ2O?= =?utf-8?q?0Vz4+L2fYPYGXP7FbrM4B9x38ei1BV9fFQsv4lShQw7h7H0wX16F4l83G1Sha/n81?= =?utf-8?q?+mdGeLSDkTm3SRDLv51I9tc/GDlwnMiX7asyg4gLwi2mzPWWJ54+rm4f4QaDvrQe5?= =?utf-8?q?mDH3gliV5n38RB+q9J4Ft4Hpx/Cm2AVAudTKbSeUipyfyC5VhTK4TQqmrVCDJBtm1?= =?utf-8?q?1z7LdwYe8k1Yri9djktTfNizgi3TlhVKv1YhCJik8k+/HigC+z3dJjn9fTneTcx+Q?= =?utf-8?q?wC600acuwV+2SDJsJBg6tq3e+7J6I4MOdKQOWZcyTQL7tofUHDq1Hia0QxbPhWV58?= =?utf-8?q?sRF6k5k2Eggj?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: db33ad1e-d352-4141-acfa-08dcc0684885 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Aug 2024 16:02:10.6829 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GSsGBVJ1w5UfjCUM7gC2LzZGAmn9k8dSZca0T1HiSHLN9ypXhk5O8eVfP0jSPJumy/iDAH0z9udelZnL3lpP6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR04MB9659 When a new device hotjoins, a new dynamic address is assigned. i3c_master_add_i3c_dev_locked() identifies that the device was previously attached to the bus and locates the olddev. i3c_master_add_i3c_dev_locked() { ... olddev = i3c_master_search_i3c_dev_duplicate(newdev); ... if (olddev) { ... i3c_dev_disable_ibi_locked(olddev); ^^^^^^ The olddev should not receive any commands on the i3c bus as it does not exist and has been assigned a new address. This will result in NACK or timeout. So remove it. } } Fixes: 317bacf960a4 ("i3c: master: add enable(disable) hot join in sys entry") Signed-off-by: Frank Li Reviewed-by: Miquel Raynal --- drivers/i3c/master.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 7028f03c2c42e..852b32178b722 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -2039,10 +2039,8 @@ int i3c_master_add_i3c_dev_locked(struct i3c_master_controller *master, ibireq.max_payload_len = olddev->ibi->max_payload_len; ibireq.num_slots = olddev->ibi->num_slots; - if (olddev->ibi->enabled) { + if (olddev->ibi->enabled) enable_ibi = true; - i3c_dev_disable_ibi_locked(olddev); - } i3c_dev_free_ibi_locked(olddev); }