From patchwork Thu Aug 29 21:14:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13783896 Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazon11013062.outbound.protection.outlook.com [52.101.67.62]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F8021BAEC0 for ; Thu, 29 Aug 2024 21:15:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.67.62 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724966107; cv=fail; b=jBFcONnweglOwB2DQVEhi+CusNSt6uXLFvjA/lEWKAKXmEKmpuNfhtRZE3c8wspUkFhVW81TkgqmbTjydY/8zj8LMH41RVv7YfsDCIQxMSprsORM+kJp0Th7SxSpp6NplYAjsm2PYkk+d+ixHRA2ByhFUA1n5nNN3pEac0BSaXI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1724966107; c=relaxed/simple; bh=ri9MIXRiXjqbTg39R5FGovPrvPxflLRVfGXm3ZFPAs0=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=bG6LeBs+qBZtqlew4ilpH9MYNNELjOo0m1umQE9HVJkjSSPsAYmXUNvp7QJ+tjSmzJwBxUFvgjAFtq5Po/IpALPHSh4J/GanDRcz2AgbhpKpoLDpRssgo7UH0mMJf+EoIIRQCTCsOV6DZ1Cmt9UfjZ4OEIK1UCAsnO5vN3Rpbgw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=ZfQEBH3M; arc=fail smtp.client-ip=52.101.67.62 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="ZfQEBH3M" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mDuLDBK/UtzTXF5MWuC0yqfD+jZD405Tgwt9dCnwskhK3gcDZiIw0CcYFHyRTxBtDwcjwj8SZM4WznhcaUda3KxpCHbXgjanb7blaKZlQVo7RzwFI2X2Kkp0r1m+6UjHpTxnyO9Nh0KyJUhozjVQBdl9eXBNlDs+D0493+H7/+XaCD+6IdY6Oalzftpvm5R3WToZXthQk3gJa3vX3mQt86HFoqUXvxFIEpG5jxRm9PZ65Std/jHT47zaJ41fHo9eCOLm+60O/a7eUpYk/ApY68y89I+d2DPFWX2/dqkESvJbL8EvWV30qPs/QMf0MIjr7ChgbrgjUS0/R/Zj8B3tOw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cww+xyydNFuIwjFox6cDRmzfODgCjih+5wH/d19iPXE=; b=Sxrf4BxuH+aW/Pb4Ixx7k+jg6DJKtDWvfp8MRVZ0zvdcx106a6bjWpPvt6QejoszlY5IiIK8em4i0n+sbWudTlseF+UPsLFBZGJwz+I+FKCl2389OmXCgTohrYGBEI6d5oDEU2fT0DEvWAxggJdRAkllvfBnSFRxaFRVHpDH7BXUDwqc54ZiRiBRRE/+GRFv2vQHpl4RPXTzUhQ0ugAiIyS0voytO7XDKpt92uHMKM4OwTr1nzzGhflvR+xfN1ibVg+kSwDpzAk79dxO5IZyFAA8sZfLNKJIYIb5gEwr0/v6CbNDSMZu19pIBXOd+QQTHsfSGOl7/DvXYnZO7KQJ/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cww+xyydNFuIwjFox6cDRmzfODgCjih+5wH/d19iPXE=; b=ZfQEBH3MVlHW46+fBA/D6gatcGMuJ9IIbEJt0LzCNW03Nj19CYPHh+uRzF9P1KLP1xzodzCb/jx7nyY9ZzBY1PwHMkANJcOW39xr6nVK7XbSV3Ndt7BLsCXP9jyBT4jSgWmNIkVD4Ihtr16R0JwDfPSQ+6uQbk9jMSnHB88pEDX+lusWBgwMQqiquC8zLe2josFmk13bFqFIy3t5y1U7gHDmtiRbtbEfaNOX7cEDW+Wuo712YPI4MQWYZoInMGqNGhneubSkcUKQny7ZKOIYfrNPT/DCk2j6X8h7QdIoX+4XDJlq5QVztcSvMJT3E9zO5gtpmStHopsuwLvXi5/obg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AS8PR04MB7560.eurprd04.prod.outlook.com (2603:10a6:20b:29d::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7897.28; Thu, 29 Aug 2024 21:15:02 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%4]) with mapi id 15.20.7897.027; Thu, 29 Aug 2024 21:15:02 +0000 From: Frank Li Date: Thu, 29 Aug 2024 17:14:02 -0400 Subject: [PATCH v4 05/11] i3c: master: Fix miss free init_dyn_addr at i3c_master_put_i3c_addrs() Message-Id: <20240829-i3c_fix-v4-5-ebcbd5efceba@nxp.com> References: <20240829-i3c_fix-v4-0-ebcbd5efceba@nxp.com> In-Reply-To: <20240829-i3c_fix-v4-0-ebcbd5efceba@nxp.com> To: Alexandre Belloni , Boris Brezillon , Parshuram Thombare , Greg Kroah-Hartman , Boris Brezillon , Arnd Bergmann , Miquel Raynal , Conor Culhane Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, Frank Li , stable@kernel.org X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1724966083; l=1199; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=ri9MIXRiXjqbTg39R5FGovPrvPxflLRVfGXm3ZFPAs0=; b=bMB3QWwqqCes9ly5xS1nICwxaxtWpDAE97V0FjkwcTPA6PrPPoAcKO0qlBcqGKXgJKiF44FnC J74G2fbImxACxUkY7APZ4cT0Ir63tCQoyWBBD+OG7Jzs1B96140vM46 X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR13CA0219.namprd13.prod.outlook.com (2603:10b6:a03:2c1::14) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AS8PR04MB7560:EE_ X-MS-Office365-Filtering-Correlation-Id: 80eecb20-d659-453b-e440-08dcc86fa59f X-LD-Processed: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|52116014|7416014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?a0V5ytwDLX1q7/wPCyOCb2SWSgWAOVl?= =?utf-8?q?zZCfZI/heORGQsSjQgWHPaqay9fqQ4TABPrxc962Om+o9I/2dqY4WfGFtwz08oHtY?= =?utf-8?q?FtF2upcmi1M69oVqSLDs4fouBUGjvVETk4TdKqb+/e9wPdyuR3K87mJdVMvRzdfoC?= =?utf-8?q?bdiqEN+DI8iCurvnowwzbGV+vbVUrhLTDRnCY5JL+FpycRRjoh6QmmmE/tTY74z+E?= =?utf-8?q?x/Cy7Y5OO0+8Alf2CBDq3CwUrIx3TrJTL9evTFibhXnzIn5+Zef3N5H230mQ9iWbf?= =?utf-8?q?catRG4YXlATUVQIIPX4YqYqZWsjIorR/fE9kcfZkcXLoHRdS5s9iAN1KSvfyx2tRF?= =?utf-8?q?9NMx9fUMq2SDZiI/uY7R+Z03RiPHTxTHhSqvykLqMRAhNpl93LIZfFHlrsQYINxfF?= =?utf-8?q?5vtKW3gTpgvIq9+bf1vo584NbBj/V13jXLbFFburrTTEF2AoIQJhLHC6WXAGJ8ktb?= =?utf-8?q?fedubTJK3MUh1dtBNC9ALJX1Nkz1C0+tufUBzKc9e5C79z/QBFP+WqrGvUR2nu8/J?= =?utf-8?q?PF0AQMfMONB9LRTYdzKWMeSDx1yO15P8/w0vgICNq2YJy0/8e+fhRoEpCjlaRSaOL?= =?utf-8?q?3RTTeK9ZXCqXS1j1DBFsJNXVumvr662JoPZQbNX4s8sXfv9kENZ/cBKLGbh0Cunm0?= =?utf-8?q?frZNbTSbtp6S05sa/JNR5u+zAuSTyvppeBMwpzKFew5I8MjePrWOCC48Oig2QZz61?= =?utf-8?q?oMbDBlEJ/Bf/Y7cXl+gGGDQQ8O82ZXqLSg+ApY6AuTstIwwtzFy0hUDTDpTFrvQfk?= =?utf-8?q?BvzFSzu9WpNsM5ocBXItBnveRu+1262+rHyBhShtmV8ro2W+L+qJ8iNld7sPKpTV9?= =?utf-8?q?edC3knAHpG4HlgbgxoJ0rt7PriDqZUdRfGdL1huf9Iw1V8JBZK2RWNDU8ye4UhDbF?= =?utf-8?q?/b8lVYFkUsrfHBwGziI6wgubJ0mfnBfga3mQtIVSxTt9+x03xn0yDwMjGWxH7bC1E?= =?utf-8?q?7e0CGAMMhkWavlyAw80TIQtU7BdYyMBDJObO9dv/n0ER6Lad9nSrY9dUc4QQSLvo/?= =?utf-8?q?yxjvy3hvzPKbhbRdgUEqjv3Pi0NxVSO+CD/Zh+DBlQsz6t4LCyraIEYy6qRAkz1Ol?= =?utf-8?q?OPW4uPlOgmf7H3ssmUxEmJh546hoZk90FGObTHv1S6NPfIwfhiVhyZHxJaO+OuJCJ?= =?utf-8?q?YyIH87yqzneyFvS4WhRzo77DASnIm0uqv5WSidWTjKlpfS/TL5rvHmrHgYJWQukSb?= =?utf-8?q?MdiYCKA+GkFAcHVPkl4aG1anHSs2IGGqtxLJ/0T9qwslXl2euRQcBMHOC8WMHHWeo?= =?utf-8?q?BNkzCyyPTyIXeCYJFFDXPJIDGjDM79R/6Ps1DqhOd0DmogilKsSBYcxsnkYIbEahb?= =?utf-8?q?Mvg9e5l4WTgCmaaJLNfsQ+2uYaOV1OPAtw=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(52116014)(7416014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?vy7yvcNYG+6AcsOZ4BHZOXLQdReN?= =?utf-8?q?2r7PLabbhEuv4AMeXhluGOZQI+Gy4WTkZ0AFY6T2C/Wpa9nbXS4+BY7Pr+8+TdE+a?= =?utf-8?q?kkD+1tvpggdYAOSKeWh0oVFuajUAI731U2VZWyZjV9DGo9XsCEzmkU5CbCFs5RvMm?= =?utf-8?q?yR78ql55YG89mVT6Lt5xmRY6fF/C7kzjF1FnZzTg/0Uv3nX/Hvra+uQmAkdyyjovY?= =?utf-8?q?uCQ5CxmPCipPSFh4PWNKAo8r+CCQ6BQpy7WNzJMqd8T1kMTI7M+KFOU/pcM3EHIxz?= =?utf-8?q?a+NJOljDR/qIdbSZ9//BxrGMeaHTAngy2VXzXadSQ+q0QVqPsnzTvvIpMdUoRrZ2v?= =?utf-8?q?jXcS7BI4EjZz7G1r1tMauORmXOGovhrUrx5tbygOS91HaEsXQTOtBuS+jt+oD9zXL?= =?utf-8?q?yWrsE+rBJfdigeEXGfQ3z3mykVC7+uNc+mpvYYSkL/0CDWFTVeofrxKw12Ps3kDSE?= =?utf-8?q?2svzteu7JJM0yQgPVYFIMkbKxVSwWa1qvIS1tKd6NZixf7/4Sv6l5m5/jIm+Z7HgW?= =?utf-8?q?rUHqxsQf4k3Sfq3tc5ug0vp/Q6Y9uKvqSeXMkzuq2sYD7h/DePcDxKBV5o34TlHfY?= =?utf-8?q?CMCeaZ/0kOssocel3uISRgUX/jnwar2zdK07HoY6qfvqofNxnbWUSNHnKm0/NBoQ5?= =?utf-8?q?Jl36yok5KxLqL/oGoJH2OFA16u3NNwEmnc4CS8bxvTEinoNXhtXJNzOCzHDczgfFo?= =?utf-8?q?O7OLv0SrYo79YEpMY5CA8n4qvb7lAgacXTo1MLaVo+2UR6UEqxm8kYBNb9F8xPAmo?= =?utf-8?q?jnTk4B92e/u4rB4FE9OCkVykLxJvCFSas8oP0RAJSFmL3367HupJzfANa3kx4yDGY?= =?utf-8?q?F+hEJxG6rVxI+PDGofaXAWiUVpKzsqYfOlb74yuBtJXAttv5ujRVDul3EKE6cocbI?= =?utf-8?q?YVmCpDhYye2hvksR+PeyvhNZCQyJBFoZu8nXiilFcFGZxc5jfeLsD5OmGMN+6jEpl?= =?utf-8?q?DHcHGxD68KCmq2h8wQ/3X98PqF2p7sfBcX3KR9BBCC7ayZC6/W+ab3Rw46+apeb6A?= =?utf-8?q?3AdPoE8CNh/7vKyIO3lEPi/yi+7vhhWNLUzTwRieTlG76sYHgYn+Ui33tKJIfkCWY?= =?utf-8?q?odMO3wp8qei+3qpUb+bY06L+C3BEZiaxYxZc3edlOllHQxhSBd1B0xqqCLmklEx26?= =?utf-8?q?5CUFGCg016ckaZZMWyfXOGNpuDl7yMNmURFJB3vIweajukP07ZxvV6BRMl3XCLjq4?= =?utf-8?q?zYvOQQPohX8VL1xhePPhATnZumpaKyacXU2S4GMABiMXT9szaV+THhB7VL7hvUnKs?= =?utf-8?q?yoPucogNt5gvHNosd+17m87pQn0ai/bskboSecLLDKVjeaD/Dzh8t772xW6aNok1C?= =?utf-8?q?Fz2scDCbJDl4piim7C6C37u91TSUbRtkNw9WZ+U8nzSFEAGrGAhF8cjmx6fTx9YFR?= =?utf-8?q?eL3mk2gHxKMMvm/UEl87qdQMO3LmXdyM4x0Io6Ckw6RJ6nZ7j9Bq/k4TnjxcOzNci?= =?utf-8?q?sQMAMQ02VIzrWc+LFvjvjfJQjzPp5B1O1lxONE3qDVoaM6O0avUZch5oSBAFVpNeE?= =?utf-8?q?s2nY3hLD1rzg?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 80eecb20-d659-453b-e440-08dcc86fa59f X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Aug 2024 21:15:02.6456 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: hD8RoeLWP55uPBlTG/xBVidqGl3HzXBtezCYHt4WCcyYPWXsWQPWwubX2yw59+EO68KxLZRtmrvQSH6+WaJcLw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB7560 if (dev->boardinfo && dev->boardinfo->init_dyn_addr) ^^^ here check "init_dyn_addr" i3c_bus_set_addr_slot_status(&master->bus, dev->info.dyn_addr, ...) ^^^^ free "dyn_addr" Fix copy/paste error "dyn_addr" by replacing it with "init_dyn_addr". Cc: stable@kernel.org Fixes: 3a379bbcea0a ("i3c: Add core I3C infrastructure") Reviewed-by: Miquel Raynal Signed-off-by: Frank Li --- change from v3 to v4 - mention copy/paste error - Add Miquel's review tag --- drivers/i3c/master.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c index 7c8fc4378b979..e7cbfaf13b599 100644 --- a/drivers/i3c/master.c +++ b/drivers/i3c/master.c @@ -1467,7 +1467,7 @@ static void i3c_master_put_i3c_addrs(struct i3c_dev_desc *dev) I3C_ADDR_SLOT_FREE); if (dev->boardinfo && dev->boardinfo->init_dyn_addr) - i3c_bus_set_addr_slot_status(&master->bus, dev->info.dyn_addr, + i3c_bus_set_addr_slot_status(&master->bus, dev->boardinfo->init_dyn_addr, I3C_ADDR_SLOT_FREE); }