| Message ID | 20240902065606.8072-3-tarang.raval@siliconsignals.io (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for Variscite Symphony board and VAR-SOM-MX8MP SoM | expand |
On 02/09/2024 08:56, Tarang Raval wrote: > Adds support for the Variscite VAR-SOM-MX8MP System on Module and > the Variscite Symphony Evaluation Kit. > > Signed-off-by: Tarang Raval <tarang.raval@siliconsignals.io> > --- > Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml > index 6d185d09cb6a..99555767f8d0 100644 > --- a/Documentation/devicetree/bindings/arm/fsl.yaml > +++ b/Documentation/devicetree/bindings/arm/fsl.yaml > @@ -1071,6 +1071,7 @@ properties: > - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules > - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT > - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules > + - variscite,var-som-mx8mp-symphony # i.MX8MP Variscite VAR-SOM-MX8M-PLUS Symphony evaluation board > - const: fsl,imx8mp <form letter> This is a friendly reminder during the review process. It seems my or other reviewer's previous comments were not fully addressed. Maybe the feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. Thank you. </form letter> Best regards, Krzysztof
Hi, >> - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules >> + - variscite,var-som-mx8mp-symphony # i.MX8MP Variscite VAR-SOM-MX8M-PLUS Symphony evaluation board >> - const: fsl,imx8mp > ><form letter> >This is a friendly reminder during the review process. > > It seems my or other reviewer's previous comments were not fully addressed. Maybe the feedback got lost between the quotes, maybe you just forgot to apply it. Please go back to the previous discussion and either implement all requested changes or keep discussing them. as per your comment, I did update the board name to "variscite,var-som-mx8mp-symphony" instead of "variscite,var-som-mx8mp." Best Regards, Tarang
On Mon, Sep 02, 2024 at 07:07:02AM +0000, Tarang Raval wrote: > Hi, > > >> - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules > >> + - variscite,var-som-mx8mp-symphony # i.MX8MP Variscite VAR-SOM-MX8M-PLUS Symphony evaluation board > >> - const: fsl,imx8mp > > > ><form letter> > >This is a friendly reminder during the review process. > > > > It seems my or other reviewer's previous comments were not fully > addressed. Maybe the feedback got lost between the quotes, maybe you > just forgot to apply it. Please go back to the previous discussion and > either implement all requested changes or keep discussing them. > > as per your comment, I did update the board name to "variscite,var-som-mx8mp-symphony" instead of "variscite,var-som-mx8mp." ??? No, there is no difference. You did not test your patches either. When I wrote "This is not correct", it means you should drop it. Incorrect compatibles should not be added. Best regards, Krzysztof
Hi, >> as per your comment, I did update the board name to "variscite,var-som-mx8mp-symphony" instead of "variscite,var-som-mx8mp." > >??? No, there is no difference. You did not test your patches either. I did test my patches using "dt_binding_check" and "CHECK_DTBS," and there were no warnings or errors. >When I wrote "This is not correct", it means you should drop it. >Incorrect compatibles should not be added. Sure I will Drop it. Best Regars. Tarang
On 02/09/2024 09:23, Tarang Raval wrote: > Hi, > >>> as per your comment, I did update the board name to "variscite,var-som-mx8mp-symphony" instead of "variscite,var-som-mx8mp." >> >> ??? No, there is no difference. You did not test your patches either. > > I did test my patches using "dt_binding_check" and "CHECK_DTBS," and there were no warnings or errors. Ah, you are right, I missed what actually changed. > >> When I wrote "This is not correct", it means you should drop it. >> Incorrect compatibles should not be added. > > Sure I will Drop it. I guess I wasn't precise. Please drop that one diff hunk. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/arm/fsl.yaml b/Documentation/devicetree/bindings/arm/fsl.yaml index 6d185d09cb6a..99555767f8d0 100644 --- a/Documentation/devicetree/bindings/arm/fsl.yaml +++ b/Documentation/devicetree/bindings/arm/fsl.yaml @@ -1071,6 +1071,7 @@ properties: - toradex,verdin-imx8mp # Verdin iMX8M Plus Modules - toradex,verdin-imx8mp-nonwifi # Verdin iMX8M Plus Modules without Wi-Fi / BT - toradex,verdin-imx8mp-wifi # Verdin iMX8M Plus Wi-Fi / BT Modules + - variscite,var-som-mx8mp-symphony # i.MX8MP Variscite VAR-SOM-MX8M-PLUS Symphony evaluation board - const: fsl,imx8mp - description: Avnet (MSC Branded) Boards with SM2S i.MX8M Plus Modules @@ -1149,6 +1150,12 @@ properties: - const: tq,imx8mp-tqma8mpql # TQ-Systems GmbH i.MX8MP TQMa8MPQL SOM - const: fsl,imx8mp + - description: Variscite VAR-SOM-MX8M Plus based boards + items: + - const: variscite,var-som-mx8mp-symphony + - const: variscite,var-som-mx8mp + - const: fsl,imx8mp + - description: i.MX8MQ based Boards items: - enum:
Adds support for the Variscite VAR-SOM-MX8MP System on Module and the Variscite Symphony Evaluation Kit. Signed-off-by: Tarang Raval <tarang.raval@siliconsignals.io> --- Documentation/devicetree/bindings/arm/fsl.yaml | 7 +++++++ 1 file changed, 7 insertions(+)