From patchwork Mon Sep 30 12:04:10 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda X-Patchwork-Id: 13815963 Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 23263194ACB for ; Mon, 30 Sep 2024 12:04:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727697879; cv=none; b=QAxluizqwxEuD6gLkn2pjEEhUupwSmBDm00jkm7yGzFpxOsgdSJ2gDKbjX2/SsFi05sNnHvCEVx3Zdy/4UMEaOpYr1yiFm1A5YLpl4Piwo2VS1FtjWwExyBydgpuv0h2Wv8lL+B71QjCBjcm5f1bb2Kr3R8ZN6QlNObF7hCPOuc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727697879; c=relaxed/simple; bh=27dEbLYS3PRjKxWaJp2KRsfAuUa8ZpRAboFGn7TSbcA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=P/IbF649DozcBAer9wGYfOY9K4/dE0TBFtjoMCmIVMAk8lwmKbrHJTFyyBeltSCBFWQ72reU8j6okLVpxxV9dZBOHpbbmJYr3oJi/QzBr0+TKOX562Ph6sBQJSuoNs4aywVBM9HvQfZpIQVd3u25381XSUcZgaWF5ddS0swpleM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=YfSIUuY9; arc=none smtp.client-ip=209.85.161.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="YfSIUuY9" Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-5e1baf0f764so1288347eaf.1 for ; Mon, 30 Sep 2024 05:04:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1727697875; x=1728302675; darn=lists.linux.dev; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=xpVUYLeo0hSTOfKt30J/ldl6oRGhulqCfi0QX1kLeY0=; b=YfSIUuY9oKFuurooKY3kA0iBAWfctTNU7TDJW98s8N3QvGGfwm/xlWYYoZpF0lgM3y 5fbnEWDODeOKGFjY8rh98vN5oPGxmXzh8qJXgnyLEQxAgsK2AVjoeyH/VHHXKPuI9/gx XcHm6V0N/wxblFGcqGylmmAKs7ppOHMubmHDE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727697875; x=1728302675; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xpVUYLeo0hSTOfKt30J/ldl6oRGhulqCfi0QX1kLeY0=; b=kCgUhmy+ccof0+VzrhdT85EIk2taZzQTjSnI6KF8Zcjg9U+D3EGX0dTDyZ7/SUQee7 v36NE1Kdio8k3buI1E9x+E0kTYvXOJ5oX3Va07u3jqQuFhOX3lbBdaxT6sBkGgj/MoIl k0sQRQzMZZ9+Zdo2lfi4eTfwVBDU0lJLCSz3A3eiIzZWkTH/Xp0JKL1WgejLAEq1PYlx NlBffgXA0iemG7Qs7IwqMJqcMEzIxbmtxW3ZVSI5rlptUPJXu+4VAVdFfo+z2uxj1MBI zARYmpiB5Ta15o7DHu+zlhCw2nPbTOqBeMvMgz6yxYyzEvBnJ6DHr5HETj5sa3wQ79t5 M5wg== X-Forwarded-Encrypted: i=1; AJvYcCXOjfec62Eu4lJP9NcSli/FCljBC2roZTNqQkzfG+Trp0DdGdVdTH5zA5sPM0ZsShmXcPc=@lists.linux.dev X-Gm-Message-State: AOJu0YzN22B9sDUdqttAfOQTakR8gwdjdcbFdOsijtzNLjG7v1czMVuK Hfi6DVi4skCcvQpnnwVjeFydKE6bdwGxCW548WYLxWbXCWZLP0yKDaJjXC25jw== X-Google-Smtp-Source: AGHT+IGd3K8vbb6GyQdRKaZnKoS5TA6gIcUfCdqxCm9K5gJfl06dGrwyNT5yGfSWCEUO0kuvQMkCfQ== X-Received: by 2002:a05:6358:e4a9:b0:1b5:968f:e221 with SMTP id e5c5f4694b2df-1becbb39bb4mr326693155d.2.1727697875191; Mon, 30 Sep 2024 05:04:35 -0700 (PDT) Received: from denia.c.googlers.com (76.224.245.35.bc.googleusercontent.com. [35.245.224.76]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6cb3b694369sm38822536d6.144.2024.09.30.05.04.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2024 05:04:33 -0700 (PDT) From: Ricardo Ribalda Date: Mon, 30 Sep 2024 12:04:10 +0000 Subject: [PATCH 15/45] media: amphion: Use string_choices helpers Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20240930-cocci-opportunity-v1-15-81e137456ce0@chromium.org> References: <20240930-cocci-opportunity-v1-0-81e137456ce0@chromium.org> In-Reply-To: <20240930-cocci-opportunity-v1-0-81e137456ce0@chromium.org> To: Sakari Ailus , Bingbu Cao , Tianshu Qiu , Mauro Carvalho Chehab , Greg Kroah-Hartman , Hans de Goede , Andy Shevchenko , Hans Verkuil , Mike Isely , Olli Salonen , Maxim Levitsky , Sean Young , Sergey Kozlov , Abylay Ospan , Jemma Denson , Patrick Boettcher , Ming Qian , Zhou Peng , Andy Walls , Laurent Pinchart , Michal Simek , Jean-Christophe Trotin , Philipp Zabel , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Eddie James , Joel Stanley , Andrew Jeffery , Hans Verkuil , Tomasz Figa , Marek Szyprowski , Tim Harvey , Benjamin Mugnier , Sylvain Petinot , Jacopo Mondi , Kieran Bingham , Laurent Pinchart , =?utf-8?q?Ni?= =?utf-8?q?klas_S=C3=B6derlund?= Cc: linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, imx@lists.linux.dev, openbmc@lists.ozlabs.org, linux-aspeed@lists.ozlabs.org, Ricardo Ribalda X-Mailer: b4 0.13.0 The following cocci warnings are fixed: drivers/media/platform/amphion/venc.c:1206:4-26: opportunity for str_enable_disable(venc -> params . rc_enable) drivers/media/platform/amphion/vpu_dbg.c:259:3-34: opportunity for str_on_off(vpu_iface_get_power_state ( core )) Signed-off-by: Ricardo Ribalda --- drivers/media/platform/amphion/venc.c | 2 +- drivers/media/platform/amphion/vpu_dbg.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/amphion/venc.c b/drivers/media/platform/amphion/venc.c index 351b4edc8742..789c8fca3d31 100644 --- a/drivers/media/platform/amphion/venc.c +++ b/drivers/media/platform/amphion/venc.c @@ -1203,7 +1203,7 @@ static int venc_get_debug_info(struct vpu_inst *inst, char *str, u32 size, u32 i break; case 8: num = scnprintf(str, size, "rc: %s, mode = %d, bitrate = %d(%d), qp = %d\n", - venc->params.rc_enable ? "enable" : "disable", + str_enable_disable(venc->params.rc_enable), venc->params.rc_mode, venc->params.bitrate, venc->params.bitrate_max, diff --git a/drivers/media/platform/amphion/vpu_dbg.c b/drivers/media/platform/amphion/vpu_dbg.c index 940e5bda5fa3..2dbcef4e83ef 100644 --- a/drivers/media/platform/amphion/vpu_dbg.c +++ b/drivers/media/platform/amphion/vpu_dbg.c @@ -256,7 +256,7 @@ static int vpu_dbg_core(struct seq_file *s, void *data) return 0; num = scnprintf(str, sizeof(str), "power %s\n", - vpu_iface_get_power_state(core) ? "on" : "off"); + str_on_off(vpu_iface_get_power_state(core))); if (seq_write(s, str, num)) return 0; num = scnprintf(str, sizeof(str), "state = %d\n", core->state);