From patchwork Wed Oct 2 14:50:35 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13819882 Received: from EUR05-VI1-obe.outbound.protection.outlook.com (mail-vi1eur05on2077.outbound.protection.outlook.com [40.107.21.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0AA2B1D1519 for ; Wed, 2 Oct 2024 14:51:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.21.77 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727880668; cv=fail; b=LgGc0plNMIPtyKTQJOSI9/vVcLx97ZfJyOI2Fn+75i3unQ1IozTVghU6N8OLPXUkaanDR5f1+pISnRoJ/+JnDmrY3841I8AxzZgHPYTLsQATsa2+4LXVXCApPg+8Cs40lPe75MSPQVsqhvkq/U6aDLCgY8+OrSxaN0WvO+9aPEY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727880668; c=relaxed/simple; bh=km8jyYKynVS8oCIdOvA4qQ3oLe8hXP9gLirgD+wv2WM=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=kLVxf3i0qF6x1btMSi6h2Zn6vwxfrSOuxtPg/26N8wUCRkchPygW1ugLan6Qbag0gQl6ga3pQX3Gmc46pcCucBKU3J+efTKqP3RCAQGEfEOi72kcr6dzd13cCQWfDhvm7xAG+ZxPmdGynVsu8zN2P28PDNu9WE/3TB30uhWPHog= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=dX2GyIFr; arc=fail smtp.client-ip=40.107.21.77 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="dX2GyIFr" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=nR06q5A3kMQGujjCFnBRQuNNXDVXH+ifM1ZnidTMmNMHVWOxLjPNFkUnsLrJqeDqMOZ3ewoMKjT0j3W0m5B0zHP7vCCHJz5Zb7AsAiUbVCtyXc/SHYcrouTpgWvKdxnes8g8Nr3Am4sY/53+I2JfU//R61odn6T/NPESErKQOHALScwhEYSN3VwvhFfFp39SB7x/wz2WXUKUkpc2wwRQnfWMS5YNMEeJOGpSZGiXTU6VbWHoXTHN4Vskw4HVrbd/udHiSctq05/2V/3ww+JP/gG6r/8tRV6uC1rntC0CRs0yFUG12TFKU04CC51J7nIx4jI4HQCEsUfyBxTevw1RvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tR98+9LS9quTYVdmJkr0U97KPEN31FgGaNrzukbSyTU=; b=ngAQCtXhEKIN2pKvVBPhD6z4BozYzjiKxtZsAk8tpGpBvCSSQF9dkILp1EH+mWfMWnOiEhB//ZRYCd3In7vtEF5OBFt//HbL2JuseggNWLRRg/FmEZAkT2qAPHrPb1o5Htios2ei7acaUVtr9F9r4RAPrhRdhQU7K9u2dZXjo9yylKCcwn7P7CsJRESPTIAsfF5/B1ifJPS4g5wxWscVZquWHVdi7YNuNujyeRlYTcqWOGwo9tdK5TBTqf1rhBPAQ6CF8aGFdvJASHlANxZwmSlgMaigTkde6vIA/WqAFxcVGUb3CkCATZ/zD/2rmsSQHLo8GHx+MvRBEnSw1zywQQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tR98+9LS9quTYVdmJkr0U97KPEN31FgGaNrzukbSyTU=; b=dX2GyIFrJmkKFj9e+KCMf+dDujzSDQc/g3RH8Z4qIS5FR63PiGoVODS+wMYCqcV3R6MvF6Avyxcpus9W0Gv47EDC7YaYg0qjjQRlssjvQl0BLMV5Ut/KQ6Xn/fw/2IgHgnLaL6J/rO2dIifT2odGO/ve6WJgKo0HbBdDfromPJO4ALBRhezDQ5q9iUp8mDO4pNNUk9KU/ABPFTzdvwB4MCYxmLjYGhiMfV29xez+HPP/f8D70NZBsj0fDK7RBapjiX7oEDuLcMqLnTiQy7IqcrefwRNEXMcXynKFgpJ3ewm+Z9rz5WbnftBrEJnZNdbYbKeyAp0pBt2QpJRTmfTCkA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by AS1PR04MB9699.eurprd04.prod.outlook.com (2603:10a6:20b:482::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8005.27; Wed, 2 Oct 2024 14:50:58 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%4]) with mapi id 15.20.8005.024; Wed, 2 Oct 2024 14:50:58 +0000 From: Frank Li Date: Wed, 02 Oct 2024 10:50:35 -0400 Subject: [PATCH v6 3/6] i3c: master: svc: need check IBIWON for dynamic address assignment Message-Id: <20241002-svc-i3c-hj-v6-3-7e6e1d3569ae@nxp.com> References: <20241002-svc-i3c-hj-v6-0-7e6e1d3569ae@nxp.com> In-Reply-To: <20241002-svc-i3c-hj-v6-0-7e6e1d3569ae@nxp.com> To: Miquel Raynal , Conor Culhane , Alexandre Belloni Cc: linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1727880649; l=1618; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=km8jyYKynVS8oCIdOvA4qQ3oLe8hXP9gLirgD+wv2WM=; b=0/6zj+o5ZrjhO8E6paIbmVG6vIWC79f/0qAGiqEpTKUA6UaeH+V+GT8AZLzdrcqDZpy6QO+jK iBpO642BkxUAHGV4zp4/aIdKEWubL/LXeKK8BdWmtfzQStd89qp0tlv X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR13CA0177.namprd13.prod.outlook.com (2603:10b6:a03:2c7::32) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|AS1PR04MB9699:EE_ X-MS-Office365-Filtering-Correlation-Id: 5c6e1e14-3da9-4524-f278-08dce2f1a065 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|52116014|366016|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?+h32W4VXZxLe9k0hUWhB+H3XKhDx9c6?= =?utf-8?q?c8fX/V/pd4jU+SAdZdZCBW3a8DYblnRcqBAIc846h5wYHoFdMd6drKLvkziDQavMO?= =?utf-8?q?BKNSP64uZ0UA/06MGqasXUXgAUI9lGHe/w/Nevifv1tHai5Bt/lxBxEB+zlT+1pX/?= =?utf-8?q?eJFtoldf1tqwbsEGX/4cyCmK15+K7k1sFDBPQGSsdaJJfjeN4aiGnQDBDmP3o7ji0?= =?utf-8?q?UZYC8iVSM32QLSb7ZXCgtXKfYFGawh2QmeOZdvYhFYyYk/CwFVBopTp37dXql5sQE?= =?utf-8?q?FXacviPAc+by53pgYXENmS6cusKuWqTIPfsD5VdSUqc4uDy//t3zLJoOtiPy8fZpk?= =?utf-8?q?kQGATY2j71nGnEQjA2sWlo9I/uIKvirYHh9fCc7XUOvnB9QG7yz8KoH3GGMinP8Mp?= =?utf-8?q?m4QpZVmbyyR5IjO7sOOoZ/uLKgY6F+988BSoMYkD2yGbOBE46tHEXbH731Y6nRAmk?= =?utf-8?q?XE0cZIkCqLryE2fLOWyRM5IrERbsTrFEHSLcl6tFL4OZBb7B0E9Ok5A/cghMxC1+d?= =?utf-8?q?Lfc+dA0S0AiwoANn6Wz0Vw4N4nfdu5wFOC8RVsUazxTO/fAek91F99eqKO965EEgK?= =?utf-8?q?d2jywWbEWoDbKvQwz69Hucj8QodL1gtTHzRYtRJUvWG1hrbrj/ZFFbKSirI1GdZQL?= =?utf-8?q?RnVaYALrsoLiOJ8L9WLWGPMDvblmDAT592YfH5RRfI2e9w33YifxOVj2bTRfRR97k?= =?utf-8?q?Pa6hjixwmdDHOzCXDJjt/omoAUsinbOTXOr+/UsE5jd+3Uft7q18++a6eHhQ8do01?= =?utf-8?q?8/AtWKtBN3ExwCCENBiKXPxher7SxrEI3a7OhHUhmuTtCtaGYW46/zxYsj3USyV9B?= =?utf-8?q?drvRr7EplZp72QxvkymMumpLWpiiz3Juwf8qcBNFQ78b14A9hjA6t9SyNNHPTrrpO?= =?utf-8?q?ECDbuyUiR5/9t+sQQpB/BH2sSLbXgnTpJoCzr/Pn+oiFwXErAUA2b/5fb1/LuZI88?= =?utf-8?q?xYe17XtJVcy+a2rQDWZFVg8MK9x8igWSI1AYyR0JFuZVFRxFgcrhiHSMQHAw80ncY?= =?utf-8?q?ShbEPFkD6Jd4lTBZEwDooh9+C5WHyHocK4ymCy2mnzWFkqZsLhKs4QDCpIkXBqDB6?= =?utf-8?q?S1CV6+JuZxL4Kmo0Ho5rTX1Y7PQjca6jP29Ep6dyUeTVDTpReHGFppLN8U6ha4o5P?= =?utf-8?q?dMo4Z319efIahNVC8H09K5Brr5vwNqqojpeI4xWlyoRgELC4HXD2nV+qH1ajlGa40?= =?utf-8?q?0ou+g0sjwkmGnP6PJfxjktiyKaRJF9JqOl/cLVi23eHKbAyS/uEWzvfW3BXSJ92PR?= =?utf-8?q?Ok3wO/cqD4yi2cRugBtGY479IlviZO4343w=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(376014)(1800799024)(52116014)(366016)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?PtFgac0qfZJzPRu+z9rmPE/pP9nc?= =?utf-8?q?qNeePDRxPfYY2cwp7DqN76kAAREA6q4dGMMIWX46ozu9vc/FBnmxI4mYXM5roo2e+?= =?utf-8?q?jU6R3fHRwZIe8A1+JEXX+VYDraZgOhvdYgjhw0Jt4QgDst9DsOJbX3GwudTuv/kZP?= =?utf-8?q?ormEksmsu8B+OJjguFKK+GOZpeBn97jgvwJeaXjV2UwfzKsC/NVP5rmdkrORi8dqq?= =?utf-8?q?pho8TharTTaV/KXye7pxxjewzmXobW249KBhP2CV2v4NXKAuLdE7OrXvOY1UL1y7X?= =?utf-8?q?jHInndbWRUX4d/ZYzXqCuEZ/DBV/RKTtApM8mh2HIOqvxMxyIyTUP7OwiCfQooDyx?= =?utf-8?q?uR07DRcQu8NFHD91hKuUtCL+Hjzbq7df9KWPYHfr1EdcbWXSfwJ65iH8Ru7sms+XP?= =?utf-8?q?pGZk+cIBIDa/F4r9qvwGR66r/qgE9vMB4Q4HHZBOoYUUoTkExmHrSxP9AlYOOKSTO?= =?utf-8?q?aQoTg2G/wcA7kIHCRDVq6s8KJAgcinPAOPz0G5MDMndUf5Qink4OaQ/uEn5qBX9P1?= =?utf-8?q?5yLJZ7UIrQe/4BY2/pmXlvIkuMpW6LNKIwKp0qEDaa8rMGGNhhfRjLcuiXfRsNYOF?= =?utf-8?q?iYOg5sm0DXpFdec0rS1NVd9qV7lQNXCbCUCcf3l8s7LFW0KJzGIxQf0uf68TfoTuO?= =?utf-8?q?oHhfvHVggZDwbDouet6vSnCrzm+Xf9cfEpBQCSDKekDX1ZZ82Aj9Qj68J8I1GPj0n?= =?utf-8?q?DzZo+0BphNdNX3E+OFpx4RD4/lI4G0k4/3drXrpQGaN9PVqKPr94T0IbCWT6gju/g?= =?utf-8?q?9cK6UiFCyKy3sJTAGJkv5+qf6Nu8HUAfZCCXCAWep4UahBqbtfkj1gw4Z9AMRCC09?= =?utf-8?q?yrI3c5LFQLZs250TnSSe8iARqMpNvPNI5FYfF9ZdlfGbcZ081XV0keX6YpZZiTGUI?= =?utf-8?q?WonTqjpjXU8WOPTibGYOCe1n0BGLS/RCyD8m6uI9i5NFVKInmGLl7ETRH0h8GUGHs?= =?utf-8?q?mA9tdL2Phn7h6TM15XYD4rU2+ej69x77+4uV7lPym/tUhjiGgBzdoli9qd4wpbnuG?= =?utf-8?q?Ul4mG64xjUj8hE7RKctPYMR0k1Ny83Sfw47+QeeIy2vpQxy8G3FR06Ctp4T52g7oc?= =?utf-8?q?wdAHlr+m5WhOA2eEugW7SNorPY45K8AUgUoMqec6IngKTkuAYoOVJslJx/FvLUUzQ?= =?utf-8?q?F+SHYoh0LqiIhDIwfLBdkUwKjz9+vUp1IiPSPikx4rRxvC9R+9en5qLYuhMcTcyPD?= =?utf-8?q?rfAV4pGmtuvwxIfZ0NSTkHBIG9I17WZLSTKkDIFpuugO0jJ20ioi+jAB9Kj2bDBGI?= =?utf-8?q?rDQOtbY82ONeuN9OFUO1naJPPc0nPH9d/K8PBgUHmkJZ2D0e6opGlqow4O5FXEQUQ?= =?utf-8?q?ewGWco38DZc0oGguMGM6GNWu3scOp4GzCpRit8AwawZ5+TgufmzokYbKvOAm2yJA7?= =?utf-8?q?JRJsOZdGFr7FbQiszXXiQ4AQDV9X6/FTXiHlR9idXdIh4ssi8WbT0mIsikvz7SN79?= =?utf-8?q?WxjowWMqinfozzl69kYZ44wHEmCTZ0GmGmQHJsfimuDcsTqvRjNDmUyTDMmWMSNxb?= =?utf-8?q?WLqs7mfakwN8?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c6e1e14-3da9-4524-f278-08dce2f1a065 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Oct 2024 14:50:58.6696 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: n24dRHriu/wBjuesMWjXukQn0onb3SG7pSsQaUUeLHRT7JEcjLTA+ecB6fGhTn9p2VCqHuit22u+O5OMuXRTiA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS1PR04MB9699 When sending REQUEST_PROC_DAA, emit START and address 7E. Address arbitration may occur at this time if other devices trigger HJ, IBI, or CR events. When IBIWON happen during a REQUEST_PROC_DAA, NACK the IBI request then send a repeated start to continue current dynamic address assignment. Reviewed-by: Miquel Raynal Signed-off-by: Frank Li --- Change from v5 to v6 - use 'dynamic address assignment' - add Miquel review tag change from v3 to v4 - rework commit message --- drivers/i3c/master/svc-i3c-master.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/i3c/master/svc-i3c-master.c b/drivers/i3c/master/svc-i3c-master.c index c35a228f0c2f4..5df0ec02d73ce 100644 --- a/drivers/i3c/master/svc-i3c-master.c +++ b/drivers/i3c/master/svc-i3c-master.c @@ -872,6 +872,9 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c_master *master, int ret, i; while (true) { + /* clean SVC_I3C_MINT_IBIWON w1c bits */ + writel(SVC_I3C_MINT_IBIWON, master->regs + SVC_I3C_MSTATUS); + /* SVC_I3C_MCTRL_REQUEST_PROC_DAA have two mode, ENTER DAA or PROCESS DAA. * * ENTER DAA: @@ -923,6 +926,9 @@ static int svc_i3c_master_do_daa_locked(struct svc_i3c_master *master, ret = svc_i3c_master_readb(master, data, 2); if (ret) break; + } else if (SVC_I3C_MSTATUS_IBIWON(reg)) { + svc_i3c_master_handle_ibi_won(master, reg); + continue; } else if (SVC_I3C_MSTATUS_MCTRLDONE(reg)) { if (SVC_I3C_MSTATUS_STATE_IDLE(reg) && SVC_I3C_MSTATUS_COMPLETE(reg)) {