From patchwork Tue Oct 15 22:07:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13837320 Received: from AS8PR04CU009.outbound.protection.outlook.com (mail-westeuropeazon11011068.outbound.protection.outlook.com [52.101.70.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3D2C1D63F6 for ; Tue, 15 Oct 2024 22:08:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.70.68 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729030096; cv=fail; b=Np/d6gthfZiSIeTcGKnbzTWDUPCl4KZWDPIbeql8VhF5J58AfDAdUQkouuYck+MA7YrEF5wFUz99PubgCf6N4OJw0WEo+ItOrKRfksytR02O5aK+MSdOq1R2u7UedFrMNCl+F5z5qq0OVIzHAgLC/DOIYRJPnkdDEOoKaMnXcOw= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729030096; c=relaxed/simple; bh=vg1b8fZ0ikOaTJqSjYHEd0OEjyDNFXGxJ24NF7GoDWk=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=HXqUXEL7nSYVe86D5R4Nlb9026Jo9avxurky2bwdb54stTqyl+5SawbPVSILJBZY9xUQGpQaYAGnKO132rrWegh4n27GH9xJpnJ597OcEWKVkdG8gx6iTPt+XXrKnPZJzS3p85OawYGK9jNXM2nc6ZyRJsPaPNEYnsIkppXE+l0= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=U5b+XHpY; arc=fail smtp.client-ip=52.101.70.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="U5b+XHpY" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=aXpFabaRDe3aAvALoj85336gmfzK3IS+cSAJyWvAKiJRVwXyVdXi0fZIFEgWJObduNVy+27GWjugt0HBFejnyhAXDsI070heIEdhydH+XPeGM+EwfDHpLYwAIwy3m4GrlXqB7btBadpbJOYtQsgLZWNcf5Ctv+fNTuGrcXLfU1T/S8DgaLIpvyb29O2frzn/kd5uSTt2FlLJdjIevN7lJCXFfmC6LostboKFRLsQ0paAgX1PAEcQYTjIkdtFSzRuud3WbA5aM9W2Rtv8QClK5wOioitjjp9T0jNNPXnygTmo5D4A1551mPnIbP8qE+cwIcexMPbhAaqFiFnP8Zl0fg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=e233vooloI8RoJJfdyVli25FRPVZrIal9Vo3c9mUtok=; b=MrvqnqlPNufN9bsl3jMkYBfXIH6E7mXiT7D7mFDjZJPqVEJaoYajjcEr6XDsbcVrEjmKUWgGdZhkwsX+VUuCy0bKXvM/6HETMk+TpJsSUuyH35WB32cosoY3tzFAEUr2OecWgKNzRSH5C8UayZJGEDsCNqKW9L7mBQwjbTz6AwPFjVPvZWtogusAV6MzhArS0FyPXY3jkahbibPqPaFU4bpfoZf1FY6jKioxc3J/MTv1Tdgy34ZTKmCT8bPSl2VGR2Ujcxh4C19d/g2LG1dkwAZQsiRWKqnhs+PvXSGoi1x2TulxiRLS8FrxCTfGk/79AUiOTs5ZWAN8C1w7AxB6qA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=e233vooloI8RoJJfdyVli25FRPVZrIal9Vo3c9mUtok=; b=U5b+XHpYvkhPIG95cHwg8OqhAjkc2xIkHxbhmwqJiu55VUoBW95qFt1W0o8YHYYdH12Zv97VHzey8Snkn0hFxpuq9bqyF6hTBNJqlEgEK+HsEB09pIpLA8KgrBQdMOJwWWl1/9dLeCd82rgXmijPnTzRLWeUNwWlCh8NCApfYEau/4Hp9hiPIZ6UmbfcKecAY4huKXScdghe8Xi/QL6Ui+cJNiWCEFHOptuzd0pzSlRLt53bSH9rTrZhkChv927hL3q9f9c4QCliQLlczKJqmGOKD6mwM6xbZc9f3N357QM7XO2TkF9cJyFmvn61nydNDE4arlBuCXrkYBUtn6pVkA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by DBBPR04MB7788.eurprd04.prod.outlook.com (2603:10a6:10:1e4::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8048.27; Tue, 15 Oct 2024 22:08:13 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%4]) with mapi id 15.20.8069.016; Tue, 15 Oct 2024 22:08:13 +0000 From: Frank Li Date: Tue, 15 Oct 2024 18:07:17 -0400 Subject: [PATCH v3 4/6] PCI: endpoint: pci-epf-test: Add doorbell test support Message-Id: <20241015-ep-msi-v3-4-cedc89a16c1a@nxp.com> References: <20241015-ep-msi-v3-0-cedc89a16c1a@nxp.com> In-Reply-To: <20241015-ep-msi-v3-0-cedc89a16c1a@nxp.com> To: Manivannan Sadhasivam , =?utf-8?q?Krzy?= =?utf-8?q?sztof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Arnd Bergmann , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, imx@lists.linux.dev, Niklas Cassel , dlemoal@kernel.org, maz@kernel.org, tglx@linutronix.de, jdmason@kudzu.us, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1729030073; l=5157; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=vg1b8fZ0ikOaTJqSjYHEd0OEjyDNFXGxJ24NF7GoDWk=; b=tm3dItJmYQGV/xS43LPWjmHikztC3AnbZl7D7Z+wQ3GrxC1/3sRNYLjPHJlmaGUdvqnaCXsGB tfP5d/mPvPAB011H898pLmyGcExmW6jX9AtvG4AGGYhgiwoL8shSIpx X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR13CA0059.namprd13.prod.outlook.com (2603:10b6:a03:2c2::34) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|DBBPR04MB7788:EE_ X-MS-Office365-Filtering-Correlation-Id: 1288cba9-37db-4f32-6560-08dced65dcdb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?o79n9ANHnVRAfsLVm75kszWcvCBeThQ?= =?utf-8?q?CSnagwUFCEaMx9VUpxFz99o5w/ihvyogLGbE+skaZGkeVD6sU3HXPsy55WmtP+6yY?= =?utf-8?q?bNOKXmrOr5c/WBeKrAXuwmMwRCmoL3jA7v/UiuvxEs8U2xJEh0SFJCkBbk/iM94ad?= =?utf-8?q?Fw8cXUReKrHpx0pUvdLZri5Gf19Fm1WQllCIMhQ+Zz/QtsTCRuCwWLZ+B7NuEtbwh?= =?utf-8?q?ETZFBiexxd8g0KWlZ83o9RfxkvrmquR853VGphyZFweu4kKh+A1z5YhHtSZeKEidC?= =?utf-8?q?Pae24W99bZD/2vAj5tDsbnnCpImNfAG6y0b3Hj+31p4dQUzoSVQjeRVma/C9ILsYP?= =?utf-8?q?q7UJzBKpvsTB54QpJ85hL8Iw7cEnqEI3OVZyGenHjSg+J9Qc4s9bCqSO8WvXxHzgA?= =?utf-8?q?Ba9mDKyCCOrHTg6PzpMW5OMQWQ95LpTOIrIfBrDRp+lrsDR1pOwz7wItJmbQCkI++?= =?utf-8?q?zWdCLmqPdkztOEQ2QGBlabl27r//zXiMIHqYuqYhBe8la7hoPOS6KUTL6b6e51skc?= =?utf-8?q?AbBmDG4ZR9x9Gav2A8vDSVEoEwBRMMVN3jNsu2/Pp//0NhrqIFkfsPNH0MFYAEsji?= =?utf-8?q?SQ7L8O9fWHSU3V86XZu2NKDS2yatbO84tjeWif0NyZDdEaxh9HQfzzkIgl18s9wHH?= =?utf-8?q?FbhZ257ckcFBQyuEJLCTSBQdlYWPHnEYVzrqNiKyN2fLbCk45bM4MXid7jYxJxhOP?= =?utf-8?q?jW64bvjZI5opj+TCLIWntRK047jkupMF32BGsjO0CfTWU/oydhi/b0pEUSUi5M26/?= =?utf-8?q?2I2LIbexeLTu4yyZngadZIZP9ov0wqryLb1ZeIJ9VxsrzjUc9Y/lcQ7pVQikQcxr8?= =?utf-8?q?TDNmUbx9o74VqcIMP+HKCLve5R8lAKgFex79MjdLBubLT23sqYYlqxgeF8+rReIPz?= =?utf-8?q?bYxVN1Ex7IM1o7A6EzbydCumJzaBeD0U3UfU9/s/VowjN4Cxwt3iDX/E3PGy3h2Sj?= =?utf-8?q?sDe5HjHJN1Z9dRiolwQwPIqR5XFE+XHSmDZBo5oJZ/VQvGbSDe4HA5cEiRrveuoVT?= =?utf-8?q?pJw0VEnVYO2aGz1zsU9d7s/kvmKRW9AnCeT37WBUnXaftTZjklgmvk8iUnZllwfT9?= =?utf-8?q?AxHsa4RD0cibd7BdmSrqkMHsbXwaatgDodzRgp/LOqyYourvd7D4pRV79MmYaCmzn?= =?utf-8?q?3aaxDCF6xlkQBuZ1v6W3FbpQKf3H5y4QDm5TpOAFnevae7BGj3QffCoSB+pWwS24v?= =?utf-8?q?D2mpMU1n778McO1DRPInSGF+ACmrX04d46wEpVCIbmuIYvo7FkkD3h2/WhwiaN4tX?= =?utf-8?q?Wsv0B9oLdftDWBjdSRBsTSgWjLVR5xNCzyQ=3D=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?rLkGwmuQ+mP4p5JOtDBpW0KOiyZE?= =?utf-8?q?Yo2HNGl0IGifG28uDoudgucuhbtW7zUZGLUCDvfwZY6YzvVJSGplE0XAIdfvkkaSP?= =?utf-8?q?okhBov0pRSWHPSiRQHEdDHTqdYmzAwHgyQzn5Kiz7M6tmYwYX7rYgu32SzKhL2dlY?= =?utf-8?q?cM6zVhU5C5LPvvUrMUzDKhmTNzWxzeUecQx+LRsxtccMwj+ORGmG1CNKMNEUutuq1?= =?utf-8?q?sKSyPWlBieDsUZ7sWEg166szosGcWcsrMopdrEVAVnrsSnPymXYNoSJnktecj5tU5?= =?utf-8?q?3JsyFqsPyv6vDUgFdp3rgVx7ACSxwfOxObreMMRW286/w2+59XjcPS+jTAf9l/BT5?= =?utf-8?q?/2s/Jq9T03vrhRzXxykP9QbeFjErNASBfoUy2NaYq+rr+RHVRIdwVCPUT0N2/xS1E?= =?utf-8?q?rcMPyPpu4+eCjD8lBF5hTKFxDq3RfxY/dOqijv+pdoCNjhq2t0xAqe2cXEASuCmOz?= =?utf-8?q?Mb/RGEZuS//hodfj2/rSZzEz/OT9N0sbSvjFK77jIS9Zl67I3I3k3tlEiRoHOlpbs?= =?utf-8?q?W3IKQ5WE3AMiwZMmflcQRXtCadAy7fABeZpGDvkmDUcqQ+6feQAY3Uh+Qw/drMHO4?= =?utf-8?q?/7LtiL2sbLtJu69b7qlTle83lywg0qVrZp2aPNe1Lj86EIpgVQZHNzjIC1w3tlduG?= =?utf-8?q?oZokrxnoMZv8pR/sDmwXApvFRqlfDNVuEC2+Edp8Q5Sdib08eFOfBpJ3tuvtT3W1O?= =?utf-8?q?x5Yi9Oj1zS3hDBUUG0kRDPI4RrtXQAd8RdpRXZKLRCXKBvpus0R85XGu1j5mFZKo2?= =?utf-8?q?c5TDZTkoikm2UkpsDdbeNol+N8uzL5lfLqzp8wO19Pu/Q2h3d74QYoB3rDtMP9kXW?= =?utf-8?q?j1bHninWf25+qQRrRgh+/W56m71mIoxQp1K2jfBab61uZy3msqChLaFbAkU9LCJYW?= =?utf-8?q?cFOfRsAKDWuJx1Ps7CTp/uEDR4JpybhBYTfahMDJTgfuicqKSrq+uiQCSpiot3NY6?= =?utf-8?q?tBTBtObjmPBAYSHCi+QqCX5FMUf/NrgvxAgrA0nvlm2oXe1zJP0JY/Uyi69ZCcou/?= =?utf-8?q?IXGoxyYv/luEr6kbHP0dDvYuLiT7sbzg3RZmW1NS0pNCHqGUeFCUaxGLKXHW+B0zy?= =?utf-8?q?yxG9WZBk1ptHNcXoRwcZO7BUIs2qlqE4cRFZGRQj4HXeIfsxiGEajDbuyZzKYyL3h?= =?utf-8?q?PLbv3RTJX85xsRzy5JWBHT3WJEiobI9SeOA0TEvArd2fbClDl/asuezQW7+RPKXQq?= =?utf-8?q?RE1A4Q8uSZ+piVdYDcCQTaZpYpJ3RXNUQo26z2ZLkPzTupMfONNp/bM1eQyOweJqw?= =?utf-8?q?39meZsDoUswUDuEtKhUpiI3sOiYsD/2Kos104G2bl91iN9lFH6RoxrljRk3+24kh4?= =?utf-8?q?J9U1WWi2qsTGfxNZ5zi5KMW5OjfoDGdBcbkf5LWMRmORcLrzihTQXAgpdpVj3yO+b?= =?utf-8?q?oumGYLTxtiZ0ay6DLgxm52jf2thSzDYxJAziQF5G0nt4Y8MzsLJACTtUIKq9N+dFd?= =?utf-8?q?yPO+Mb32e7xbHnWbyj6xoNabHh5jT2MeytDdCyVH/Gw+ELDQa/fhsItE=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1288cba9-37db-4f32-6560-08dced65dcdb X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Oct 2024 22:08:13.3583 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: YbGAvhfc3XY3p3nmM4S4nagpL7gAQW+47MTtUJmvTofozIv7+cxFRfDbbM/0oLHwWygRe73zhbca7YzxIoohEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7788 Add three registers: doorbell_bar, doorbell_addr, and doorbell_data, along with doorbell_done. Use pci_epf_alloc_doorbell() to allocate a doorbell address space. Enable the Root Complex (RC) side driver to trigger pci-epc-test's doorbell callback handler by writing doorbell_data to the mapped doorbell_bar's address space. Set doorbell_done in the doorbell callback to indicate completion. To avoid broken compatibility, use new PID/VID and set RevID bigger than 0. So only new pcitest program can distinguish with/without doorbell support and avoid wrongly write test data to doorbell bar. Signed-off-by: Frank Li Signed-off-by: Niklas Cassel --- drivers/pci/endpoint/functions/pci-epf-test.c | 58 ++++++++++++++++++++++++++- 1 file changed, 56 insertions(+), 2 deletions(-) diff --git a/drivers/pci/endpoint/functions/pci-epf-test.c b/drivers/pci/endpoint/functions/pci-epf-test.c index 7c2ed6eae53ad..c054d621353a6 100644 --- a/drivers/pci/endpoint/functions/pci-epf-test.c +++ b/drivers/pci/endpoint/functions/pci-epf-test.c @@ -11,12 +11,14 @@ #include #include #include +#include #include #include #include #include #include +#include #include #define IRQ_TYPE_INTX 0 @@ -39,6 +41,7 @@ #define STATUS_IRQ_RAISED BIT(6) #define STATUS_SRC_ADDR_INVALID BIT(7) #define STATUS_DST_ADDR_INVALID BIT(8) +#define STATUS_DOORBELL_SUCCESS BIT(9) #define FLAG_USE_DMA BIT(0) @@ -50,6 +53,7 @@ struct pci_epf_test { void *reg[PCI_STD_NUM_BARS]; struct pci_epf *epf; enum pci_barno test_reg_bar; + enum pci_barno doorbell_bar; size_t msix_table_offset; struct delayed_work cmd_handler; struct dma_chan *dma_chan_tx; @@ -74,6 +78,9 @@ struct pci_epf_test_reg { u32 irq_type; u32 irq_number; u32 flags; + u32 doorbell_bar; + u32 doorbell_addr; + u32 doorbell_data; } __packed; static struct pci_epf_header test_header = { @@ -695,7 +702,7 @@ static int pci_epf_test_set_bar(struct pci_epf *epf) enum pci_barno test_reg_bar = epf_test->test_reg_bar; for (bar = 0; bar < PCI_STD_NUM_BARS; bar++) { - if (!epf_test->reg[bar]) + if (!epf_test->reg[bar] && bar != epf_test->doorbell_bar) continue; ret = pci_epc_set_bar(epc, epf->func_no, epf->vfunc_no, @@ -810,11 +817,24 @@ static int pci_epf_test_link_down(struct pci_epf *epf) return 0; } +static int pci_epf_test_doorbell(struct pci_epf *epf, int index) +{ + struct pci_epf_test *epf_test = epf_get_drvdata(epf); + enum pci_barno test_reg_bar = epf_test->test_reg_bar; + struct pci_epf_test_reg *reg = epf_test->reg[test_reg_bar]; + + reg->status |= STATUS_DOORBELL_SUCCESS; + pci_epf_test_raise_irq(epf_test, reg); + + return 0; +} + static const struct pci_epc_event_ops pci_epf_test_event_ops = { .epc_init = pci_epf_test_epc_init, .epc_deinit = pci_epf_test_epc_deinit, .link_up = pci_epf_test_link_up, .link_down = pci_epf_test_link_down, + .doorbell = pci_epf_test_doorbell, }; static int pci_epf_test_alloc_space(struct pci_epf *epf) @@ -853,7 +873,7 @@ static int pci_epf_test_alloc_space(struct pci_epf *epf) if (bar == NO_BAR) break; - if (bar == test_reg_bar) + if (bar == test_reg_bar || bar == epf_test->doorbell_bar) continue; base = pci_epf_alloc_space(epf, bar_size[bar], bar, @@ -887,7 +907,11 @@ static int pci_epf_test_bind(struct pci_epf *epf) struct pci_epf_test *epf_test = epf_get_drvdata(epf); const struct pci_epc_features *epc_features; enum pci_barno test_reg_bar = BAR_0; + enum pci_barno doorbell_bar = NO_BAR; struct pci_epc *epc = epf->epc; + struct msi_msg *msg; + u64 doorbell_addr; + u32 align; if (WARN_ON_ONCE(!epc)) return -EINVAL; @@ -905,10 +929,40 @@ static int pci_epf_test_bind(struct pci_epf *epf) epf_test->test_reg_bar = test_reg_bar; epf_test->epc_features = epc_features; + align = epc_features->align; + align = align ? align : 128; + + /* Only revid >=1 support RC-to-EP Door bell */ + ret = epf->header->revid > 0 ? pci_epf_alloc_doorbell(epf, 1) : -EINVAL; + if (!ret) { + msg = epf->msg; + doorbell_bar = pci_epc_get_next_free_bar(epc_features, test_reg_bar + 1); + + if (doorbell_bar > 0) { + epf_test->doorbell_bar = doorbell_bar; + doorbell_addr = msg->address_hi; + doorbell_addr <<= 32; + doorbell_addr |= msg->address_lo; + epf->bar[doorbell_bar].phys_addr = round_down(doorbell_addr, align); + epf->bar[doorbell_bar].barno = doorbell_bar; + epf->bar[doorbell_bar].size = align; + } else { + pci_epf_free_doorbell(epf); + } + } + ret = pci_epf_test_alloc_space(epf); if (ret) return ret; + if (doorbell_bar > 0) { + struct pci_epf_test_reg *reg = epf_test->reg[test_reg_bar]; + + reg->doorbell_addr = doorbell_addr & (align - 1); + reg->doorbell_data = msg->data; + reg->doorbell_bar = doorbell_bar; + } + return 0; }