From patchwork Fri Oct 18 10:00:57 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13841482 Received: from EUR02-VI1-obe.outbound.protection.outlook.com (mail-vi1eur02on2089.outbound.protection.outlook.com [40.107.241.89]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC4DD18872A for ; Fri, 18 Oct 2024 09:52:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.241.89 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729245174; cv=fail; b=g3ehwJtAgsQ/T5pSs/QtOmJWhDDMNXsqKrmy6rXHvtrz9MjShPVdl8FJypv/QTu/tREGsXYyibuwK9N3vGVdSZknwDCBSg8rNIsDgeyZrFEiLcCZGrVdUPeRuoDTkdX6aaZNAP02euASYlokAoQA4uVGVo9bNiTbRqtRkbxscdY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729245174; c=relaxed/simple; bh=v8ksMBxvbeVAy80xC/9SxZUA+6+FZGxZgqOBK4nC2MI=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=gc2Ep89sVR9Tium1Sv/a37AEZoweT/ZK1uNvHWm+qBtRIm0AUrqRPgkUnART0i2hQiw7erludZ71bjzompPrdomEGyO32jlU3GG+5HPUM3+nWZFqXEGK7bqYqdvUcbLft3CgZq2I0Yf55jGAH4ZT4m6RRuqdCJebXuet0qhClJo= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com; spf=pass smtp.mailfrom=oss.nxp.com; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b=jbZYfts+; arc=fail smtp.client-ip=40.107.241.89 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="jbZYfts+" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Z/0LLIBBNeGZ6ZjSZgjtCXpatGAzlWQWssBxR27Zy7ZnsMSJLBF/Hr2I/bkOC0ta6ZB/7xtptXydSZOZNs6P8WKJ3ujoJlqEZZxww51AaPx+Z2ifzRWI/bPjQB78X1K2dJNHA1ncYNv7bpds4m5Q/Coxy/88M/otA7eDUfDQtAYzt08vuAFw7qTWiGAx/uHp44RouYRnqWWWTf+S4yihWFtDqR8DK5o4vXOYoD6WPCA9Zu3J1BuXMnkEeuKKMe0jnt/4LCgrF+Atc1zVwmWBSO5CCSH7cJNEI44lTwPk7Bsu7GcaKHs/Wvc5+NFvzyN8Dq42DsJiLdtU4k4HrHZa/Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tll9CQpoI2JYPFCpRJcMtd6vZ7urFG2dHGkXxAOPskU=; b=ghCvP5JJaAb7nG4Eg0OEkwxwFdDlZh5ZvmuIAUSHtZFbqICDF59EFDcvOUPnxjmj2gDzjamBP+D4iOZT18AtotegP5NIQ0UV0Mk4cA044NbuzcdAr0/bRr2tzDvJ6sER3qCRDKVGa09HCaj8GhQQj5yI8JMIq/AP05z8wiNP5Q7C74hZ0Xku6UGDrHUP+Vstn8ceen+KWceEmmRugLppFAam/g0l/2a+dfdE2AExFyrn0ckpkw5FQ/4N8xpkllpGzuy8UvcdI/oQLJbH7Dy9waxwu9yNvKQH/rAUNi4t5X1ZvhjFiGDSDOilpPEPlJuvwb+xcsvNQU+SGKX2ZxUlag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tll9CQpoI2JYPFCpRJcMtd6vZ7urFG2dHGkXxAOPskU=; b=jbZYfts+LEQj2uhI+cLMeaaSot0zK0/WIvdfsZB8SQRZjtzJfo+qZJuEdml2krbp+WxSrESP9GZReuxPFeHEXqQNcuoE0nrFxG2uWqXLG2uP18l4WAVEGX5Tm/S9OzyoFVV+DtE27gAo71MW+0YihTaeDGlOZywMmCPdx9Km5eommc5SOoqSHxZ/Foq04Dsd+xojGYVulm2IYS9ZNa158qHCNqm/+BveXSEh09t1r7kWmjGsJW+R9MX49c4IOsjcRR2UockvxF1iQYsPwQ3lmNQ/ti2nZDJHiyr/uZj1VPdd/fMBvMBp6AYGDmkJ0yNIcuXgM/KU09Xcu1/lUQa1GQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by DBAPR04MB7285.eurprd04.prod.outlook.com (2603:10a6:10:1ac::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8069.20; Fri, 18 Oct 2024 09:52:45 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%6]) with mapi id 15.20.8069.016; Fri, 18 Oct 2024 09:52:40 +0000 From: "Peng Fan (OSS)" Date: Fri, 18 Oct 2024 18:00:57 +0800 Subject: [PATCH v2 3/4] clk: imx: fracn-gppll: correct PLL initialization flow Message-Id: <20241018-imx-clk-v1-v2-3-92c0b66ca970@nxp.com> References: <20241018-imx-clk-v1-v2-0-92c0b66ca970@nxp.com> In-Reply-To: <20241018-imx-clk-v1-v2-0-92c0b66ca970@nxp.com> To: Abel Vesa , Michael Turquette , Stephen Boyd , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Aisheng Dong Cc: linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan , Jacky Bai X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1729245675; l=1523; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=Sv4CHyV16UexiFdZ+yIX03Ey/S7U3vzUPoU0hMATx6E=; b=DSOgn3MmfKf9qUurppWcHeibwzQ634wERjidpXq8wcEo6dML0JSZjn0YQQTXq6G9GACruCnpH FvZvsurJmT9CixVl+oBbQjkYWhWSNlD3FgaWeHqxwNGe4nt7VhB/xqI X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2PR01CA0028.apcprd01.prod.exchangelabs.com (2603:1096:4:192::21) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|DBAPR04MB7285:EE_ X-MS-Office365-Filtering-Correlation-Id: 64c9acf6-5414-42bd-b798-08dcef5a9aff X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|52116014|7416014|376014|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?dnhGO+0mRPAuAhQtgsl/dwWH94/ViK9?= =?utf-8?q?We//0dWXk3cNCSNLSA8AgDKMCwPq0nN54BHfIj7/AYjzBHN3JaClbh3i/vjGiAO15?= =?utf-8?q?Oe6t1cbC6rhMgKQlWz3i2kKF8uTg6/pGX/u0uA/df7tdp9nenmDCv9Eg+CvqFrzS5?= =?utf-8?q?QUSiMO5oKKJE/Hljan+yt7K0fBn5wAL4AlY6L3KtBWHzYmVhhNLbWugPkEWN9bGVo?= =?utf-8?q?GipPNrSOLnMCallgliCJ3v5AfC1l8Sq1C71oD8Gc5QAqmGhHgAHOQH+24LWvVQrMx?= =?utf-8?q?PCiaMwmujctMVSny/ZtIVn4uk/u3652sg7HSjpMZoUIDXgz++jC9J3SroqtxvfL6w?= =?utf-8?q?jCku5CuvKQ347c/8htl4fqJqKewNSlbHE0hKxxMLefyAP4lAAMmS7at1ia36iq8rh?= =?utf-8?q?WgKe85UBJQfMFpn0/SwVZZm7CGzYcPhAkqDH74j/WA8miQngbNydfSu1p5ZFNN1Ts?= =?utf-8?q?Bv8SA9RiJBgZr5uXmnJ0w/R5YTn0rJ/ijQzAz/CAWGtTM68+hbnvFJ8IuS1NpafzJ?= =?utf-8?q?HyrboCGuNd5hF0rwzUCdyR1ztmdQq9n679VKb2DjgCGxXqWcEbckWjmsXKOJgNXi0?= =?utf-8?q?Q2sFkDCStc49r8cG1JuySZXgBYNru/s4Qksse7klIscT39ztYJiCZNp6Eeb+g0AUp?= =?utf-8?q?5jLgJOF2jxLo3bphvq4GtjSdrLbDQ4CR3KRYAYuQjfcZyiexENS6VsHZonpubtXZK?= =?utf-8?q?b2kHXkurgsknVv3lKd32UWFlRtFfR5NyQrhCIb9TganQzHn+X8o3128UfRYhnoCKF?= =?utf-8?q?/Qi0Zc6drezULC4xSzfEu/ZGsUWWSJNhDiGO4XzD72ab3S81xi6L3p8dXmHAsFhQE?= =?utf-8?q?46weQJxk+HX5ql1DSTfOSD+Sj8TWMDQowvEPObSo8ofyE+TCzoNWBdT+jLScLkH55?= =?utf-8?q?4aoB/zIKfhCouYYzZRQFbkLLgdmp7d7mqz5gsEEhnI/bko3HkmDljAAx0xEslAWLR?= =?utf-8?q?4Cp1j+gsKhw4QU8//YRJVdFa3LvSk75LVHmVB7cjszns19ir34ivvJ1DYaNyyMLMu?= =?utf-8?q?3u1skLlyF3BhMQUBzvlrUg/eQdtEHREZHVbBAn3L9mpXmd+STOaxi9rtOeFFgfQJY?= =?utf-8?q?kFtos2LaQnUEbqDWqzEgzGyXnVAMVh7WbJnVvFJ+tyajSJ3pdUu7eZ7cTY4kT/4BV?= =?utf-8?q?StXvMF6bSUdLJn3eTDHQJL+BfUM0wqUXCyByu62LVHvYnU5tKY/8GVtTqq2HC9xVy?= =?utf-8?q?GZHeHAUCGrlvnvjSthTq6STowZi/Ar1gp5d/xAv3RklvnSL6RGxII0z5nOX3wtWms?= =?utf-8?q?GLs4CeDmi/J5qpvgJsL6bahvL5r07wHzMB5l7rLc75hUrykp8jo6+LMc=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(52116014)(7416014)(376014)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?I3wbnTM76E/TaDrEUXaiLzkjpw8s?= =?utf-8?q?LEeVYGaqlscnf/yOqjHUrbgCpGnygK05d/iHoKdCw030czkU98k/ymqtwyUSxMp+v?= =?utf-8?q?wzesaZkuyV4Z8xXHnz7Bw6/9Txe1fTKBMqgeegSEr/XAY5sC/LHFssEIT+RmKzIdB?= =?utf-8?q?fT6+Gb1LPkwp/VooPYz7m2BU0KJJGHrpaBq+nCqZqgj7oD44wm2S4OLEyrYgMsoep?= =?utf-8?q?YrKHiVnAMryTqvppv84yirtMurFuJB9KYPFYqKlGET65V1qXjGAHDdXWORq3y0gSG?= =?utf-8?q?zfNcjQBHyw/TF0X9ssrc4hx5OXCsWygXDMBDYYKc1DwXHm/8LV1gWu3SYip3PGFNs?= =?utf-8?q?SFdvRPW244Oei8jrEf65F2NzW6+A4D2dpCl8ggBdZqYgNuXLQAiYEwf4ZwbWIR5Ya?= =?utf-8?q?IijyvzjM3CnU8FJdDBFrZbV22Aja1SKwwJdZq4GpS6iHF/KE8Y/sTdlX5XieuNacW?= =?utf-8?q?r+22gZ2TYZt/YO8dtJfCvqgsTLv9auOvAQYEn+PRw43y4gu95KVQXHCSkeJzMyjat?= =?utf-8?q?D2qJcScHJLknRiv7suUSZGuQ8ydHcaZDb86NRsVdJD/BQrAnkN2XD6bUmJfYlYt0X?= =?utf-8?q?WxiuDfzpWReeEVXTZQ0rER589lEkUcVx2x0AoPR067wZM700lVLsp9Lp1Z4vIKEuZ?= =?utf-8?q?Z7orTlXCUUmCP/yddP/rgk7+wtim0dpmkBSOjrYbGxyIEUkOwfrVtyGQZBimwEpDR?= =?utf-8?q?7hylKBsivO/zu3/QnumD5zgL395v1QuYTmfMP1ko6bQPOSkj+Re8n0Nwi4booGNcn?= =?utf-8?q?C/y1Vu+mdgt/t8g4b6ULmJ+kadrdMnDF1UohqNvEObPCB4LDTwDK5RrTR6UOaSjgd?= =?utf-8?q?t+icxEC0cl66mrnWhP4yux8cs8VHJjsRUTwc65P7WkMgvhvFz8yBnAFaERSYWt5mg?= =?utf-8?q?NcmTJ6ynFcZRrQ704lx0W3cbYyEtekvzP5MoctHyPXjhNTp8zKkCa0e9sqtpPA/mk?= =?utf-8?q?7LNgxzJWkhW1n+Kwxv1A/EdtELxwoU6Zo/oHbcfoCI4/qmGgQev9MHsgJ7lJBi+tg?= =?utf-8?q?9T+M1DpMfLraTc6oUdaLRitV+SreVh7j04kOlPdvi+EyyGjcsCnvv+XTPZawYh+yF?= =?utf-8?q?PGdlRmwBDR6Vczk0cnOHYxNnkXsak0nn0+Iz1XLXcm4MEb16XFolmvY39uTBCpjgo?= =?utf-8?q?vHK3LNxhgMmSN2idwvUUcAsLhXU81YeMk/cTcjYXC8r7kdBkZDE4qqwm4EMZE7m3d?= =?utf-8?q?g5bJYWqiPQGFOkii2dRBNhUCSVgGe8qsJmy5rnuCgEF++AR5jksBpt9iZvmEVz3us?= =?utf-8?q?H8b1vAcpYM4uAy3tikTVFgsqCkjNo3S2XASJRNtuwFKOlUf7ikPe5gFVV+Eexkdn1?= =?utf-8?q?2OqNc5udadT9vllR+CpQmbDB8u4zexKbdEWdy4QY21pUvIo2lpFp1+Vftp7D3S5vl?= =?utf-8?q?1deEw1iXJCja0sZGCz5Fi++MRXa26VY6bX0gUrfxSStgkj3kFp0wirYb8bw3KeoP1?= =?utf-8?q?8SLP5ES3jdNOQEu0dO4uNT1bYxC7z/4eloC31zOtuha203QRtHvpqYZMo+bF4GGYn?= =?utf-8?q?YhMAVPKWDitW?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 64c9acf6-5414-42bd-b798-08dcef5a9aff X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 18 Oct 2024 09:52:40.7530 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: jV0Dfm9exJm7db9bb3L6Q+HDouyhCmMEL3V8r6I9aX3k5CotXdMT6/1Pu3wcR91rgre1+sq8iV2DMqDE06TqfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR04MB7285 From: Peng Fan Per i.MX93 Reference Mannual 22.4 Initialization information 1. Program appropriate value of DIV[ODIV], DIV[RDIV] and DIV[MFI] as per Integer mode. 2. Wait for 5 μs. 3. Program the following field in CTRL register. Set CTRL[POWERUP] to 1'b1 to enable PLL block. 4. Poll PLL_STATUS[PLL_LOCK] register, and wait till PLL_STATUS[PLL_LOCK] is 1'b1 and pll_lock output signal is 1'b1. 5. Set CTRL[CLKMUX_EN] to 1'b1 to enable PLL output clock. So move the CLKMUX_EN operation after PLL locked. Fixes: 1b26cb8a77a4 ("clk: imx: support fracn gppll") Co-developed-by: Jacky Bai Signed-off-by: Jacky Bai Signed-off-by: Peng Fan --- drivers/clk/imx/clk-fracn-gppll.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/clk/imx/clk-fracn-gppll.c b/drivers/clk/imx/clk-fracn-gppll.c index 591e0364ee5c113859a7b6271c8c11e98a0e0ffc..4749c3e0b7051cf53876664808aa28742f6861f7 100644 --- a/drivers/clk/imx/clk-fracn-gppll.c +++ b/drivers/clk/imx/clk-fracn-gppll.c @@ -303,13 +303,13 @@ static int clk_fracn_gppll_prepare(struct clk_hw *hw) val |= POWERUP_MASK; writel_relaxed(val, pll->base + PLL_CTRL); - val |= CLKMUX_EN; - writel_relaxed(val, pll->base + PLL_CTRL); - ret = clk_fracn_gppll_wait_lock(pll); if (ret) return ret; + val |= CLKMUX_EN; + writel_relaxed(val, pll->base + PLL_CTRL); + val &= ~CLKMUX_BYPASS; writel_relaxed(val, pll->base + PLL_CTRL);