| Message ID | 20241105073904.2416057-1-xu.yang_2@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb: host: xhci-plat: set skip_phy_initialization if software node has XHCI_SKIP_PHY_INIT property | expand |
Hi, On Tue, Nov 05, 2024 at 03:39:04PM +0800, Xu Yang wrote: > The source of quirk XHCI_SKIP_PHY_INIT comes from xhci_plat_priv.quirks or > software node property. This will set skip_phy_initialization if software > node also has XHCI_SKIP_PHY_INIT property. > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > --- > drivers/usb/host/xhci-plat.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c > index e6c9006bd568..77853b86794a 100644 > --- a/drivers/usb/host/xhci-plat.c > +++ b/drivers/usb/host/xhci-plat.c > @@ -290,7 +290,8 @@ int xhci_plat_probe(struct platform_device *pdev, struct device *sysdev, const s > > hcd->tpl_support = of_usb_host_tpl_support(sysdev->of_node); > > - if (priv && (priv->quirks & XHCI_SKIP_PHY_INIT)) > + if ((priv && (priv->quirks & XHCI_SKIP_PHY_INIT)) || > + (xhci->quirks & XHCI_SKIP_PHY_INIT)) > hcd->skip_phy_initialization = 1; > > if (priv && (priv->quirks & XHCI_SG_TRB_CACHE_SIZE_QUIRK)) A gentle ping. > -- > 2.34.1 >
On Tue, Nov 05, 2024 at 03:39:04PM +0800, Xu Yang wrote: > The source of quirk XHCI_SKIP_PHY_INIT comes from xhci_plat_priv.quirks or > software node property. This will set skip_phy_initialization if software > node also has XHCI_SKIP_PHY_INIT property. > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > --- > drivers/usb/host/xhci-plat.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c > index e6c9006bd568..77853b86794a 100644 > --- a/drivers/usb/host/xhci-plat.c > +++ b/drivers/usb/host/xhci-plat.c > @@ -290,7 +290,8 @@ int xhci_plat_probe(struct platform_device *pdev, struct device *sysdev, const s > > hcd->tpl_support = of_usb_host_tpl_support(sysdev->of_node); > > - if (priv && (priv->quirks & XHCI_SKIP_PHY_INIT)) > + if ((priv && (priv->quirks & XHCI_SKIP_PHY_INIT)) || > + (xhci->quirks & XHCI_SKIP_PHY_INIT)) Wrong indentation :( Also, what commit id does this fix? Should it go to stable kernels, and if so, how far back? And if not, why not? thanks, greg k-h
On Wed, Dec 04, 2024 at 03:56:30PM +0100, Greg KH wrote: > On Tue, Nov 05, 2024 at 03:39:04PM +0800, Xu Yang wrote: > > The source of quirk XHCI_SKIP_PHY_INIT comes from xhci_plat_priv.quirks or > > software node property. This will set skip_phy_initialization if software > > node also has XHCI_SKIP_PHY_INIT property. > > > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > --- > > drivers/usb/host/xhci-plat.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c > > index e6c9006bd568..77853b86794a 100644 > > --- a/drivers/usb/host/xhci-plat.c > > +++ b/drivers/usb/host/xhci-plat.c > > @@ -290,7 +290,8 @@ int xhci_plat_probe(struct platform_device *pdev, struct device *sysdev, const s > > > > hcd->tpl_support = of_usb_host_tpl_support(sysdev->of_node); > > > > - if (priv && (priv->quirks & XHCI_SKIP_PHY_INIT)) > > + if ((priv && (priv->quirks & XHCI_SKIP_PHY_INIT)) || > > + (xhci->quirks & XHCI_SKIP_PHY_INIT)) > > Wrong indentation :( Will fix. > > Also, what commit id does this fix? Should it go to stable kernels, and > if so, how far back? And if not, why not? Checked the patch again, fix tag is needed and I will send v2 soon. Thanks, Xu Yang > > thanks, > > greg k-h
diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c index e6c9006bd568..77853b86794a 100644 --- a/drivers/usb/host/xhci-plat.c +++ b/drivers/usb/host/xhci-plat.c @@ -290,7 +290,8 @@ int xhci_plat_probe(struct platform_device *pdev, struct device *sysdev, const s hcd->tpl_support = of_usb_host_tpl_support(sysdev->of_node); - if (priv && (priv->quirks & XHCI_SKIP_PHY_INIT)) + if ((priv && (priv->quirks & XHCI_SKIP_PHY_INIT)) || + (xhci->quirks & XHCI_SKIP_PHY_INIT)) hcd->skip_phy_initialization = 1; if (priv && (priv->quirks & XHCI_SG_TRB_CACHE_SIZE_QUIRK))
The source of quirk XHCI_SKIP_PHY_INIT comes from xhci_plat_priv.quirks or software node property. This will set skip_phy_initialization if software node also has XHCI_SKIP_PHY_INIT property. Signed-off-by: Xu Yang <xu.yang_2@nxp.com> --- drivers/usb/host/xhci-plat.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)