| Message ID | 20241120135859.3133984-5-daniel.baluta@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Configure imx8mp dsp node for rproc usage | expand |
> Subject: [PATCH 4/5] arm64: dts: imx8mp: Add fsl,dsp-ctrl property for > dsp > > Audio block control contains a set of registers some of them used for > DSP configuration. > > Drivers (rproc, SOF) are using fsl,dsp-ctrl property to access those > registers in order to control the operations of the DSP (e.g for start, > reset, etc). > > Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > index 41ff40ab5da2..fa4ff75af12d 100644 > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > @@ -1616,7 +1616,7 @@ sdma2: dma-controller@30e10000 { > }; > > audio_blk_ctrl: clock-controller@30e20000 { > - compatible = "fsl,imx8mp-audio-blk- > ctrl"; > + compatible = "fsl,imx8mp-audio-blk- > ctrl", "syscon"; This requires binding update as I recall. Regards, Peng. > reg = <0x30e20000 0x10000>; > #clock-cells = <1>; > #reset-cells = <1>; > @@ -2433,6 +2433,7 @@ dsp: dsp@3b6e8000 { > mboxes = <&mu2 0 0>, <&mu2 1 0>, <&mu2 > 3 0>; > firmware-name = "imx/dsp/hifi4.bin"; > memory-region = <&dsp_reserved>; > + fsl,dsp-ctrl = <&audio_blk_ctrl>; > status = "disabled"; > }; > }; > -- > 2.43.0 >
On Thu, Nov 21, 2024 at 1:33 PM Peng Fan <peng.fan@nxp.com> wrote: > > > Subject: [PATCH 4/5] arm64: dts: imx8mp: Add fsl,dsp-ctrl property for > > dsp > > > > Audio block control contains a set of registers some of them used for > > DSP configuration. > > > > Drivers (rproc, SOF) are using fsl,dsp-ctrl property to access those > > registers in order to control the operations of the DSP (e.g for start, > > reset, etc). > > > > Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com> > > --- > > arch/arm64/boot/dts/freescale/imx8mp.dtsi | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > index 41ff40ab5da2..fa4ff75af12d 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi > > @@ -1616,7 +1616,7 @@ sdma2: dma-controller@30e10000 { > > }; > > > > audio_blk_ctrl: clock-controller@30e20000 { > > - compatible = "fsl,imx8mp-audio-blk- > > ctrl"; > > + compatible = "fsl,imx8mp-audio-blk- > > ctrl", "syscon"; > > This requires binding update as I recall. Yes, indeed. Will update in v2.
diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi index 41ff40ab5da2..fa4ff75af12d 100644 --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi @@ -1616,7 +1616,7 @@ sdma2: dma-controller@30e10000 { }; audio_blk_ctrl: clock-controller@30e20000 { - compatible = "fsl,imx8mp-audio-blk-ctrl"; + compatible = "fsl,imx8mp-audio-blk-ctrl", "syscon"; reg = <0x30e20000 0x10000>; #clock-cells = <1>; #reset-cells = <1>; @@ -2433,6 +2433,7 @@ dsp: dsp@3b6e8000 { mboxes = <&mu2 0 0>, <&mu2 1 0>, <&mu2 3 0>; firmware-name = "imx/dsp/hifi4.bin"; memory-region = <&dsp_reserved>; + fsl,dsp-ctrl = <&audio_blk_ctrl>; status = "disabled"; }; };
Audio block control contains a set of registers some of them used for DSP configuration. Drivers (rproc, SOF) are using fsl,dsp-ctrl property to access those registers in order to control the operations of the DSP (e.g for start, reset, etc). Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com> --- arch/arm64/boot/dts/freescale/imx8mp.dtsi | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)